From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.ciao.gmane.io!not-for-mail From: Noam Postavsky Newsgroups: gmane.emacs.bugs Subject: bug#18336: 24.4.50; When editing externally changed file, Emacs asks too many questions Date: Thu, 05 Mar 2020 12:54:41 -0500 Message-ID: <8536amk7q6.fsf@gmail.com> References: <87mwaq74xg.fsf@fencepost.gnu.org> <87h7z86hs9.fsf@stefankangas.se> <86v9nooxcg.fsf@gmail.com> <87tv38kp33.fsf@fencepost.gnu.org> <83sgisypbd.fsf@gnu.org> <87pndwklz6.fsf@fencepost.gnu.org> <83o8tgyn1k.fsf@gnu.org> <874kv83pg7.fsf@fencepost.gnu.org> <83lfokylpp.fsf@gnu.org> <87r1yb8kbv.fsf@gmail.com> <87wo8340ct.fsf@stefankangas.se> <874kv7ozf9.fsf@fencepost.gnu.org> <87o8tf7xu3.fsf@gmail.com> <83mu8yyawu.fsf@gnu.org> <874kv299f7.fsf@gmail.com> <87pndqet7k.fsf@fencepost.gnu.org> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="ciao.gmane.io:159.69.161.202"; logging-data="118112"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.3 (windows-nt) Cc: stefan@marxist.se, 18336@debbugs.gnu.org To: David Kastrup Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Thu Mar 05 18:55:12 2020 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1j9uiF-000UdN-Of for geb-bug-gnu-emacs@m.gmane-mx.org; Thu, 05 Mar 2020 18:55:11 +0100 Original-Received: from localhost ([::1]:54282 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1j9uiE-0006h0-R1 for geb-bug-gnu-emacs@m.gmane-mx.org; Thu, 05 Mar 2020 12:55:10 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:46730) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1j9ui7-0006gg-4v for bug-gnu-emacs@gnu.org; Thu, 05 Mar 2020 12:55:04 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1j9ui6-0000Jo-8g for bug-gnu-emacs@gnu.org; Thu, 05 Mar 2020 12:55:03 -0500 Original-Received: from debbugs.gnu.org ([209.51.188.43]:37726) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1j9ui6-0000Je-5f for bug-gnu-emacs@gnu.org; Thu, 05 Mar 2020 12:55:02 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1j9ui6-0001ke-3g for bug-gnu-emacs@gnu.org; Thu, 05 Mar 2020 12:55:02 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Noam Postavsky Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Thu, 05 Mar 2020 17:55:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 18336 X-GNU-PR-Package: emacs Original-Received: via spool by 18336-submit@debbugs.gnu.org id=B18336.15834308916713 (code B ref 18336); Thu, 05 Mar 2020 17:55:02 +0000 Original-Received: (at 18336) by debbugs.gnu.org; 5 Mar 2020 17:54:51 +0000 Original-Received: from localhost ([127.0.0.1]:43699 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1j9uhv-0001kD-9Q for submit@debbugs.gnu.org; Thu, 05 Mar 2020 12:54:51 -0500 Original-Received: from mail-qk1-f169.google.com ([209.85.222.169]:32960) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1j9uht-0001k1-OP for 18336@debbugs.gnu.org; Thu, 05 Mar 2020 12:54:50 -0500 Original-Received: by mail-qk1-f169.google.com with SMTP id p62so6175233qkb.0 for <18336@debbugs.gnu.org>; Thu, 05 Mar 2020 09:54:49 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:references:date:in-reply-to:message-id :user-agent:mime-version; bh=vDErV96Cx4WntFRWHXASXJwSnXS5sHaXr54bnwBY+eY=; b=A3S0IXAoSTzzO0nk/rDCEIjphBv3E04WbJmHj2OYtQsiNjZBu4DyRCpTzIxBG2TKft 1/oeznYpXNwae8MrhpxzzSwTygY/lfltPqI0NJqu7ByunW/c2JC7lsOcRSM/smKSU8jo ixSMnRZBPYMGANgdnxI9z8KLXhrKiefvEIJt6xBrab3cKFNfEAco+Ol/YXKuaL3InKv9 RZazlEmBzpIVd9hiMw3rXMA9h+aB8PsNjIhR0MOLUqQMIZTMIwd2DZfgyW5g0jKFkbiB mb8za218RKbAgQOjNTnFmaOGFI68uR/KBjUzF3PIBveayQ3lvFUzTTjgG9ZYwe9Lo01r 9G+A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:references:date:in-reply-to :message-id:user-agent:mime-version; bh=vDErV96Cx4WntFRWHXASXJwSnXS5sHaXr54bnwBY+eY=; b=Hbd6HSqbEqXMFKUUCumMxkYx8uioDMyvRXUkGaZ2TOWSghS7HouagOB53GWb7qL13g yLek7eqOilTjXc4TCVNx1iylxsdUblaXCmzoViNg2KCvU9WN73j82u92lg2A7KGYJs3K WwI+2B6iHuQFvidL3YTsNgD0BNd8Rvm8lRsaBMl2kZeFuZynTRvdJtwxzKXEHe938bhW DEEsS3my77BsXQ6RADicEYVYhOL4GR6i2/Z9JFZUYbVdaiBMhNerInEFDX5VMG/FN3dZ LJGwnKZDB13wGE69GQhrzHhQsaUcqy5ANjagaxfrChZVmTZ9ewLWNe52WZ8JjvQU/shR 1mGQ== X-Gm-Message-State: ANhLgQ3xfjsVkNA11RijUjomBY2ZNgO8fGqYi6BraN2q/EDe1FwmEY16 ZTO1JUq+cTWRdBwkAZLoVf3OCDuw X-Google-Smtp-Source: ADFU+vsslUJFJTP3iZNlkXGX5iLGMqLbIC3ul3LzZDk/dB83/LjsqF1vZWxihroGInuDfqo1a/1ewA== X-Received: by 2002:a05:620a:2116:: with SMTP id l22mr9175754qkl.311.1583430883953; Thu, 05 Mar 2020 09:54:43 -0800 (PST) Original-Received: from vhost2 (CPE001143542e1f-CMf81d0f809fa0.cpe.net.cable.rogers.com. [99.230.38.42]) by smtp.gmail.com with ESMTPSA id z2sm3066470qtn.23.2020.03.05.09.54.42 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Thu, 05 Mar 2020 09:54:43 -0800 (PST) In-Reply-To: <87pndqet7k.fsf@fencepost.gnu.org> (David Kastrup's message of "Thu, 05 Mar 2020 16:07:11 +0100") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 209.51.188.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:176931 Archived-At: David Kastrup writes: > Sorry for the red herring. It was the thing that occured to me first. No need to apologize, it was a reasonable guess. And anyway it led to the right answer in the end. Eli Zaretskii writes: >> What happens in the ~/tmp case is that when lock_file is called from >> write_region, the file doesn't exist, so the extra "changed on disk" >> question doesn't get asked. > Thanks. Any suggestions for how to fix this? A new argument to > lock_file, perhaps? Or maybe some additional check in > userlock--ask-user-about-supersession-threat to recognize the special > situation where we are saving a file? I'm not sure. Why exactly are we calling lock_file from write_region? The comment for lock_file says: Do not (normally) call this for a buffer already modified, as either the file is already locked, or the user has already decided to go ahead without locking. It seems we are doing exactly this, so I guess that makes save-buffer/write-region an "abnormal" situation?