From: "Clément Pit--Claudel" <clement.pitclaudel@live.com>
To: Kyle Meyer <kyle@kyleam.com>
Cc: Andreas Schwab <schwab@linux-m68k.org>,
Stefan Monnier <monnier@IRO.UMontreal.CA>,
27953-done@debbugs.gnu.org
Subject: bug#27953: vc-region-history doesn't follow renames
Date: Sat, 5 Aug 2017 19:27:21 +0200 [thread overview]
Message-ID: <852633bf-6cb1-3efd-824b-c93e5307b034@live.com> (raw)
In-Reply-To: <87poca9c7j.fsf@kyleam.com>
[-- Attachment #1.1: Type: text/plain, Size: 1033 bytes --]
On 2017-08-05 19:05, Kyle Meyer wrote:
> Clément Pit--Claudel <clement.pitclaudel@live.com> writes:
>> On 2017-08-04 19:21, Stefan Monnier wrote:
>>>> Indeed, `git log -p --follow -L5,25:file.c' doesn't work. But `git
>>>> log -p --follow -L5,25:file.c file.c' does work (note the extra mention of
>>>> the file name).
>>>
>>> Hmm... what's the difference between
>>>
>>> git log -p -L5,25:file.c
>>> and
>>> git log -p -L5,25:file.c file.c
>>
>> The second one allows --follow; the first one doesn't. I don't know what differences they may be beyond that :/
>
> As Andreas mentioned, even though git doesn't throw an error, giving a
> pathspec with -L is documented as invalid.
Thanks. I'm glad I sent the patch for review.
> But you shouldn't need to add --follow here. Renames should be followed
> by default when -L is used. (At least, that's what I see using Git
> v2.13.3.)
This seems to be new. Adding --follow appears to make git follow renames here (2.7.4).
Thanks.
Clément.
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 819 bytes --]
next prev parent reply other threads:[~2017-08-05 17:27 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-08-04 15:12 bug#27953: vc-region-history doesn't follow renames Clément Pit--Claudel
2017-08-04 17:21 ` Stefan Monnier
2017-08-04 17:40 ` Andreas Schwab
2017-08-05 13:06 ` Clément Pit--Claudel
2017-08-05 17:05 ` Kyle Meyer
2017-08-05 17:23 ` Eli Zaretskii
2017-08-05 18:03 ` Andreas Schwab
2017-08-05 18:26 ` Eli Zaretskii
2017-08-05 20:06 ` Kyle Meyer
2017-08-05 17:27 ` Clément Pit--Claudel [this message]
2017-08-05 20:55 ` Kyle Meyer
2017-08-05 18:08 ` Andreas Schwab
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=852633bf-6cb1-3efd-824b-c93e5307b034@live.com \
--to=clement.pitclaudel@live.com \
--cc=27953-done@debbugs.gnu.org \
--cc=kyle@kyleam.com \
--cc=monnier@IRO.UMontreal.CA \
--cc=schwab@linux-m68k.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.