all messages for Emacs-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
From: Wolfgang Jenkner <wjenkner@inode.at>
To: Stefan Monnier <monnier@iro.umontreal.ca>
Cc: 13160@debbugs.gnu.org, Kevin Ryde <user42@zip.com.au>
Subject: bug#13160: 24.3.50; [PATCH] man page completion support beyond man-db
Date: Sun, 23 Dec 2012 20:49:52 +0100	[thread overview]
Message-ID: <851uegr1jz.fsf@iznogoud.viz> (raw)
In-Reply-To: <jwvd2y0khov.fsf-monnier+emacs@gnu.org> (Stefan Monnier's message of "Sun, 23 Dec 2012 08:46:28 -0500")

On Sun, Dec 23 2012, Stefan Monnier wrote:

>>> Does it fix an actual bug? [ Sorry if it does fix a real bug and this
>>> was mentioned somewhere in this thread, but I haven't found the time to
>>> read all threads as thoroughly as I'd like.  ]
>> My proposed change log entry indicates that the cache handling is rather
>> bogus (complete for "foo" then for "bar" and then for "foo" again and
>> "man -k ^foo" will be run again and the result prepended to the cache).
>
> Oh, indeed.  Fixed with the trivial patch below, tho.

Well yes, you nuke the old content, whis is what the previous versions
of my patches proposed here do as well, but this can hardly be called
a useful cache then.

>> The main reason, however, is that it eliminates any dependency on the
>> particular flavour of `man -k' output, so everything can be done in
>> elisp by the new Man-parse-apropos (I indicated that in the change log
>> entry, too).
>
> That indeed the part of the change log I did not understand.  How does
> the "man -k" argument relate to the "output flavor"?

Well, I wrote in the proposed change log:

	Conveniently, the change entails that we don't have to guess the
	output format of `man -k' in order to pass it a useful regexp.

The problem is that the page names are not necessarily anchored at the
beginning of a summary line (there are examples in the proposed
man-tests.el), so we can't always use "man -k ^foo" to find all summary
lines for man page names starting with "foo".  A previous version of the
patch posted here introduced a new variable holding a suitable regexp
`anchor', which, however, would depend on the output format of `man -k',
its flavour :-)

I think that parsing the full listing obtained with `man -k ^' is the
best solution, it's just that storing the result in a plain list is not
quite optimal, hence my babbling about tries.

I can wait with my changes until we've found a better data structure.

Wolfgang





  reply	other threads:[~2012-12-23 19:49 UTC|newest]

Thread overview: 22+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-12-12 19:16 bug#13160: 24.3.50; [PATCH] man page completion support beyond man-db Wolfgang Jenkner
2012-12-12 19:31 ` Glenn Morris
2012-12-12 20:30   ` Stefan Monnier
2012-12-14 21:19 ` Kevin Ryde
2012-12-14 21:35   ` Wolfgang Jenkner
2012-12-15  0:59     ` Kevin Ryde
2012-12-16 18:07       ` Wolfgang Jenkner
2012-12-22 15:27         ` Wolfgang Jenkner
2012-12-22 17:11           ` Stefan Monnier
2012-12-22 17:58             ` Wolfgang Jenkner
2012-12-23 13:46               ` Stefan Monnier
2012-12-23 19:49                 ` Wolfgang Jenkner [this message]
2012-12-23 20:59                   ` Wolfgang Jenkner
2012-12-24  0:00                   ` Stefan Monnier
2013-01-06 19:27                     ` Wolfgang Jenkner
2012-12-24  1:20                   ` Stefan Monnier
2012-12-24  2:23                     ` Wolfgang Jenkner
2012-12-24  4:34                       ` Stefan Monnier
2013-01-06 19:48                         ` Wolfgang Jenkner
2013-01-10 15:01                           ` Stefan Monnier
2012-12-30  0:10                     ` Kevin Ryde
2012-12-23  0:16           ` Kevin Ryde

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=851uegr1jz.fsf@iznogoud.viz \
    --to=wjenkner@inode.at \
    --cc=13160@debbugs.gnu.org \
    --cc=monnier@iro.umontreal.ca \
    --cc=user42@zip.com.au \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/emacs.git
	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.