From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED.blaine.gmane.org!not-for-mail From: Noam Postavsky Newsgroups: gmane.emacs.bugs Subject: bug#22700: 25.0.91; `erc-echo-timestamps' no longer echoes timestamp for each line Date: Wed, 14 Aug 2019 10:56:37 -0400 Message-ID: <851rxn3ie2.fsf@gmail.com> References: <87r3gcmyfc.fsf@riseup.net> <871sfh4o92.fsf@mouse.gnus.org> <87h8ocei9c.fsf@mouse.gnus.org> <87imr0u7dc.fsf@gmail.com> <877e7gvhpq.fsf@mouse.gnus.org> <875zn0r9x4.fsf@gmail.com> <874l2kio0r.fsf@gmail.com> <837e7gsc3q.fsf@gnu.org> <87ftm36enn.fsf@gmail.com> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: blaine.gmane.org; posting-host="blaine.gmane.org:195.159.176.226"; logging-data="208586"; mail-complaints-to="usenet@blaine.gmane.org" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.1.92 (windows-nt) Cc: 22700@debbugs.gnu.org, larsi@gnus.org, monnier@IRO.UMontreal.CA To: Alex Branham Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Wed Aug 14 16:57:13 2019 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([209.51.188.17]) by blaine.gmane.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.89) (envelope-from ) id 1hxui9-000s9c-0h for geb-bug-gnu-emacs@m.gmane.org; Wed, 14 Aug 2019 16:57:13 +0200 Original-Received: from localhost ([::1]:33124 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1hxui7-0004Au-RY for geb-bug-gnu-emacs@m.gmane.org; Wed, 14 Aug 2019 10:57:11 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:36333) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1hxuhy-00049p-PL for bug-gnu-emacs@gnu.org; Wed, 14 Aug 2019 10:57:03 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1hxuhx-0007X6-TM for bug-gnu-emacs@gnu.org; Wed, 14 Aug 2019 10:57:02 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:40749) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1hxuhx-0007X1-PJ for bug-gnu-emacs@gnu.org; Wed, 14 Aug 2019 10:57:01 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1hxuhx-000702-MO for bug-gnu-emacs@gnu.org; Wed, 14 Aug 2019 10:57:01 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Noam Postavsky Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Wed, 14 Aug 2019 14:57:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 22700 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: confirmed patch Original-Received: via spool by 22700-submit@debbugs.gnu.org id=B22700.156579460926882 (code B ref 22700); Wed, 14 Aug 2019 14:57:01 +0000 Original-Received: (at 22700) by debbugs.gnu.org; 14 Aug 2019 14:56:49 +0000 Original-Received: from localhost ([127.0.0.1]:49570 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hxuhi-0006zR-KT for submit@debbugs.gnu.org; Wed, 14 Aug 2019 10:56:48 -0400 Original-Received: from mail-ot1-f53.google.com ([209.85.210.53]:42105) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hxuhg-0006yd-BV for 22700@debbugs.gnu.org; Wed, 14 Aug 2019 10:56:44 -0400 Original-Received: by mail-ot1-f53.google.com with SMTP id j7so38248635ota.9 for <22700@debbugs.gnu.org>; Wed, 14 Aug 2019 07:56:44 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:references:date:in-reply-to:message-id :user-agent:mime-version; bh=xYP0OGUrYJa4WU0YD5dNr8EqlcXbf0U6jyQ0QsSmizI=; b=MivBzRxh/vhrrTeaVTHvXtpJtbzkzL/TUcHLxaHU+yXMzDZiAal2LFT3rmIbq5e9WM pKC9rb3FQzmYrGASALM1wWehuPymAZVdZGRLbe82Y+AwDeQZb/tHPcl5ssi5tSR22Gnr 9k1AhtSYIWkELp2cMzl8QLVXmYRbfYdUJGAU0G6ytDSoDU4UeqUEKzp3zaYZszv/oKKj tjrS698GjQVZ1aPHxPCsfRe5wlzIpLDHpWaOWfYvcRN3cBv4hDicbJzo3bmOPgZZKkXw aU0NtA9ZmKejd8AxG03H3OWY3LQ4wK8kPixpNim5dC6qW0O50I8Jz0ewvblBwI9PTLiW +NgQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:references:date:in-reply-to :message-id:user-agent:mime-version; bh=xYP0OGUrYJa4WU0YD5dNr8EqlcXbf0U6jyQ0QsSmizI=; b=iNaf23im/lC1elzfGAS1UMix7po4L7AZhBr8CvXio6mhvlEQxicylb2sUE6LJl+ptL nGR8i6LrctzMJVmV0/1mHQtCd5dhHnRZsZcfacYNfxkcgD4XI8pVJ9XqnG+3kDbiIZ+X rasuyPUyb3lfMPvLguKlSzfqyKg83rjPj3JJ9qGjRXG1DHZ6KreOltwyGV3gTP8qS6wQ xhRvOMYLcQQOjtMzwrtBU6jtsjSVkxwjZxD7GStp+y+pUIFtyiFX8hgdvVCtBtPvnsNH pTb2ySeDy1SoMjbDOxrSH1Jf8WvAwrtaoHPjMEhgPg4uiuQYrF5YHc+X8uTIDQUSm7TB cDkQ== X-Gm-Message-State: APjAAAWIpg83j1Gwvwim1t/Qj+jWRUTOsOafV/aBFQyNRXxx+P6XBdiO Y0dBzSdSDyD4+5yU/pmWaU0= X-Google-Smtp-Source: APXvYqzkTUuxMWgy2v+c71rwurf47GmPfaKqno6VK35eSfwcyGdG46kLtsk2FGDBHOebp/1TG2ckIQ== X-Received: by 2002:a5d:8c81:: with SMTP id g1mr295527ion.239.1565794598628; Wed, 14 Aug 2019 07:56:38 -0700 (PDT) Original-Received: from vhost2 (CPE001143542e1f-CMf81d0f809fa0.cpe.net.cable.rogers.com. [99.230.51.196]) by smtp.gmail.com with ESMTPSA id q22sm55847ioj.56.2019.08.14.07.56.37 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Wed, 14 Aug 2019 07:56:38 -0700 (PDT) In-Reply-To: <87ftm36enn.fsf@gmail.com> (Alex Branham's message of "Wed, 14 Aug 2019 08:49:00 -0500") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 209.51.188.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:164976 Archived-At: > + (when erc-echo-timestamps > + (when-let ((stamp (get-text-property (point) 'timestamp)) > + (message (format-time-string erc-echo-timestamp-format stamp))) > + (unless (string= message (current-message)) > + (message "%s" message))))) I'm not an erc user, so perhaps it's just expected to be this way, but this sounds too aggressive to me. E.g., if you run a command like describe-key-briefly its message will immediately be replaced by the timestamp. I was thinking erc-echo-timestamp would just save the last timestamp it sent in a buffer-local variable, and then only send a new message if the current timestamp is different.