bug#39345: 28.0.50; rcirc-authenticate-before-join due to case sensitive mismatch

bug#39345: 28.0.50; rcirc-authenticate-before-join due to case sensitive mismatch

[Jake Nelson]

1. join irc.freenode.net with a lowercase nick "examplenick"
2. authenticate to nickserv
3. nickserv echos back  "-NickServ- You are now identified for
"Examplenick" capitalizing the nickname.
4. rcirc-authenticate-before-join does not trigger, so no channels are
auto-joined.

The existing check is case sensitive.  The patch below fixes the issue
for me on freenode.

diff --git a/lisp/net/rcirc.el b/lisp/net/rcirc.el
index 5722582ab6..b516c8d0a6 100644
--- a/lisp/net/rcirc.el
+++ b/lisp/net/rcirc.el
@@ -2624,12 +2624,12 @@ rcirc-check-auth-status
         (when (or
                (and ;; nickserv
                 (string= sender "NickServ")
-                (string= target rcirc-nick)
-                (member message
+                (string= (downcase target) (downcase rcirc-nick))
+                (member (downcase message)
                         (list
-                         (format "You are now identified for
\C-b%s\C-b." rcirc-nick)
-                        (format "You are successfully identified as
\C-b%s\C-b." rcirc-nick)
-                         "Password accepted - you are now recognized."
+                         (downcase (format "You are now identified
for \C-b%s\C-b." rcirc-nick))
+                        (downcase (format "You are successfully
identified as \C-b%s\C-b." rcirc-nick))
+                         (downcase "Password accepted - you are now
recognized.")
                          )))
                (and ;; quakenet
                 (string= sender "Q")

bug#39345: 28.0.50; rcirc-authenticate-before-join due to case sensitive mismatch

[Noam Postavsky]

Jake Nelson <jake.nelson@gmail.com> writes: 
 
> 1. join irc.freenode.net with a lowercase nick "examplenick" 
> 2. authenticate to nickserv 3. nickserv echos back  "-NickServ- 
> You are now identified for "Examplenick" capitalizing the 
> nickname. 
 
Hmm, I use "npostavs" as my nick on freenode, and I get 
 
    09:43 -NickServ- You are now identified for npostavs.

Maybe the difference is that you are registering with the capitalized
version, but then authenticating with lowercase?

For reference, it looks like ERC also uses case-sensitive comparison
(see erc-nickserv-identification-autodetect and erc-nickserv-alist).

bug#39345: 28.0.50; rcirc-authenticate-before-join due to case sensitive mismatch

[Jake Nelson]

You are correct. To test, I dropped my registration with NickServ, and
re-registered with my nickname lowercase, and now see it lowercased in
the "You are now identified for [nickname]" message.

Re-registering resolves this issue for me, but it is not apparent
rcirc-authenticate-before-join is case sensitive when NickServ itself
does not care.




On Wed, Jan 29, 2020 at 10:20 AM Noam Postavsky <npostavs@gmail.com> wrote:
>
> Jake Nelson <jake.nelson@gmail.com> writes:
>
> > 1. join irc.freenode.net with a lowercase nick "examplenick"
> > 2. authenticate to nickserv 3. nickserv echos back  "-NickServ-
> > You are now identified for "Examplenick" capitalizing the
> > nickname.
>
> Hmm, I use "npostavs" as my nick on freenode, and I get
>
>     09:43 -NickServ- You are now identified for npostavs.
>
> Maybe the difference is that you are registering with the capitalized
> version, but then authenticating with lowercase?
>
> For reference, it looks like ERC also uses case-sensitive comparison
> (see erc-nickserv-identification-autodetect and erc-nickserv-alist).

bug#39345: 28.0.50; rcirc-authenticate-before-join due to case sensitive mismatch

[Noam Postavsky]

tags 39345 fixed
close 39345 28.1
quit

Jake Nelson <jake.nelson@gmail.com> writes:

> You are correct. To test, I dropped my registration with NickServ, and
> re-registered with my nickname lowercase, and now see it lowercased in
> the "You are now identified for [nickname]" message.
>
> Re-registering resolves this issue for me, but it is not apparent
> rcirc-authenticate-before-join is case sensitive when NickServ itself
> does not care.

Yes, since NickServ is case-insensitive, it makes sense that rcirc
should be as well.  I pushed a slightly different patch to master to do
this.

[1: 3758ff0f3a]: 2020-03-12 21:06:28 -0400
  rcirc: Match NickServ messages case-insensitively (Bug#39345)
  https://git.savannah.gnu.org/cgit/emacs.git/commit/?id=3758ff0f3ad365b7a56c3e63a8d0d5f00f3d5085