From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.ciao.gmane.io!not-for-mail From: Noam Postavsky Newsgroups: gmane.emacs.bugs Subject: bug#40600: [PATCH] 27.0.90; M-x strokes-list-strokes error Date: Tue, 14 Apr 2020 12:48:55 -0400 Message-ID: <851roqypvs.fsf@gmail.com> References: <8C7B4C5F-294E-4844-AAAF-C37101BE95F4@icloud.com> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="ciao.gmane.io:159.69.161.202"; logging-data="32984"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.3 (windows-nt) Cc: 40600@debbugs.gnu.org To: tsuucat Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Tue Apr 14 19:00:55 2020 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1jOOvd-0008Tb-6J for geb-bug-gnu-emacs@m.gmane-mx.org; Tue, 14 Apr 2020 19:00:53 +0200 Original-Received: from localhost ([::1]:35372 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1jOOvc-0006DJ-75 for geb-bug-gnu-emacs@m.gmane-mx.org; Tue, 14 Apr 2020 13:00:52 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:33781) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1jOOl9-0005sy-2Y for bug-gnu-emacs@gnu.org; Tue, 14 Apr 2020 12:50:04 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1jOOl8-0002Sz-0i for bug-gnu-emacs@gnu.org; Tue, 14 Apr 2020 12:50:02 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:51317) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1jOOl7-0002Sq-Rc for bug-gnu-emacs@gnu.org; Tue, 14 Apr 2020 12:50:01 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1jOOl7-0003jz-PR for bug-gnu-emacs@gnu.org; Tue, 14 Apr 2020 12:50:01 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Noam Postavsky Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Tue, 14 Apr 2020 16:50:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 40600 X-GNU-PR-Package: emacs Original-Received: via spool by 40600-submit@debbugs.gnu.org id=B40600.158688295014311 (code B ref 40600); Tue, 14 Apr 2020 16:50:01 +0000 Original-Received: (at 40600) by debbugs.gnu.org; 14 Apr 2020 16:49:10 +0000 Original-Received: from localhost ([127.0.0.1]:34630 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jOOkF-0003ih-1n for submit@debbugs.gnu.org; Tue, 14 Apr 2020 12:49:10 -0400 Original-Received: from mail-qv1-f49.google.com ([209.85.219.49]:42495) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jOOkA-0003iB-MN for 40600@debbugs.gnu.org; Tue, 14 Apr 2020 12:49:06 -0400 Original-Received: by mail-qv1-f49.google.com with SMTP id v18so146462qvx.9 for <40600@debbugs.gnu.org>; Tue, 14 Apr 2020 09:49:02 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:references:date:in-reply-to:message-id :user-agent:mime-version; bh=izmdC8dTNVvPzIMAZiQlXo2TEFP7nW5JG/KBOYob6S4=; b=kXjlabLDnSd6jq1SUybQfLWyqIYlugH7NXf1ytdGjOpFq3hP48h9n/P0rWlYnsyN96 r85O5ZS63UtRM03hCZR8v/9AbA/97m1O9sioOtQEvD9CWXBps0z+rr7E0BJTxHFHg4pQ Y78KhG/yD5qGcA/OF9mfBb02u6AmcBaHMEUXuOHBpDq9kBvUuMhvE1/Jirj4BVRLdyh/ 3B0sk+7tdkYkautjP1bwASgsjE2IU840jBfypOSUwBSN+zIyzNGVAf4K42IABwo0n3Rc y+fGD5C0vdeb1Bu/yauqE3Z0cRlU+BGzLhqGL1VRsnVPFTArcBGslkJG8tcPzYAbXkU2 YRAg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:references:date:in-reply-to :message-id:user-agent:mime-version; bh=izmdC8dTNVvPzIMAZiQlXo2TEFP7nW5JG/KBOYob6S4=; b=VJOLbrvIGKC93wo5948OvNYzWMExLkiQ1e5ZcSjJ7enp1LNXWYOm0SzJpEpC4/SC7p JOJcYyMG09YICrtlSj35FCB5MxH3PIu/Ri8/xOXugXIxPMMPt2SghAb0hkK+IX4DtyQb 2X8J2ypq85IRQhbCnbcn+Kh/nR/En7wyJ5kNT4/jEAgHU1RLfUXPWbZnQR4bZHQ0d+J0 V35BFLJhs4fUw7Hwk5GgvmOhTA+0tuMR6H+ppT4RayNGyDcxD3HypmYLXvt9fGfYcOgG UhAGJ3uUpMVEs/ta78RsFb48WrI+/m6DomQvyf5vrTwe6liu8qdzn+CMnIw7w1QJxP0S v6BQ== X-Gm-Message-State: AGi0PuYw2GJkWKpLlanuUtw/TGIJ+2jqah4IUdRHpIxEAsROUlBB+Ab0 2U37oFXdo1skx68LVML1L+5jhfKyCfE= X-Google-Smtp-Source: APiQypLoRQ02InOHCikHDuIg0IR+uxtBeDErMopnc0tfhoC2m7Iu5SiX+rivAQCTbKO3oPzk0h4e0A== X-Received: by 2002:a0c:c187:: with SMTP id n7mr903195qvh.240.1586882936880; Tue, 14 Apr 2020 09:48:56 -0700 (PDT) Original-Received: from vhost2 (CPE001143542e1f-CMf81d0f809fa0.cpe.net.cable.rogers.com. [99.230.38.42]) by smtp.gmail.com with ESMTPSA id z3sm11027042qtq.7.2020.04.14.09.48.55 (version=TLS1_2 cipher=ECDHE-ECDSA-CHACHA20-POLY1305 bits=256/256); Tue, 14 Apr 2020 09:48:56 -0700 (PDT) In-Reply-To: (tsuucat@icloud.com's message of "Tue, 14 Apr 2020 23:38:28 +0900") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 209.51.188.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:178366 Archived-At: tsuucat writes: > - (let ((command-name-1 (symbol-name (cdr stroke1))) > - (command-name-2 (symbol-name (cdr stroke2)))) > + (let ((command-name-1 (if (symbolp (cdr stroke1)) > + (symbol-name (cdr stroke1)) > + (prin1-to-string (cdr stroke1)))) Why use prin1-to-string? > + (command-name-2 (if (symbolp (cdr stroke2)) > + (symbol-name (cdr stroke2)) > + (prin1-to-string (cdr stroke2))))) > (string-lessp command-name-1 command-name-2))) Actually, since string-lessp accepts symbols, an easier fix would be to just drop the calls to symbol-name.