From: Noam Postavsky <npostavs@gmail.com>
To: tsuucat <tsuucat@icloud.com>
Cc: 40600@debbugs.gnu.org
Subject: bug#40600: [PATCH] 27.0.90; M-x strokes-list-strokes error
Date: Tue, 14 Apr 2020 12:48:55 -0400 [thread overview]
Message-ID: <851roqypvs.fsf@gmail.com> (raw)
In-Reply-To: <EFFD362F-0C5B-4793-BD40-9FCD2936C44C@icloud.com> (tsuucat@icloud.com's message of "Tue, 14 Apr 2020 23:38:28 +0900")
tsuucat <tsuucat@icloud.com> writes:
> - (let ((command-name-1 (symbol-name (cdr stroke1)))
> - (command-name-2 (symbol-name (cdr stroke2))))
> + (let ((command-name-1 (if (symbolp (cdr stroke1))
> + (symbol-name (cdr stroke1))
> + (prin1-to-string (cdr stroke1))))
Why use prin1-to-string?
> + (command-name-2 (if (symbolp (cdr stroke2))
> + (symbol-name (cdr stroke2))
> + (prin1-to-string (cdr stroke2)))))
> (string-lessp command-name-1 command-name-2)))
Actually, since string-lessp accepts symbols, an easier fix would be to
just drop the calls to symbol-name.
next prev parent reply other threads:[~2020-04-14 16:48 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-04-13 15:51 bug#40600: 27.0.90; M-x strokes-list-strokes error tsuucat via Bug reports for GNU Emacs, the Swiss army knife of text editors
[not found] ` <handler.40600.B.158679308724681.ack@debbugs.gnu.org>
2020-04-14 14:38 ` bug#40600: [PATCH] " tsuucat via Bug reports for GNU Emacs, the Swiss army knife of text editors
2020-04-14 16:48 ` Noam Postavsky [this message]
2020-04-14 17:15 ` tsuucat via Bug reports for GNU Emacs, the Swiss army knife of text editors
2020-04-17 0:49 ` Noam Postavsky
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=851roqypvs.fsf@gmail.com \
--to=npostavs@gmail.com \
--cc=40600@debbugs.gnu.org \
--cc=tsuucat@icloud.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.