From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.ciao.gmane.io!not-for-mail From: Trevor Spiteri Newsgroups: gmane.emacs.bugs Subject: bug#40919: 27.0.91; next-error-select-buffer does not always behave as documented Date: Fri, 1 May 2020 01:18:49 +0200 Message-ID: <851cd382-4b2e-447a-2212-919c8a4ce908@ieee.org> References: <53913bd9-2bdc-0f70-f7b4-744283e0512f@ieee.org> <87d07rmb6j.fsf@mail.linkov.net> <87zhau5bfw.fsf@mail.linkov.net> <66f63b16-307a-919c-1d25-60ff63f92ae6@ieee.org> <87bln8u3xq.fsf@mail.linkov.net> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Injection-Info: ciao.gmane.io; posting-host="ciao.gmane.io:159.69.161.202"; logging-data="67757"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.7.0 Cc: 40919@debbugs.gnu.org To: Juri Linkov Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Fri May 01 01:20:03 2020 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1jUITK-000HYM-C9 for geb-bug-gnu-emacs@m.gmane-mx.org; Fri, 01 May 2020 01:20:02 +0200 Original-Received: from localhost ([::1]:37988 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1jUITJ-0007cZ-1e for geb-bug-gnu-emacs@m.gmane-mx.org; Thu, 30 Apr 2020 19:20:01 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:49224) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1jUISv-0007ba-Ll for bug-gnu-emacs@gnu.org; Thu, 30 Apr 2020 19:19:43 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.90_1) (envelope-from ) id 1jUISP-0004n2-1d for bug-gnu-emacs@gnu.org; Thu, 30 Apr 2020 19:19:37 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:36363) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1jUISM-0004ga-Vg for bug-gnu-emacs@gnu.org; Thu, 30 Apr 2020 19:19:03 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1jUISM-0008FG-Hn for bug-gnu-emacs@gnu.org; Thu, 30 Apr 2020 19:19:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Trevor Spiteri Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Thu, 30 Apr 2020 23:19:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 40919 X-GNU-PR-Package: emacs Original-Received: via spool by 40919-submit@debbugs.gnu.org id=B40919.158828874031686 (code B ref 40919); Thu, 30 Apr 2020 23:19:02 +0000 Original-Received: (at 40919) by debbugs.gnu.org; 30 Apr 2020 23:19:00 +0000 Original-Received: from localhost ([127.0.0.1]:47909 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jUISJ-0008F0-N0 for submit@debbugs.gnu.org; Thu, 30 Apr 2020 19:18:59 -0400 Original-Received: from mail-wm1-f49.google.com ([209.85.128.49]:55312) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jUISH-0008Ej-JL for 40919@debbugs.gnu.org; Thu, 30 Apr 2020 19:18:58 -0400 Original-Received: by mail-wm1-f49.google.com with SMTP id e26so4093539wmk.5 for <40919@debbugs.gnu.org>; Thu, 30 Apr 2020 16:18:57 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ieee.org; s=google; h=to:cc:references:from:autocrypt:subject:message-id:date:user-agent :mime-version:in-reply-to:content-transfer-encoding:content-language; bh=kcMgoRjd5H/smHp8gs4dSYGiPxAyAZHRh3jadAbwh2A=; b=VeP1isBQHk692wapsIqzoSobej7qV3jxqAcsrgSGvvypv5mgaEEOOfoZ5XoCG7HQjA 0v+nL4acyiltsJQpAtvp1pTRYl2BBu8N2V549dHiiRkSiGCqg65SRwBnA74GMu3Zh/AB 8vdk8pu7s70MfAyM4TylWw1SUndA99PeJiYno= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:to:cc:references:from:autocrypt:subject :message-id:date:user-agent:mime-version:in-reply-to :content-transfer-encoding:content-language; bh=kcMgoRjd5H/smHp8gs4dSYGiPxAyAZHRh3jadAbwh2A=; b=MXUhkm14FK3ey1gT8DfuaPOqh/cmZfJ3MwITmQgbAxkJ7mVHLG0+aqkR104Pe2cp0q ZZ1xuWD87pOPByd6zXSB7US8Qoec3MDh2gSATovsu9eel/Jft3Od45L3EpTjeI3rNiTc QV6vY9JfesgrdY0jrRIUU6MDG4zoI5+qaSYsdb/LAkeLa8E2tootYUkqL6cEWx+5AOis IAUehyFdLNcxODedUV/Y9ZiROS/Re9a/CjkAEiX4lU4NirU2a7FOAv+Y4jdPOAikEzOj x0hivwMM4oNuxwLysmpRFI2K6LcDT/v5U0gvo5M11OuKbmHz7WKzU5GGPp4765TuEw7a oHIA== X-Gm-Message-State: AGi0PuaqYzw2IRhz9sS8T5ZNJlXqJfzHt+RO/Tc+9+tWJ0YkBkRzf8ac rmN/tZJHtO/xQQCYkOskWh5F6RQixdY= X-Google-Smtp-Source: APiQypJzQAdaF/7qPDmWNkR15oDnuR0f89MYbImes37sXaNZnqsGQmr9MIviLJekXrsHwLPU9+Q71A== X-Received: by 2002:a05:600c:24cf:: with SMTP id 15mr954913wmu.94.1588288731210; Thu, 30 Apr 2020 16:18:51 -0700 (PDT) Original-Received: from [192.168.1.104] ([85.232.212.161]) by smtp.gmail.com with ESMTPSA id a9sm1459789wmm.38.2020.04.30.16.18.49 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 30 Apr 2020 16:18:50 -0700 (PDT) Autocrypt: addr=tspiteri@ieee.org; prefer-encrypt=mutual; keydata= mQINBFcxvj8BEADgjJ0VPjUDQHNOO8+zw4txojpVRUbw3q4o3EaxHBSn3Nzl8qtp+OOzDe6n M4YQK6/ocBSJc+w3rFQzjmHxcCaJW8XJTaV27ot9r/wS6ucz34xFM6PJp2iIVT5SI5h1htIv ywJ9JlC+BiVN8X3QAvBJeQEGx48HNv+oYR/6mLvh/3cuyABBcmmsMBmG6ACpLJ6COhOXkl4r XB+gmVvt72HWy+zYyF/m1aMxQFakrAVWP3uslReCPR66bKiS9Hm77IyGGE5LOhccda0nFy5I kHqibst646jTQAu1EcpQZrnRXq7JOEOToM3Aj8GRI+T9+rKr1rf2RA7zdm0D9reUV+iPOEaI jFa4XT43BddM8mlV5pSQft2qoB3cTNHo1uJz8cQWTlmwcJiUEPVi5+5EtuDz/ovxSRIepNl4 zEHO5NNIqt2AZNLr+49UwWSmNi5NVfDxjXswCmFfUBFev14nxVz7jaPWUtD+htzkIUAoidlM a7tkeboP6j1UonX/ELwRTnWctpich8GCVaV+AaTViNpiJFw/wR3jN3rjE2AN5dgSgLEroInS M+U3a21c0pGarETx/JlpteZjWxvMMtdDr0MeLqVvSMxErvBB+0JhqkK9uAoAj8hCe6mweDao qIyUwPewbDD9Gcgxzd2ljbPcw1kOP8hFEjn+WWOcYY+rVu6+jQARAQABtCJUcmV2b3IgU3Bp dGVyaSA8dHNwaXRlcmlAaWVlZS5vcmc+iQJXBBMBCABBAhsjBQsJCAcCBhUICQoLAgQWAgMB Ah4BAheAAhkBFiEEG4 In-Reply-To: <87bln8u3xq.fsf@mail.linkov.net> Content-Language: en-US X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-Received-From: 209.51.188.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:179405 Archived-At: >> I think this would work for next-error-select-buffer. Then to fix the >> other issue about new compilations, compilation-start can be modified = to >> use next-error-select-buffer. That way the change in compilation-start= >> is morally unambiguous :) > I'm not sure if this is morally right, because users might want to > continue to navigate an old next-error buffer, even after creating > a new next-error buffer. > > OTOH, by using next-error-select-buffer they explicitly say that > they want to switch to the new navigation. Do you think it's right > to implicitly assume the user's intention? > > We should base the decision not on precedence set by older versions, > but on expectations of most users. > >> diff --git a/lisp/progmodes/compile.el b/lisp/progmodes/compile.el >> index 455f181f50..41e77007c6 100644 >> --- a/lisp/progmodes/compile.el >> +++ b/lisp/progmodes/compile.el >> @@ -1910,7 +1910,7 @@ compilation-start >> (goto-char (point-max)))) >> =20 >> ;; Make it so the next C-x ` will use this buffer. >> - (setq next-error-last-buffer outbuf))) >> + (next-error-select-buffer outbuf))) >> =20 >> (defun compilation-set-window-height (window) >> "Set the height of WINDOW according to `compilation-window-height'.= " > There are more places that set next-error-last-buffer: vc-git-grep, occ= ur-1, > xref.el... > > But I'm still not sure if this is a preferable behavior for most users.= > Maybe this needs a user option? I thought that the change was unintentional. If it's intentional that's another thing. If no one else complains then maybe most users prefer the new behavior. I've already added advice to compilation-start so it's not hard for me that I prefer the old behavior.