From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: =?utf-8?Q?Mattias_Engdeg=C3=A5rd?= Newsgroups: gmane.emacs.devel Subject: Re: last_marked array is now ifdef'ed away Date: Fri, 13 Sep 2024 16:43:49 +0200 Message-ID: <851C7C12-44A1-4661-9EA7-16B0B7209D11@gmail.com> References: <86zfokyp64.fsf@gnu.org> <86ed5pkz53.fsf@gnu.org> Mime-Version: 1.0 (Mac OS X Mail 14.0 \(3654.120.0.1.15\)) Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: quoted-printable Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="8815"; mail-complaints-to="usenet@ciao.gmane.io" Cc: emacs-devel@gnu.org To: Eli Zaretskii Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Fri Sep 13 16:44:33 2024 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1sp7XE-00029W-GF for ged-emacs-devel@m.gmane-mx.org; Fri, 13 Sep 2024 16:44:32 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1sp7Wd-0007j8-Ul; Fri, 13 Sep 2024 10:43:55 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1sp7Wd-0007iz-0d for emacs-devel@gnu.org; Fri, 13 Sep 2024 10:43:55 -0400 Original-Received: from mail-lj1-x22b.google.com ([2a00:1450:4864:20::22b]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1sp7Wb-0004A7-Jn; Fri, 13 Sep 2024 10:43:54 -0400 Original-Received: by mail-lj1-x22b.google.com with SMTP id 38308e7fff4ca-2f75aaaade6so25635771fa.1; Fri, 13 Sep 2024 07:43:52 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1726238631; x=1726843431; darn=gnu.org; h=to:references:message-id:content-transfer-encoding:cc:date :in-reply-to:from:subject:mime-version:sender:from:to:cc:subject :date:message-id:reply-to; bh=OhaOfrjTU74BLxG/VuEYXc6b1VEQO0GLd5SsbVTXyU4=; b=FLhpl32BNiJgGbLcleFazPKHr2o3oRruQDHgXeltgXI7BICUQ6gY7Kw2J2odGQiW58 HufG4h07bAvVbvkqczBqgwetbcxt+2sshiP3btJcWWTtdTnXyhKamm7PIcEYD+JI9Oem Z9M15yVbfa48bmNhjzbf4FMvFVH6sFup9JcP0o6im20rtlDOcpjXyq2DGc6HY1ZG5WAa crhp3nYQlrvDkXQVmNQzCPb0rc2VwFjhN2tGpGaltUXn04kKq9OTOmIbZin05P0mDCPh qJnPo3oIrOw58drAiksqFyEfbYEEv89NgU+HMYU39rkkCpfX5T3+r86JwRjlNyuLzVqr ioew== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1726238631; x=1726843431; h=to:references:message-id:content-transfer-encoding:cc:date :in-reply-to:from:subject:mime-version:sender:x-gm-message-state :from:to:cc:subject:date:message-id:reply-to; bh=OhaOfrjTU74BLxG/VuEYXc6b1VEQO0GLd5SsbVTXyU4=; b=NWJ407Ol7X9j73YM3lHahLAKK0eKtuWQp4aF7GxvLX2tDEyGpGV0yYNd/9KQIq6BYx ywtZQo2EuhZ1v/fM6hbqhnWbFtFb8HU5WST5h7NtbsqykHHpcib2LMwaSGOK8JNdeGQv UL43LIoyCQmVPj7rXVcODkPQiuJ6BvM1MxBb54M+ca2Z6/OPzNbSA4VojTfKb5SXjVqw jj6wvuS8IUbrxtUxThn32BcatvIyHA3ccwsugZZkc81Rxgozm6UIgAEwdmaU/WqP7oIf DkZeRwpBIPidBpD9fKzQlUfJgAOYj0/fxb7x2+DJWezY6uq8Pp1Q1KydvFqhW0O+F+3B wrMg== X-Gm-Message-State: AOJu0Yyah6oQbANlATyXsgBX9CvwnAcvoFM7Im5VLq4p7qHCBBaJIdrL RzpmZz+yyg40lF8GZNk1UrSXJ5vCEsuJmKAkSuGQAKTx3eQUthIgkP3Kew== X-Google-Smtp-Source: AGHT+IHAXiCIwqwY5vKMWZbY/ZGzuisKxEzK8lThy0k4vqWuVGOxzhB2cq1fck/VRPlY1d2+5EYQsw== X-Received: by 2002:a2e:741:0:b0:2f7:4e9b:93d6 with SMTP id 38308e7fff4ca-2f787ee62edmr29917571fa.24.1726238630442; Fri, 13 Sep 2024 07:43:50 -0700 (PDT) Original-Received: from smtpclient.apple (c188-150-191-82.bredband.tele2.se. [188.150.191.82]) by smtp.gmail.com with ESMTPSA id 38308e7fff4ca-2f75c098d83sm22603651fa.118.2024.09.13.07.43.49 (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Fri, 13 Sep 2024 07:43:49 -0700 (PDT) In-Reply-To: <86ed5pkz53.fsf@gnu.org> X-Mailer: Apple Mail (2.3654.120.0.1.15) Received-SPF: pass client-ip=2a00:1450:4864:20::22b; envelope-from=mattias.engdegard@gmail.com; helo=mail-lj1-x22b.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.devel:323596 Archived-At: 12 sep. 2024 kl. 11.19 skrev Eli Zaretskii : >> Commit 7a8798de95a5 (from Apr 4 2022) made the last_marked[] array = and >> the related machinery of tracing the marked objects #ifdef'ed away by >> default: >>=20 >> +/* Whether to remember a few of the last marked values for = debugging. */ >> +#define GC_REMEMBER_LAST_MARKED 0 Yes, debugging code in the inner loop of one of the hottest paths of the = GC probably shouldn't be on by default. I've done a large amount of = intricate GC debugging and never felt a need for it, but it is easy = enough to enable when wanted. We could hitch it to another existing config option like = ENABLE_CHECKING, or even make this an independent config option, but = there's value in not having to reconfigure and recompile everything when = turning it on so keeping it localised in the source seems the better = choice. We could also change the `#if` to `if` to reduce the risk of bitrot. = I'll do that later.