From: Marco Wahl <marcowahlsoft@gmail.com>
To: emacs-orgmode@gnu.org
Cc: "Paul M. Rodriguez" <paulmrodriguez@gmail.com>
Subject: [PATCH] contrib/lisp/org-velocity: Fix failure for big window
Date: Tue, 14 Oct 2014 20:55:22 +0200 [thread overview]
Message-ID: <84vbnm1nxh.fsf@tm6592.fritz.box> (raw)
[-- Attachment #1: Type: text/plain, Size: 546 bytes --]
Hi list, hi Paul,
thanks for your org-velocity contribution! I just discovered
org-velocity and immediately liked it.
I found a bug which might not have occurred in the past since the
monitors were smaller. The bug shows up when the number of lines of the
match window exceeds the number of available indexes (which is 61). I
think the patch (which is just a switch from 'greater than' to 'smaller
than') in the attachment is a way to go.
Please let me know what you think.
Best regards, Marco
--
http://www.wahlzone.de
GPG: 0x0A3AE6F2
[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: contrib/lisp/org-velocity: Fix failure for big window --]
[-- Type: text/x-diff, Size: 1247 bytes --]
From c867eda9b60736b0d3ae50d5a5f889e80cf25a81 Mon Sep 17 00:00:00 2001
From: Marco Wahl <marcowahlsoft@gmail.com>
Date: Tue, 14 Oct 2014 20:07:31 +0200
Subject: [PATCH] contrib/lisp/org-velocity: Fix failure for big window
* contrib/lisp/org-velocity.el (org-velocity-incremental-read): Reversed
the estimation against window-height.
---
contrib/lisp/org-velocity.el | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/contrib/lisp/org-velocity.el b/contrib/lisp/org-velocity.el
index 3631a59..e6788c6 100644
--- a/contrib/lisp/org-velocity.el
+++ b/contrib/lisp/org-velocity.el
@@ -671,7 +671,7 @@ Stop searching once there are more matches than can be displayed."
;; Truncate the index to the size of the buffer to be
;; displayed.
(with-selected-window match-window
- (if (> (window-height) (length org-velocity-index))
+ (if (< (window-height) (length org-velocity-index))
;; (subseq org-velocity-index 0 (window-height))
(let ((hints (copy-sequence org-velocity-index)))
(setcdr (nthcdr (window-height) hints) nil)
--
2.1.2
next reply other threads:[~2014-10-14 18:55 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-10-14 18:55 Marco Wahl [this message]
2014-10-20 13:33 ` [PATCH] contrib/lisp/org-velocity: Fix failure for big window Bastien
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=84vbnm1nxh.fsf@tm6592.fritz.box \
--to=marcowahlsoft@gmail.com \
--cc=emacs-orgmode@gnu.org \
--cc=paulmrodriguez@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.