all messages for Emacs-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
From: Marco Wahl <marcowahlsoft@gmail.com>
To: emacs-orgmode@gnu.org
Subject: Re: point moves and zoom level reverts when refreshing agenda
Date: Sun, 24 Jun 2018 10:15:01 +0200	[thread overview]
Message-ID: <84vaa88ut6.fsf@gmail.com> (raw)
In-Reply-To: 87fu1ieivj.fsf@nicolasgoaziou.fr

Bonjour!

Nicolas Goaziou <mail@nicolasgoaziou.fr> writes:

> Thank you. It looks good. Feel free to apply it.

Thanks, I did.

> I have two suggestions however:
>
> 1. There is some code duplication, e.g., (dolist ...), could this be
>    factored out before applying the patch?

Yes, done, thanks for the hint.  The patch has been committed.

> 2. Would it make sense to add the variables to preserve in a dedicated
>    top-level variable instead of burying them in the code?

I don't know.  Possibly this is a YAGNI.  A top-level variable could be
introduced any time.  Further someone might come up with a freshly
rewritten agenda in the meantime. ;)

BTW: It might be a good idea to take ideas from `list-buffers' and
friends for the rewrite of the agenda.


Ciao,
     Marco

  reply	other threads:[~2018-06-24  8:15 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-05-27 21:19 point moves and zoom level reverts when refreshing agenda Samuel Wales
2018-05-27 21:24 ` Samuel Wales
2018-05-29 16:22 ` Marco Wahl
2018-06-05 14:18   ` Marco Wahl
2018-06-05 19:00     ` Samuel Wales
2018-06-05 20:35       ` Marco Wahl
2018-06-19 18:22         ` Nicolas Goaziou
2018-06-24  8:15           ` Marco Wahl [this message]
2018-06-24 21:10             ` Samuel Wales

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=84vaa88ut6.fsf@gmail.com \
    --to=marcowahlsoft@gmail.com \
    --cc=emacs-orgmode@gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/emacs.git
	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.