From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Brahimi Saifullah Newsgroups: gmane.emacs.devel Subject: Re: Time to merge scratch/correct-warning-pos into master, perhaps? Date: Sat, 22 Jan 2022 20:16:43 -0300 Message-ID: <84sftfweck.fsf@gmail.com> References: <84fspor0dj.fsf@gmail.com> <84o84bmxy2.fsf@gmail.com> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="14114"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/29.0.50 (windows-nt) Cc: emacs-devel@gnu.org To: Alan Mackenzie Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Sun Jan 23 00:17:28 2022 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1nBPdP-0003Td-V9 for ged-emacs-devel@m.gmane-mx.org; Sun, 23 Jan 2022 00:17:27 +0100 Original-Received: from localhost ([::1]:41868 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1nBPdO-0000gc-BW for ged-emacs-devel@m.gmane-mx.org; Sat, 22 Jan 2022 18:17:26 -0500 Original-Received: from eggs.gnu.org ([209.51.188.92]:48368) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1nBPcn-00082H-N4 for emacs-devel@gnu.org; Sat, 22 Jan 2022 18:16:49 -0500 Original-Received: from [2607:f8b0:4864:20::234] (port=39567 helo=mail-oi1-x234.google.com) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1nBPcl-0007dF-W0 for emacs-devel@gnu.org; Sat, 22 Jan 2022 18:16:49 -0500 Original-Received: by mail-oi1-x234.google.com with SMTP id e81so19282878oia.6 for ; Sat, 22 Jan 2022 15:16:47 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=from:to:cc:subject:references:date:in-reply-to:message-id :user-agent:mime-version; bh=iHGM+8/+dPD4RI2RZbDYwST2u7TcO/k36wgEcj2lIH0=; b=evp1QhPFODs8mm4dfozZ1TifFZGXyiRtFUsUFqc14WWmeo31atUlcmWPeTDECCfvXm hpR/NwjdxU+jP/o/JPktOLQDfMDC0O7iSjEZOZr5Ig7bdaQwUmFMvHEoyNwoqzysaXt+ A75f8QtPUbEJTVUPYV1uTovMdlgEdCl2SrXqHKcbG/C/xLQf77pYW8kPM2zVM8zIt6Ua QFQ8hxX5/iXKIoEM9Hej6gQmp0Z1XE7VDL6fbocfRwP36majpOkY7Fgc5L4d8t8re8II Kr5GP+1phVdzr0ix74/ok7TtjhmgsCm6YRlMezdc/M295bQbO+N8dqzn4R/RosanHLYj c5Gg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:references:date:in-reply-to :message-id:user-agent:mime-version; bh=iHGM+8/+dPD4RI2RZbDYwST2u7TcO/k36wgEcj2lIH0=; b=YrT327t9AEnRdG7hQQ+WxrbYfBqdI0YPFDSHfiJdqERkEgzliLJOL4H5++h5icRGC5 Ut7rgGAzMww00cV7axmPgrasQBw+KAZYqMkItlRvEi1oNt2NT5lhjUsfDKpxBJjR0mUQ lf08bWaPJ3d5DCwUIsiJH7pwu3Bq9tN0sHBak4B1BGQn37dxPvIgElMOgI9LM3y7YeNm lo54Z6lalGnWPoXQ2yLcEQYsuHifyQA8GbkEw+SmoByeH1MMnfVUCtQWiVzJySMG2Tty YJOtJlf/465R49hpNM+wfSJwh8ZLyi+B78ZZkCPCqZKWmFIwDff0QAR3GS7h7i1ElsaU +gyg== X-Gm-Message-State: AOAM530/oJ1k31sjtOm6dMJYx25YZv5Iip9QVPJNjXZlazOZHJ+wpFXl 3Ge+1RPWYCfJkPgh24WjJSKE9JGHOhP4BA== X-Google-Smtp-Source: ABdhPJz3r7n6lKn1bRDUeGuCb7vWJDvp2IXtDZDXBv4jNVHfA/bplgbGUR/oKpwghIzEgNX9n7Bbow== X-Received: by 2002:a05:6808:1147:: with SMTP id u7mr5185375oiu.117.1642893406670; Sat, 22 Jan 2022 15:16:46 -0800 (PST) Original-Received: from COMPUTADOR ([2804:14d:90bc:8171:1094:922a:903c:dc53]) by smtp.googlemail.com with ESMTPSA id c16sm6754otu.75.2022.01.22.15.16.45 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 22 Jan 2022 15:16:46 -0800 (PST) In-Reply-To: (Alan Mackenzie's message of "Sat, 22 Jan 2022 11:41:49 +0000") X-Host-Lookup-Failed: Reverse DNS lookup failed for 2607:f8b0:4864:20::234 (failed) Received-SPF: pass client-ip=2607:f8b0:4864:20::234; envelope-from=brahimi.saifullah@gmail.com; helo=mail-oi1-x234.google.com X-Spam_score_int: -12 X-Spam_score: -1.3 X-Spam_bar: - X-Spam_report: (-1.3 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, PDS_HP_HELO_NORDNS=0.001, RCVD_IN_DNSWL_NONE=-0.0001, RDNS_NONE=0.793, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=no autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.io gmane.emacs.devel:285238 Archived-At: I'm very sorry for the noise, it seems I replied to the wrong Alan :( https://lists.gnu.org/archive/html/emacs-devel/2022-01/msg01454.html Brahimi Saifullah writes: > Alan Mackenzie writes: > >> With the current state of the git branch, flymake on a .el file now >> seems to be working for me. > > Yes, Flymake is working perfectly now. > > I did notice an issue with the warning for unused forms: > > value returned from (# 1 1) is unused > (from byte-compiling a file that consists of "(+ 1 1)") > > I expect that the symbol should be used, not the symbol with > positions. But it looks like this just got fixed a few hours ago > in master while my build was from before the merge. > > > While further testing this I also found a couple problems relating to > unused function arguments -- I'm unsure if they have anything to do with > the latest round of changes or not. > > First, a bug: > > (defun f (a b c) > ; ^^^ Warning: Unused lexical argument `a' > ; Warning: Unused lexical argument `b' > > "A B C." > (+ 1 1)) > ; ^^^ Warning: Unused lexical argument `c' > > You should be able to reproduce it by copying the above function > somewhere and byte compiling (sans the). > > If the function consists of a single form, the position returned for > the last "unused lexical argument" will wrongly point to it. In this > example, the warning about C being unused will instead point to `+'. > > The second issue is that, even when the unused lexical argument warnings > work correctly, they always point to the "defun," and not to the actual > argument in question. Not the end of the world of course, but it would > be nice for them to be more accurate. > > >> Again, many thanks for the help. > > And thanks for the work you've done, faulty warning > positions had always been an annoyance of mine :)