From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: =?iso-8859-1?Q?Vincent_Bela=EFche?= Newsgroups: gmane.emacs.devel Subject: Re: [Emacs-diffs] emacs-25 8a38e94: Fix local printer set to left aligned string formatter. Date: Tue, 02 Aug 2016 10:15:35 +0200 Message-ID: <84poprlh7c.fsf@gmail.com> Reply-To: 877fc0cdha.fsf@petton.fr NNTP-Posting-Host: blaine Mime-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Transfer-Encoding: quoted-printable X-Trace: blaine.gmane.org 1470126823 16641 195.159.176.226 (2 Aug 2016 08:33:43 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Tue, 2 Aug 2016 08:33:43 +0000 (UTC) Cc: =?iso-8859-1?Q?Vincent_Bela=EFche?= , John Wiegley To: EMACS devel list , Nicolas Petton Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Tue Aug 02 10:33:38 2016 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1bUV8s-0003ON-HZ for ged-emacs-devel@m.gmane.org; Tue, 02 Aug 2016 10:33:38 +0200 Original-Received: from localhost ([::1]:54638 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bUV2Q-0005CE-0N for ged-emacs-devel@m.gmane.org; Tue, 02 Aug 2016 04:26:58 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:59504) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bUUz0-0002WR-DB for emacs-devel@gnu.org; Tue, 02 Aug 2016 04:23:28 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1bUUyv-0000in-7Z for emacs-devel@gnu.org; Tue, 02 Aug 2016 04:23:26 -0400 Original-Received: from smtp04.smtpout.orange.fr ([80.12.242.126]:49320 helo=smtp.smtpout.orange.fr) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bUUyu-0000hf-U6 for emacs-devel@gnu.org; Tue, 02 Aug 2016 04:23:21 -0400 Original-Received: from AigleRoyal ([86.214.71.21]) by mwinf5d60 with ME id S8Fb1t00A0TYur2038Fcao; Tue, 02 Aug 2016 10:15:39 +0200 X-ME-Helo: AigleRoyal X-ME-Auth: dmluY2VudGJlbGFpY2hlQG9yYW5nZS5mcg== X-ME-Date: Tue, 02 Aug 2016 10:15:39 +0200 X-ME-IP: 86.214.71.21 X-Antivirus: avast! (VPS 160801-2, 01/08/2016), Outbound message X-Antivirus-Status: Clean X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6.x X-Received-From: 80.12.242.126 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.org gmane.emacs.devel:206342 Archived-At: Kenavo Nico, Le 02/08/2016 =E0 00:48, Nicolas Petton a =E9crit : > Vincent Bela=EFche writes: > >> Well, I must admit that I am a naughty boy that has not filed any bug >> before making this fix. I of course did some basic tests before >> comitting and it was OK. > > Hi Vincent, > > The purpose of a release candidate is to provide a tarball as close as > possible to the final release for testing, so once the first RC is > out, only critical bug fixes should be pushed to the release branch. > > If a particular bug is blocking the release, then it's of course ok to > commit a fix for it on emacs-25, but since it's not the case here, Of course it is not a blocking bug. Without the correction you are just prevented to configure a local printer using at the same time left alignment and a string format specifier. Having said that, all the other functions are OK AFAIK. > I think that commits 8a38e94 and 3c97b0f should have been pushed to > master instead. > >> IMHO taking this bug fix is not risky and that would make the local >> printer feature more complete. > > I understand that, but who knows, even if your commit looks safe It is only two lines of code, creating a new branch within a cond rather than modifying any existing branch + I have made some tests. So yes, it seems quite safe to take it. > it might still introduce issues that you haven't seen yet :-) That is correct, who knows... I has happened so many times to me in the past that some correction makes some other problem appear. Sometimes some bug is hidding some other bug by disabling some function, and the program is more stable without the prior bug corrected. So, I cannot tell the opposite: any change is a risk. I am not making a fuss if people take the decision here not to take the correction in emacs-25 even though would it depend only on me then I would take it. This is *not* a critical correction and not being a frequent contributor I just made the correction on emacs-25 without knowing it was under release freeze because still this is a bug, not a new function, and it has to be corrected anyhow. BTW, is there any list with *LOW TRAFIC* on which release status (freeze, etc...) is announced. Is the list info-gnu-emacs for that ? I must say that I very seldom go on emacs-devel by lack of time. > > Cheers, > Nico =C0+, Vincent. --- L'absence de virus dans ce courrier =E9lectronique a =E9t=E9 v=E9rifi=E9e p= ar le logiciel antivirus Avast. https://www.avast.com/antivirus