bug#18249: 24.3; expected a button click, text pasted into button label instead

bug#18249: 24.3; expected a button click, text pasted into button label instead

[Andrea Rossetti]

Hello,

  I found some odd behaviour while clicking with <mouse-2>
over a button. I can't say if it's exactly a bug, but I believe
it's unexpected and unwanted behaviour for the user. Here's
a recipe to replicate it.

1) start emacs -Q
2) clear buffer with C-x h C-w
3) type or paste the following five lines of text (line 3 is
   empty on purpose):

;---------- line1: start
(insert-button "[ciao]" 'action (lambda (x) (message "ciao!"))) ; line 2

; line 4: pastethis
; --------- line 5: end

4) put the text cursor at line 3, type C-x C-e so that 
   the "[ciao]" button will be created in line 3
5) select the word "pastethis" with the mouse, by dragging with
   mouse-1 button from first to last letter of the word
6a) put the mouse cursor over the [ciao] button and click there with
    mouse-2 (center button). Result: you should see that the message
    "ciao!" appears at the bottom line; this is correct and expected
    behaviour
6b) move the mouse cursor over the letter "i" of the text "line 4:",
    click mouse-2 and hold it pressed; continue dragging and move the
    mouse cursor over the [ciao] button, then release mouse-2.
    Result: you should see that the word "pastethis" has been pasted
    into the button label, so that it looks similar to
    [ciapastethiso]; this is unexpected behaviour.

  May I please ask if the result 6b) is reproducible for you too.

  I believe 6b) is odd/buggy because typically the user wants
to do action 6a) but accidentally drags the mouse by a few pixel,
thus actually performing action 6b). Please let me know if this
opinion seems wrong/flawed to you.

  If the above makes sense for you too, then a possible correction
could be: if a <drag-mouse-2> event ends on a pushable button,
then Emacs should always perform the button action, not a text
paste like it does now.

  Thanks for your attention and patience in reading this,
kindest regards.

  Andrea



In GNU Emacs 24.3.1 (i386-mingw-nt6.1.7600)
 of 2013-03-17 on MARVIN
Windowing system distributor `Microsoft Corp.', version 6.1.7600
Configured using:
 `configure --with-gcc (4.7) --cflags
 -ID:/devel/emacs/libs/libXpm-3.5.8/include
 -ID:/devel/emacs/libs/libXpm-3.5.8/src
 -ID:/devel/emacs/libs/libpng-dev_1.4.3-1/include
 -ID:/devel/emacs/libs/zlib-dev_1.2.5-2/include
 -ID:/devel/emacs/libs/giflib-4.1.4-1/include
 -ID:/devel/emacs/libs/jpeg-6b-4/include
 -ID:/devel/emacs/libs/tiff-3.8.2-1/include
 -ID:/devel/emacs/libs/gnutls-3.0.9/include
 -ID:/devel/emacs/libs/libiconv-1.13.1-1-dev/include
 -ID:/devel/emacs/libs/libxml2-2.7.8/include/libxml2'

Important settings:
  value of $LANG: ITA
  locale-coding-system: cp1252
  default enable-multibyte-characters: t

Major mode: Article

Minor modes in effect:
  shell-dirtrack-mode: t
  show-paren-mode: t
  server-mode: t
  recentf-mode: t
  cua-mode: t
  tooltip-mode: t
  mouse-wheel-mode: t
  tool-bar-mode: t
  menu-bar-mode: t
  file-name-shadow-mode: t
  global-font-lock-mode: t
  font-lock-mode: t
  blink-cursor-mode: t
  auto-composition-mode: t
  auto-encryption-mode: t
  auto-compression-mode: t
  buffer-read-only: t
  column-number-mode: t
  line-number-mode: t
  transient-mark-mode: t

bug#18249: 24.3; expected a button click, text pasted into button label instead

[Lars Ingebrigtsen]

Andrea Rossetti <andrea.rossetti@gmail.com> writes:

> (insert-button "[ciao]" 'action (lambda (x) (message "ciao!"))) ; line 2

[...]

> 6b) move the mouse cursor over the letter "i" of the text "line 4:",
>     click mouse-2 and hold it pressed; continue dragging and move the
>     mouse cursor over the [ciao] button, then release mouse-2.
>     Result: you should see that the word "pastethis" has been pasted
>     into the button label, so that it looks similar to
>     [ciapastethiso]; this is unexpected behaviour.
>
>   May I please ask if the result 6b) is reproducible for you too.

(I'm going through old bug reports that unfortunately have not received
any responses yet.)

I tried this in Emacs 27, and I was unable to reproduce the bug.
Holding down mouse-2 and moving the mouse around just moves text around,
and releasing it doesn't do anything special on the button inserted.

Are you still seeing this bug?

-- 
(domestic pets only, the antidote for overdose, milk.)
   bloggy blog: http://lars.ingebrigtsen.no

bug#18249: 24.3; expected a button click, text pasted into button label instead

[Andrea Rossetti]

Hello Lars,

Lars Ingebrigtsen <larsi@gnus.org> writes:
> I tried this in Emacs 27, and I was unable to reproduce the bug.
> Holding down mouse-2 and moving the mouse around just moves text around,
> and releasing it doesn't do anything special on the button inserted.
>
> Are you still seeing this bug?

  and thanks for your feedback. I confirm I can still reproduce the
issue on these binaries:

https://alpha.gnu.org/gnu/emacs/pretest/windows/emacs-27/emacs-27.0.50-snapshot-2019-06-08-x86_64.zip

M-x version RET
  
GNU Emacs 27.0.50 (build 1, x86_64-w64-mingw32) of 2019-06-09

  Tentative explanation: if you tested on a Linux workstation, then it
could be a Windows-only problem. Or maybe my step 6b is ambiguous or
hard to follow. Let me retry:

  Maybe describing 6b more naively may help, let me try:

  6b) press mouse-2 outside [ciao], drag mouse inside [ciao], release mouse-2. 
      Instead of clicking the button, it pastes text inside the button.

Cheers!

bug#18249: 24.3; expected a button click, text pasted into button label instead

[Lars Ingebrigtsen]

Andrea Rossetti <andrea.rossetti@gmail.com> writes:

> GNU Emacs 27.0.50 (build 1, x86_64-w64-mingw32) of 2019-06-09
>
>   Tentative explanation: if you tested on a Linux workstation, then it
> could be a Windows-only problem.

Ah, I guess that sounds likely.

> Or maybe my step 6b is ambiguous or
> hard to follow. Let me retry:
>
>   Maybe describing 6b more naively may help, let me try:
>
>   6b) press mouse-2 outside [ciao], drag mouse inside [ciao], release mouse-2. 
>       Instead of clicking the button, it pastes text inside the button.

Yup; I'm not able to reproduce this in GNU/Linux, so somebody with
Windows should try to chase down why this happens there.

-- 
(domestic pets only, the antidote for overdose, milk.)
   bloggy blog: http://lars.ingebrigtsen.no

bug#18249: 24.3; expected a button click, text pasted into button label instead

[Mauro Aranda]

[-- Attachment #1: Type: text/plain, Size: 855 bytes --]

Lars Ingebrigtsen <larsi@gnus.org> writes:

> Andrea Rossetti <andrea.rossetti@gmail.com> writes:
>
>> GNU Emacs 27.0.50 (build 1, x86_64-w64-mingw32) of 2019-06-09
>>
>>   Tentative explanation: if you tested on a Linux workstation, then it
>> could be a Windows-only problem.
>
> Ah, I guess that sounds likely.

[...]

>> Or maybe my step 6b is ambiguous or
>> hard to follow. Let me retry:
>>
>>   Maybe describing 6b more naively may help, let me try:
>>
>>   6b) press mouse-2 outside [ciao], drag mouse inside [ciao], release
mouse-2.
>>       Instead of clicking the button, it pastes text inside the button.
>
> Yup; I'm not able to reproduce this in GNU/Linux, so somebody with
> Windows should try to chase down why this happens there.

I am able to reproduce this at will in GNU/Linux, though.

Details:
x86_64-pc-linux-gnu
Ubuntu 18.04.5 LTS

[-- Attachment #2: Type: text/html, Size: 1172 bytes --]

bug#18249: 24.3; expected a button click, text pasted into button label instead

[Stefan Kangas]

severity 18249 minor
found 18249 28.0.50
thanks

Mauro Aranda <maurooaranda@gmail.com> writes:

> Lars Ingebrigtsen <larsi@gnus.org> writes:
>
>> Andrea Rossetti <andrea.rossetti@gmail.com> writes:
>>
>>> GNU Emacs 27.0.50 (build 1, x86_64-w64-mingw32) of 2019-06-09
>>>
>>>   Tentative explanation: if you tested on a Linux workstation, then it
>>> could be a Windows-only problem.
>>
>> Ah, I guess that sounds likely.
>
> [...]
>
>>> Or maybe my step 6b is ambiguous or
>>> hard to follow. Let me retry:
>>>
>>>   Maybe describing 6b more naively may help, let me try:
>>>
>>>   6b) press mouse-2 outside [ciao], drag mouse inside [ciao], release mouse-2.
>>>       Instead of clicking the button, it pastes text inside the button.
>>
>> Yup; I'm not able to reproduce this in GNU/Linux, so somebody with
>> Windows should try to chase down why this happens there.
>
> I am able to reproduce this at will in GNU/Linux, though.

I can reproduce this with current master on Debian stable/bookworm.