From mboxrd@z Thu Jan 1 00:00:00 1970 Path: main.gmane.org!not-for-mail From: kai.grossjohann@uni-duisburg.de (Kai =?iso-8859-1?q?Gro=DFjohann?=) Newsgroups: gmane.emacs.devel Subject: Re: directory-files and Tramp Date: Sat, 22 Feb 2003 13:23:09 +0100 Organization: University of Duisburg, Germany Sender: emacs-devel-bounces+emacs-devel=quimby.gnus.org@gnu.org Message-ID: <84heawbj2q.fsf@lucy.is.informatik.uni-duisburg.de> References: <3E56B36A.4050806@math.ku.dk> NNTP-Posting-Host: main.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-Trace: main.gmane.org 1045916766 27550 80.91.224.249 (22 Feb 2003 12:26:06 GMT) X-Complaints-To: usenet@main.gmane.org NNTP-Posting-Date: Sat, 22 Feb 2003 12:26:06 +0000 (UTC) Return-path: Original-Received: from quimby.gnus.org ([80.91.224.244]) by main.gmane.org with esmtp (Exim 3.35 #1 (Debian)) id 18mYjC-0007AA-00 for ; Sat, 22 Feb 2003 13:26:02 +0100 Original-Received: from monty-python.gnu.org ([199.232.76.173]) by quimby.gnus.org with esmtp (Exim 3.12 #1 (Debian)) id 18mYxf-0001U4-00 for ; Sat, 22 Feb 2003 13:41:00 +0100 Original-Received: from localhost ([127.0.0.1] helo=monty-python.gnu.org) by monty-python.gnu.org with esmtp (Exim 4.10.13) id 18mYiA-0003lo-04 for emacs-devel@quimby.gnus.org; Sat, 22 Feb 2003 07:24:58 -0500 Original-Received: from list by monty-python.gnu.org with tmda-scanned (Exim 4.10.13) id 18mYhs-0003li-00 for emacs-devel@gnu.org; Sat, 22 Feb 2003 07:24:40 -0500 Original-Received: from mail by monty-python.gnu.org with spam-scanned (Exim 4.10.13) id 18mYhM-0002yT-00 for emacs-devel@gnu.org; Sat, 22 Feb 2003 07:24:39 -0500 Original-Received: from main.gmane.org ([80.91.224.249]) by monty-python.gnu.org with esmtp (Exim 4.10.13) id 18mYhM-0002wP-00 for emacs-devel@gnu.org; Sat, 22 Feb 2003 07:24:08 -0500 Original-Received: from list by main.gmane.org with local (Exim 3.35 #1 (Debian)) id 18mYhD-00073Z-00 for ; Sat, 22 Feb 2003 13:23:59 +0100 X-Injected-Via-Gmane: http://gmane.org/ Original-To: emacs-devel@gnu.org Original-Received: from news by main.gmane.org with local (Exim 3.35 #1 (Debian)) id 18mYhC-00073P-00 for ; Sat, 22 Feb 2003 13:23:58 +0100 Original-Lines: 28 Original-X-Complaints-To: usenet@main.gmane.org User-Agent: Gnus/5.090016 (Oort Gnus v0.16) Emacs/21.3.50 Cancel-Lock: sha1:3B9nT5xB2vFYkOGLUpoARc4PHIU= X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1b5 Precedence: list List-Id: Emacs development discussions. List-Help: List-Post: List-Subscribe: , List-Archive: List-Unsubscribe: , Errors-To: emacs-devel-bounces+emacs-devel=quimby.gnus.org@gnu.org Xref: main.gmane.org gmane.emacs.devel:11845 X-Report-Spam: http://spam.gmane.org/gmane.emacs.devel:11845 Lars Hansen writes: > Tramp is not handling the call (directory-files directory) when > directory is relative and default-directory a Tramp file. > I beleive the problem can be fixed with the following patch: > > diff -c dired-original.c dired.c > *** dired-original.c Tue Feb 4 15:03:12 2003 > --- dired.c Fri Feb 21 21:07:26 2003 > *************** > *** 346,351 **** > --- 346,353 ---- > { > Lisp_Object handler; > + directory = Fexpand_file_name (directory, Qnil); > + > /* If the file name has special constructs in it, > call the corresponding file handler. */ > handler = Ffind_file_name_handler (directory, Qdirectory_files); I think it looks good: in the no-handler case, directory_files calls directory_files_internal, which in turn calls expand-file-name on the directory. So expand-file-name is called anyway. But should the expand-file-name call in directory_files_internal be removed after making sure that all callers do the expansion? -- A preposition is not a good thing to end a sentence with.