all messages for Emacs-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
From: gerard.vermeulen@posteo.net
To: Ihor Radchenko <yantar92@posteo.net>
Cc: Emacs orgmode <emacs-orgmode@gnu.org>,
	dto@gnu.org,
	emacs-orgmode-bounces+gerard.vermeulen=posteo.net@gnu.org
Subject: Re: [PATCH] In case of Sly, let org-babel-execute:lisp use Slynk instead of Swank
Date: Thu, 30 Mar 2023 04:56:13 +0000	[thread overview]
Message-ID: <84fa5f2a1c95c06ad3eac4000f21bab5@posteo.net> (raw)
In-Reply-To: <87jzyzx59i.fsf@localhost>



On 29.03.2023 11:42, Ihor Radchenko wrote:
> gerard.vermeulen@posteo.net writes:
> 
>> The Emacs integrated development environments Slime and Sly
>> communicate by means of similar RPC protocols with different server
>> programs: Swank in case of Slime and Slynk in case of Sly.  However,
>> the code in org-babel-execute:lisp always expects to talk with Swank
>> because of the hard-coded call to swank:eval-and-grab-output.
>> 
>> After starting a Sly REPL, calls to swank:eval-and-grab-output do not
>> talk with the Slynk server started by the Sly REPL.
>> 
>> The attached patch "soft-codes" eval-and-grab-output to become
>> swank:eval-and-grab-output when using Slime and
>> slynk:eval-and-grab-output when using Sly.
> 
> I do not use ob-lisp, but this patch looks reasonable.
> 
> I'd appreciate if other ob-lisp users could test the patch with both 
> SLY
> and SLIME.
> 
> I have no comments on the Elisp part of the patch.

I have a few additional remarks:

The patch is against main only because it overlaps a region where bugfix
and main diverged.  I am willing to provide a similar patch against 
main.

I have installed Slime and Sly with the same user-emacs-directory using
package-install.  Normally, both autoload when doing M-x sly, but Sly
prompts you whether you want to disable Slime.  I choose "yes" to test
Sly.  I package-delete Sly when I want to test Slime.

See https://github.com/joaotavora/sly/blob/master/CONTRIBUTING.md
describes in detail how Sly uses the RPC protocol.

I hope that my mail reaches David (CC-ed dto@gnu.org  taken from the
file header), but my previous message bounced (non-existent address).

Best regards -- Gerard



  reply	other threads:[~2023-03-30  4:57 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-03-29  8:11 [PATCH] In case of Sly, let org-babel-execute:lisp use Slynk instead of Swank gerard.vermeulen
2023-03-29  9:42 ` Ihor Radchenko
2023-03-30  4:56   ` gerard.vermeulen [this message]
2023-03-30 10:10     ` Ihor Radchenko
2023-05-02 12:15       ` Ihor Radchenko

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=84fa5f2a1c95c06ad3eac4000f21bab5@posteo.net \
    --to=gerard.vermeulen@posteo.net \
    --cc=dto@gnu.org \
    --cc=emacs-orgmode-bounces+gerard.vermeulen=posteo.net@gnu.org \
    --cc=emacs-orgmode@gnu.org \
    --cc=yantar92@posteo.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/emacs.git
	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.