[PATCH] org: Liberate org-property-action

[PATCH] org: Liberate org-property-action

[Marco Wahl]

[-- Attachment #1: Type: text/plain, Size: 356 bytes --]

Hi!

This is a simple suggestion to improve function `org-property-action'.
Currently `org-property-action' errors when 'not at a property'.  But
this is unnecessary AFAICS.

Without the restriction one can use the function to control any property
inclusive setting the very first property.

Do I miss something (again)?


Best regards
            Marco



[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: 0001-org-Liberate-org-property-action.patch --]
[-- Type: text/x-diff, Size: 826 bytes --]

From 83805606e630caf1ac47d0662b1e58df01441e3c Mon Sep 17 00:00:00 2001
From: Marco Wahl <marcowahlsoft@gmail.com>
Date: Thu, 23 Mar 2017 00:28:53 +0100
Subject: [PATCH] org: Liberate org-property-action

* lisp/org.el (org-property-action): Remove unnecessary restriction
  for property action.
---
 lisp/org.el | 1 -
 1 file changed, 1 deletion(-)

diff --git a/lisp/org.el b/lisp/org.el
index 126318aa3..d122184c7 100644
--- a/lisp/org.el
+++ b/lisp/org.el
@@ -15535,7 +15535,6 @@ See `org-property-re' for match data, if applicable."
 (defun org-property-action ()
   "Do an action on properties."
   (interactive)
-  (unless (org-at-property-p) (user-error "Not at a property"))
   (message "Property Action:  [s]et  [d]elete  [D]elete globally  [c]ompute")
   (let ((c (read-char-exclusive)))
     (cl-case c
-- 
2.12.0

Re: [PATCH] org: Liberate org-property-action

[Nicolas Goaziou]

Hello,

Marco Wahl <marcowahlsoft@gmail.com> writes:

> This is a simple suggestion to improve function `org-property-action'.
> Currently `org-property-action' errors when 'not at a property'.  But
> this is unnecessary AFAICS.
>
> Without the restriction one can use the function to control any property
> inclusive setting the very first property.
>
> Do I miss something (again)?

LGTM.

Regards,

-- 
Nicolas Goaziou

Re: [PATCH] org: Liberate org-property-action

[Marco Wahl]

Nicolas Goaziou <mail@nicolasgoaziou.fr> writes:

>> This is a simple suggestion to improve function `org-property-action'.
>> Currently `org-property-action' errors when 'not at a property'.  But
>> this is unnecessary AFAICS.
>>
>> Without the restriction one can use the function to control any property
>> inclusive setting the very first property.
>>
>> Do I miss something (again)?
>
> LGTM.

Thanks for the review.

Let's do this.
-> DONE


Ciao