From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: martin rudalics Newsgroups: gmane.emacs.devel Subject: Re: [PATCH] Fix display-buffer-use-some-window to honor reusable-frames Date: Wed, 1 Feb 2023 11:45:06 +0100 Message-ID: <84c98406-5aea-de0e-67bb-10fffd5dd5ad@gmx.at> References: <834jsccepb.fsf@gnu.org> <83sffuap62.fsf@gnu.org> <83a622abpz.fsf@gnu.org> <8af34023-d3d7-a18d-54c5-f418515dea1c@gmx.at> <835ycp6v48.fsf@gnu.org> <7732128c-540b-9e38-0bf3-26c2496d2c0f@gmx.at> <83cz6v53e1.fsf@gnu.org> <9c7209b0-2af2-ab16-7b04-397d7d069025@gmx.at> <83357r5269.fsf@gnu.org> <83a61y3irr.fsf@gnu.org> Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="27633"; mail-complaints-to="usenet@ciao.gmane.io" Cc: tgbugs@gmail.com, emacs-devel@gnu.org, larsi@gnus.org To: Eli Zaretskii Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Wed Feb 01 11:50:34 2023 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1pNAhE-0006wk-RT for ged-emacs-devel@m.gmane-mx.org; Wed, 01 Feb 2023 11:50:32 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1pNAcN-0000cx-T1; Wed, 01 Feb 2023 05:45:31 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pNAc4-0000Y4-Fk for emacs-devel@gnu.org; Wed, 01 Feb 2023 05:45:16 -0500 Original-Received: from mout.gmx.net ([212.227.15.18]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pNAc2-00068F-Cx; Wed, 01 Feb 2023 05:45:11 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=gmx.at; s=s31663417; t=1675248307; bh=fHVy1vC0zZKn5QfNR/Pap7gLywGQT75p0Cj8/AdlAHI=; h=X-UI-Sender-Class:Date:Subject:To:Cc:References:From:In-Reply-To; b=jqb32w6GWNoml848cFzOL7e9gCBBAT1F+4yUInCOxbdRYK3wjcBoQEGLsuLhbMGlj uDsy8ERKFeFSlH0qKbajB6S4tsSBla1s+EKklzlAEMBSGpY+Ol1WPQobIMe6dIcHQa dlsSOjBc1syYtNBJiO+SbyhZ0uPETD4TzA2kiKXbjqLFCeRUG9rjQC0niPGxAaNm5U vUD6HlLammH5jci2Is++7M4cSbZwvhavDV46tbLFjCPa9Hgg9UdhhBjcHULFSupozk gUXrqWWxBnnPXderTm4/Bd3W1cEMNF61sXQNSzV+upT3MtXiJSYFImZSffV9oMn5D7 GG5lC1Ldkl/zA== X-UI-Sender-Class: 724b4f7f-cbec-4199-ad4e-598c01a50d3a Original-Received: from [192.168.1.100] ([213.142.97.245]) by mail.gmx.net (mrgmx004 [212.227.17.190]) with ESMTPSA (Nemesis) id 1Mqs4Z-1ospvO2W13-00mwCR; Wed, 01 Feb 2023 11:45:07 +0100 Content-Language: en-US In-Reply-To: <83a61y3irr.fsf@gnu.org> X-Provags-ID: V03:K1:mywngTj4NPTeNnAocM5/w1bOmXHM+tDOj6h1VdR9wqXfxhu69eF eqBqslHq5eToXoDiAr61034FrVkEt0tC8AwRAZgJpuVsmcJ07zHKxebyPBcWkEuM2492AfS IZKq7MGpQ01RL22T+JUQbQc5e4D8DWh4+6jdG3FauykczmEMd5ADXo0bylQZuFf8NFkNhJD zszRkt3+nCaKXxrPkN8ZQ== UI-OutboundReport: notjunk:1;M01:P0:r2rijWXeb3k=;xBFG5AZ/EeYNS+y6HOC7V/TBmBQ 7nSI8aI/fu6Hk8OJ69IjuKcFwjOYODM5xDm6LDXfS2wVvxvzcHjWEU1NQzBqH+NT7ZxguUtmf 9VbnDrq8qfbPnoZz2pQ+UGvTfl5sscbirJdneZ4vklbdnofV7cyDZR6MkC7rYgzjKqO1W9TRp XEknlLQ3Oxm5ZSEWTcuX3DtneZZVfHMgUeNBkub+7KrT5tmSCxmKDOiOPLu3oRvWrBoBQuwb0 oYRwM04vjz9IgefX5tMQzQviiVSe/baWEDqYSUFEZwwQKsQOobBRX6bYZIGWPJ7xgpwUuyzMJ hWnV/jMzvaESeSiiWgIuiAW8ZGmgKbdJ0RMGj6C1irjZXpi2E/pZE+qrCgMkDZ/J7EQbkQ8Ph 1/30/H2yk65ZHkc9/OALEQM4yHoRF6T8hXX8nscEKng2UpfUgfmjD9P7CE9dW7R3sBVyHleVI 18KNWQt5CNCYo/1yBi0wYFUfwOrMiB9/6Yh94wx/aNawh71eypMmRZz0mVwIY/T6TvV5DmHWu s6rvq9UvUqsCrK8ubKF+OhqSuB+hdtM6uRGLNTowx86Guibiqthgw4TnAdHW+1iQCt5vMjyL5 B9PEYR9H9+z8U5zUi/DsskXi5yO4FCNoNPBJHYuyKiykca8UxF0FtLOECd6lfNNn20ehGzwsA LZklV6flrH3c8kbUorw6FrWJ/ieihflmhz/yDUfFX4LeKEnA3IeVEKOZMjfV2XF3KXfC5krQ2 uAWQ7YzzpOATZd4HMq8qvQJlifgtkLZ6NeoaMBpa9kKtPCQxANEX2SzTOSIVYzFKsJ3xuEb4 Received-SPF: pass client-ip=212.227.15.18; envelope-from=rudalics@gmx.at; helo=mout.gmx.net X-Spam_score_int: 5 X-Spam_score: 0.5 X-Spam_bar: / X-Spam_report: (0.5 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_LOW=-0.7, RCVD_IN_MSPIKE_H2=-0.001, RCVD_IN_SBL_CSS=3.335, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=no autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.devel:302852 Archived-At: > In general, I had in mind all the issues you listed in > > https://lists.gnu.org/archive/html/emacs-devel/2023-01/msg00542.html > > including the one with window-bump-use-time. There's worse as I just noticed. 'display-buffer-avoid-small-windows': - Invariably affects, once set, 'get-lru-window' which can be used anywhere outside the scope of 'display-buffer'. So it's not only a misnomer but a typical example of a collateral effect. - Is described in section 29.15.4 of the Elisp manual which talks about "older options" some of them candidates for obsoletion. - Ignores that an action alist entry of that type already existed. It's called 'window-min-height' and could have been easily used here. Just that any such option should never be used in 'get-lru-window' but exclusively in functions that pertain to 'display-buffer'. martin