bug#13816: 24.3.50; turn-on-font-lock doesn't turn it on

bug#13816: 24.3.50; turn-on-font-lock doesn't turn it on

[Katsumi Yamaoka]

Recently turn-on-font-lock set to some hook turns font-lock
on but turns it off immediately regardless of the value of
global-font-lock-mode.  Here's a recipe:

emacs -Q
Eval: (add-hook 'emacs-lisp-mode-hook 'turn-on-font-lock)
and visit some .el file.

In Emacs 24.2, it works no matter what global-font-lock-mode is.
Thanks.

bug#13816: 24.3.50; turn-on-font-lock doesn't turn it on

[Stefan Monnier]

> Recently turn-on-font-lock set to some hook turns font-lock
> on but turns it off immediately regardless of the value of
> global-font-lock-mode.  Here's a recipe:

> emacs -Q
> Eval: (add-hook 'emacs-lisp-mode-hook 'turn-on-font-lock)
> and visit some .el file.

Works fine on the trunk right now.  Can you confirm it was fixed if you
try a recent enough build?


        Stefan

bug#13816: 24.3.50; turn-on-font-lock doesn't turn it on

[Drew Adams]

> > Recently turn-on-font-lock set to some hook turns font-lock
> > on but turns it off immediately regardless of the value of
> > global-font-lock-mode.  Here's a recipe:
> 
> > emacs -Q
> > Eval: (add-hook 'emacs-lisp-mode-hook 'turn-on-font-lock)
> > and visit some .el file.
> 
> Works fine on the trunk right now.  Can you confirm it was 
> fixed if you try a recent enough build?

The recent font-lock breakage is still there - it still does not work as of this
trunk build, today:

In GNU Emacs 24.3.50.1 (i386-mingw-nt5.1.2600)
 of 2013-02-25 on ODIEONE
Bzr revision: 111879 yamaoka@jpl.org-20130225224731-cv9gznq5nqf3ei7g
Windowing system distributor `Microsoft Corp.', version 5.1.2600
Configured using:
 `configure --with-gcc (4.7) --no-opt --enable-checking --cflags
 -IC:/Devel/emacs/build/include --ldflags -LC:/Devel/emacs/build/lib'

In particular, see bug #13767 (no `&optional' highlighting) and bug #13755 (see
screenshots).

However, bug #13751 seems to be fixed, at first sight, at least.

bug#13816: 24.3.50; turn-on-font-lock doesn't turn it on

[Dmitry Gutov]

"Drew Adams" <drew.adams@oracle.com> writes:

>> > Recently turn-on-font-lock set to some hook turns font-lock
>> > on but turns it off immediately regardless of the value of
>> > global-font-lock-mode.  Here's a recipe:
>> 
>> > emacs -Q
>> > Eval: (add-hook 'emacs-lisp-mode-hook 'turn-on-font-lock)
>> > and visit some .el file.
>> 
>> Works fine on the trunk right now.  Can you confirm it was 
>> fixed if you try a recent enough build?
>
> The recent font-lock breakage is still there - it still does not work as of this
> trunk build, today:
>
> In GNU Emacs 24.3.50.1 (i386-mingw-nt5.1.2600)
>  of 2013-02-25 on ODIEONE
> Bzr revision: 111879 yamaoka@jpl.org-20130225224731-cv9gznq5nqf3ei7g
> Windowing system distributor `Microsoft Corp.', version 5.1.2600
> Configured using:
>  `configure --with-gcc (4.7) --no-opt --enable-checking --cflags
>  -IC:/Devel/emacs/build/include --ldflags -LC:/Devel/emacs/build/lib'
>
> In particular, see bug #13767 (no `&optional' highlighting) and bug #13755 (see
> screenshots).
>
> However, bug #13751 seems to be fixed, at first sight, at least.

I also experienced font-lock-mode not turning on, and it was caused by
whitespace-mode. That part has been fixed in revision 111881.

bug#13816: 24.3.50; turn-on-font-lock doesn't turn it on

[Katsumi Yamaoka]

Stefan Monnier wrote:
>> Recently turn-on-font-lock set to some hook turns font-lock
>> on but turns it off immediately regardless of the value of
>> global-font-lock-mode.  Here's a recipe:

>> emacs -Q
>> Eval: (add-hook 'emacs-lisp-mode-hook 'turn-on-font-lock)
>> and visit some .el file.

> Works fine on the trunk right now.  Can you confirm it was fixed if you
> try a recent enough build?

I build Emacs from the trunk almost everyday.  Now I use:

In GNU Emacs 24.3.50.1 (i686-pc-cygwin, X toolkit, Xaw3d scroll bars)
 of 2013-02-26 on localhost
Bzr revision: 111880 monnier@iro.umontreal.ca-20130225232750-8wmx78e4uz1u7tfk
Windowing system distributor `The Cygwin/X Project', version 11.0.11302000
Configured using:
 `configure --verbose --with-x-toolkit=lucid --without-imagemagick
 --without-dbus --without-gconf --without-gsettings'

I've reverted the 111870 change because of bug#13818, though.

According to my tracing of run-mode-hooks, it turns on font-lock
but turns it off by the last line:

(defun run-mode-hooks (&rest hooks)
[...]
    ;; ON
    (apply 'run-hooks (cons 'change-major-mode-after-body-hook hooks))
    ;; OFF
    (run-hooks 'after-change-major-mode-hook)))

bug#13816: 24.3.50; turn-on-font-lock doesn't turn it on

[Katsumi Yamaoka]

I confirmed it has been fixed on:

In GNU Emacs 24.3.50.1 (i686-pc-cygwin, X toolkit, Xaw3d scroll bars)
 of 2013-02-26 on yamaoka-PC
Bzr revision: 111882 eggert@cs.ucla.edu-20130226030908-c65ivknn1bm5hjru
Windowing system distributor `The Cygwin/X Project', version 11.0.11302000

Sorry for the noise.

Katsumi Yamaoka wrote:
> Stefan Monnier wrote:
>>> Recently turn-on-font-lock set to some hook turns font-lock
>>> on but turns it off immediately regardless of the value of
>>> global-font-lock-mode.  Here's a recipe:

>>> emacs -Q
>>> Eval: (add-hook 'emacs-lisp-mode-hook 'turn-on-font-lock)
>>> and visit some .el file.

>> Works fine on the trunk right now.  Can you confirm it was fixed if you
>> try a recent enough build?

> I build Emacs from the trunk almost everyday.  Now I use:

> In GNU Emacs 24.3.50.1 (i686-pc-cygwin, X toolkit, Xaw3d scroll bars)
>  of 2013-02-26 on localhost
> Bzr revision: 111880 monnier@iro.umontreal.ca-20130225232750-8wmx78e4uz1u7tfk
> Windowing system distributor `The Cygwin/X Project', version 11.0.11302000
> Configured using:
>  `configure --verbose --with-x-toolkit=lucid --without-imagemagick
>  --without-dbus --without-gconf --without-gsettings'

> I've reverted the 111870 change because of bug#13818, though.

> According to my tracing of run-mode-hooks, it turns on font-lock
> but turns it off by the last line:

> (defun run-mode-hooks (&rest hooks)
> [...]
>     ;; ON
>     (apply 'run-hooks (cons 'change-major-mode-after-body-hook hooks))
>     ;; OFF
>     (run-hooks 'after-change-major-mode-hook)))

bug#13816: 24.3.50; turn-on-font-lock doesn't turn it on

[Stefan Monnier]

> I confirmed it has been fixed on:
> In GNU Emacs 24.3.50.1 (i686-pc-cygwin, X toolkit, Xaw3d scroll bars)
>  of 2013-02-26 on yamaoka-PC
> Bzr revision: 111882 eggert@cs.ucla.edu-20130226030908-c65ivknn1bm5hjru
> Windowing system distributor `The Cygwin/X Project', version 11.0.11302000
> Sorry for the noise.

Thanks for the noise ;-)


        Stefan