From mboxrd@z Thu Jan 1 00:00:00 1970 From: Marco Wahl <marcowahlsoft@gmail.com> Subject: Re: Bug: org-eww-copy-for-org-mode Empty Link problem + easy fix [9.0.4 (9.0.4-elpaplus @ /home/andrea/.emacs.d/elpa/org-plus-contrib-20170124/)] Date: Sun, 12 Feb 2017 09:27:57 +0100 Message-ID: <848tpb6cfm.fsf@tm6592> References: <87k28w7l6y.fsf@gmail.com> Mime-Version: 1.0 Content-Type: text/plain Return-path: <emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org> Received: from eggs.gnu.org ([2001:4830:134:3::10]:34386) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from <geo-emacs-orgmode@m.gmane.org>) id 1ccpW1-0005nG-UX for emacs-orgmode@gnu.org; Sun, 12 Feb 2017 03:28:15 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from <geo-emacs-orgmode@m.gmane.org>) id 1ccpVy-0006SV-Ok for emacs-orgmode@gnu.org; Sun, 12 Feb 2017 03:28:13 -0500 Received: from [195.159.176.226] (port=38838 helo=blaine.gmane.org) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from <geo-emacs-orgmode@m.gmane.org>) id 1ccpVy-0006SE-HU for emacs-orgmode@gnu.org; Sun, 12 Feb 2017 03:28:10 -0500 Received: from list by blaine.gmane.org with local (Exim 4.84_2) (envelope-from <geo-emacs-orgmode@m.gmane.org>) id 1ccpVp-00047w-2p for emacs-orgmode@gnu.org; Sun, 12 Feb 2017 09:28:01 +0100 List-Id: "General discussions about Org-mode." <emacs-orgmode.gnu.org> List-Unsubscribe: <https://lists.gnu.org/mailman/options/emacs-orgmode>, <mailto:emacs-orgmode-request@gnu.org?subject=unsubscribe> List-Archive: <http://lists.gnu.org/archive/html/emacs-orgmode/> List-Post: <mailto:emacs-orgmode@gnu.org> List-Help: <mailto:emacs-orgmode-request@gnu.org?subject=help> List-Subscribe: <https://lists.gnu.org/mailman/listinfo/emacs-orgmode>, <mailto:emacs-orgmode-request@gnu.org?subject=subscribe> Errors-To: emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org Sender: "Emacs-orgmode" <emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org> To: emacs-orgmode@gnu.org Cc: Andrea <agiugliano91@gmail.com> Hello Andrea, thanks for your bug report and your suggestion to fix the bug. [...] > The error is due to the presence of input forms (e.g., in > www.indeed.co.uk where you can add the job you are looking for), that > are considered like urls by this function [1]. When the input form is > passed to org-make-link-string, org-make-link-string complains that the > link is empty. > > Now I solved this by adding an if statement that makes the link only if > the info passed is not nil [2], but maybe someone knows a better check > for org-eww-goto-next-url-property-change than the one using 'shr-url? I committed a fix to maint and master. Concretely I simplified your code to essentially one additional if case. You are referenced in the commit-message as reporter. Best regards, Marco