From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Jostein =?UTF-8?Q?Kj=C3=B8nigsen?= Newsgroups: gmane.emacs.bugs Subject: bug#59831: 29.0.60; typescript-ts-mode: Variables, properties & fields are often not fontified Date: Wed, 7 Dec 2022 10:24:56 +0100 Message-ID: <848e54b0-4b74-2d85-064d-bf8dc792d1e8@secure.kjonigsen.net> References: <676d4e95-dfe3-5ced-60a3-b2387512ee63@secure.kjonigsen.net> <87v8mqxmfo.fsf@thornhill.no> <2151efc1-b6f6-4e0d-7416-cccae9277a34@secure.kjonigsen.net> <87bkoifbj3.fsf@thornhill.no> Reply-To: jostein@kjonigsen.net Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="------------qh9oCXXieqapk4mBkOp34ePl" Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="30574"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.5.1 Cc: 59831@debbugs.gnu.org To: Yuan Fu , Theodor Thornhill Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Wed Dec 07 10:26:24 2022 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1p2qh5-0007dP-DK for geb-bug-gnu-emacs@m.gmane-mx.org; Wed, 07 Dec 2022 10:26:23 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1p2qgm-0006tc-MP; Wed, 07 Dec 2022 04:26:04 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1p2qgl-0006tH-4P for bug-gnu-emacs@gnu.org; Wed, 07 Dec 2022 04:26:03 -0500 Original-Received: from debbugs.gnu.org ([209.51.188.43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1p2qgk-0002Aa-Qd for bug-gnu-emacs@gnu.org; Wed, 07 Dec 2022 04:26:02 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1p2qgk-0001Ov-GA for bug-gnu-emacs@gnu.org; Wed, 07 Dec 2022 04:26:02 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Jostein =?UTF-8?Q?Kj=C3=B8nigsen?= Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Wed, 07 Dec 2022 09:26:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 59831 X-GNU-PR-Package: emacs Original-Received: via spool by 59831-submit@debbugs.gnu.org id=B59831.16704051095365 (code B ref 59831); Wed, 07 Dec 2022 09:26:02 +0000 Original-Received: (at 59831) by debbugs.gnu.org; 7 Dec 2022 09:25:09 +0000 Original-Received: from localhost ([127.0.0.1]:48765 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1p2qft-0001OT-7C for submit@debbugs.gnu.org; Wed, 07 Dec 2022 04:25:09 -0500 Original-Received: from wout1-smtp.messagingengine.com ([64.147.123.24]:43771) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1p2qfq-0001O1-B1 for 59831@debbugs.gnu.org; Wed, 07 Dec 2022 04:25:07 -0500 Original-Received: from compute3.internal (compute3.nyi.internal [10.202.2.43]) by mailout.west.internal (Postfix) with ESMTP id 1A6EE32009A5; Wed, 7 Dec 2022 04:25:00 -0500 (EST) Original-Received: from mailfrontend1 ([10.202.2.162]) by compute3.internal (MEProxy); Wed, 07 Dec 2022 04:25:00 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= secure.kjonigsen.net; h=cc:cc:content-type:date:date:from:from :in-reply-to:in-reply-to:message-id:mime-version:references :reply-to:reply-to:sender:subject:subject:to:to; s=fm3; t= 1670405099; x=1670491499; bh=kOCKF1ouurffjE8WIlHyc8Vl+0plBqIMSx8 NCEVVCYc=; b=uuD03lDDZve/0QT0BKaYiw241cn9zf+h7ibe12PjRwQgnT4mpJf 7f9UW6MJejoTU/XT4VevdSpxBMdZqirdOsXsGWZxAkKMhoXEjDCbMfXJH7jeGfqW jT5T/Gzwao3PSASPKFk8BblyJRE+7fWPfg954HRHFUiPnPZ5fSmNYCF/tGmmtJJg 8GwXK/ZSL0FohxP/8pDeQx+viFWuM3HnWP2o2nC1eLJTFV7WnqymL5v++gkdpLLe 0C68GK6wK+WAOmcHyWl6GcoObsK50jr8TC3gYIwvWfVbLEwDvrNTHajlj336GJ6O lJpEUaXN34NNFLwF+HRoqKU9oln7ux8ylUw== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-type:date:date:feedback-id :feedback-id:from:from:in-reply-to:in-reply-to:message-id :mime-version:references:reply-to:reply-to:sender:subject :subject:to:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender :x-sasl-enc; s=fm1; t=1670405099; x=1670491499; bh=kOCKF1ouurffj E8WIlHyc8Vl+0plBqIMSx8NCEVVCYc=; b=nfKOJRicReA0Aogsg24jvWJlRYTXq 2GVPvci2eglbuPHFcUG73WOcPcg1TkDfr/g5m/ec+YAFS1Veh0/XOoJy9oFyoOWN 0QOz4JnQyTq0jmKmqgSlCLhnPEVC4aSa/SNPLPvDTWZE2Oo/RqsgIjSu6clJD/tg Z6lm88ZURX/IQU6fOtc8YdK+a9ouvFJypR00+xIxCH1WyZ6ASZZVWNgx0nDIN803 mibC8bCAYs0066CKwUhu5GEY1j1ejNZBUtQxN8t2FuKQ+BW8BEs4iM7HPJxFhrms UcJRPe5wWVjxMezEHgD4/vt3qX3DGXJiYPfLY9vv6gl6kxB3IJnCcujlg== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvhedrudekgddtvdcutefuodetggdotefrodftvf curfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfghnecu uegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmdenuc fjughrpegtkfffgggfrhfuvfevfhfhjgesmhdtreertdefjeenucfhrhhomheplfhoshht vghinhcumfhjpphnihhgshgvnhcuoehjohhsthgvihhnsehsvggtuhhrvgdrkhhjohhnih hgshgvnhdrnhgvtheqnecuggftrfgrthhtvghrnhepleeihefgveefffelkeelleffffdt feevleetheefgfdtgfdtfeeiveekgfevkedvnecuvehluhhsthgvrhfuihiivgeptdenuc frrghrrghmpehmrghilhhfrhhomhepjhhoshhtvghinhesshgvtghurhgvrdhkjhhonhhi ghhsvghnrdhnvght X-ME-Proxy: Feedback-ID: ib2f84088:Fastmail Original-Received: by mail.messagingengine.com (Postfix) with ESMTPA; Wed, 7 Dec 2022 04:24:58 -0500 (EST) Content-Language: nb-NO In-Reply-To: X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:250169 Archived-At: This is a multi-part message in MIME format. --------------qh9oCXXieqapk4mBkOp34ePl Content-Type: multipart/alternative; boundary="------------wWbDOqTvrG6BUiwRDBcq08lX" --------------wWbDOqTvrG6BUiwRDBcq08lX Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit Hey everyone. I'd like to add one more change to this particular bug, which makes fontification of variables more consistent when used in other expressions and statements. Please see attached patch. In short this patch changes the following: * fontifies property-access in general expressions * fontifies variables and property-access in if-expressions -- Jostein On 05.12.2022 21:13, Yuan Fu wrote: > >> On Dec 5, 2022, at 1:24 AM, Theodor Thornhill via Bug reports for GNU Emacs, the Swiss army knife of text editors wrote: >> >> Jostein Kjønigsen writes: >> >>> Attached is another patch with some further improvements. >>> >>> These too OK with you, Theodor? >>> >> Yep! > I squashed the two commits and applied them, Thanks! > > Yuan --------------wWbDOqTvrG6BUiwRDBcq08lX Content-Type: text/html; charset=UTF-8 Content-Transfer-Encoding: 8bit

Hey everyone.

I'd like to add one more change to this particular bug, which makes fontification of variables more consistent when used in other expressions and statements.

Please see attached patch.

In short this patch changes the following:

  • fontifies property-access in general expressions
  • fontifies variables and property-access in if-expressions

--
Jostein

On 05.12.2022 21:13, Yuan Fu wrote:


On Dec 5, 2022, at 1:24 AM, Theodor Thornhill via Bug reports for GNU Emacs, the Swiss army knife of text editors <bug-gnu-emacs@gnu.org> wrote:

Jostein Kjønigsen <jostein@secure.kjonigsen.net> writes:


Attached is another patch with some further improvements.

These too OK with you, Theodor?


Yep!

I squashed the two commits and applied them, Thanks!

Yuan
--------------wWbDOqTvrG6BUiwRDBcq08lX-- --------------qh9oCXXieqapk4mBkOp34ePl Content-Type: text/x-patch; charset=UTF-8; name="0001-lisp-progmodes-typescript-ts-mode.el-Improve-fontifi.patch" Content-Disposition: attachment; filename*0="0001-lisp-progmodes-typescript-ts-mode.el-Improve-fontifi.pa"; filename*1="tch" Content-Transfer-Encoding: base64 RnJvbSAwODE3YTlhOWNlMDBiZjQ0ZTYzNjhhM2Q3NDI2MmY4M2U0OWViYmYzIE1vbiBTZXAg MTcgMDA6MDA6MDAgMjAwMQpGcm9tOiA9P1VURi04P3E/Sm9zdGVpbj0yMEtqPUMzPUI4bmln c2VuPz0gPGpvc3RlaW5Aa2pvbmlnc2VuLm5ldD4KRGF0ZTogV2VkLCA3IERlYyAyMDIyIDA5 OjI3OjQyICswMTAwClN1YmplY3Q6IFtQQVRDSF0gbGlzcC9wcm9nbW9kZXMvdHlwZXNjcmlw dC10cy1tb2RlLmVsOiBJbXByb3ZlIGZvbnRpZmljYXRpb24KIG9mIHZhcmlhYmxlcwoKLS0t CiBsaXNwL3Byb2dtb2Rlcy90eXBlc2NyaXB0LXRzLW1vZGUuZWwgfCA0MyArKysrKysrKysr KysrKysrKy0tLS0tLS0tLS0tCiAxIGZpbGUgY2hhbmdlZCwgMjcgaW5zZXJ0aW9ucygrKSwg MTYgZGVsZXRpb25zKC0pCgpkaWZmIC0tZ2l0IGEvbGlzcC9wcm9nbW9kZXMvdHlwZXNjcmlw dC10cy1tb2RlLmVsIGIvbGlzcC9wcm9nbW9kZXMvdHlwZXNjcmlwdC10cy1tb2RlLmVsCmlu ZGV4IDNkYTY5MDU2N2UyLi4zM2YzMzJkNjZkNiAxMDA2NDQKLS0tIGEvbGlzcC9wcm9nbW9k ZXMvdHlwZXNjcmlwdC10cy1tb2RlLmVsCisrKyBiL2xpc3AvcHJvZ21vZGVzL3R5cGVzY3Jp cHQtdHMtbW9kZS5lbApAQCAtMjIwLDcgKzIyMCwzMiBAQCB0eXBlc2NyaXB0LXRzLW1vZGUt LWZvbnQtbG9jay1zZXR0aW5ncwogICAgICAoYmluYXJ5X2V4cHJlc3Npb24gbGVmdDogKGlk ZW50aWZpZXIpIEBmb250LWxvY2stdmFyaWFibGUtbmFtZS1mYWNlKQogICAgICAoYmluYXJ5 X2V4cHJlc3Npb24gcmlnaHQ6IChpZGVudGlmaWVyKSBAZm9udC1sb2NrLXZhcmlhYmxlLW5h bWUtZmFjZSkKIAotICAgICAoYXJndW1lbnRzIChpZGVudGlmaWVyKSBAZm9udC1sb2NrLXZh cmlhYmxlLW5hbWUtZmFjZSkpCisgICAgIChhcmd1bWVudHMgKGlkZW50aWZpZXIpIEBmb250 LWxvY2stdmFyaWFibGUtbmFtZS1mYWNlKQorCisgICAgIChwYXJlbnRoZXNpemVkX2V4cHJl c3Npb24gKGlkZW50aWZpZXIpIEBmb250LWxvY2stdmFyaWFibGUtbmFtZS1mYWNlKSkKKwor ICAgOmxhbmd1YWdlIGxhbmd1YWdlCisgICA6b3ZlcnJpZGUgdAorICAgOmZlYXR1cmUgJ3By b3BlcnR5CisgICBgKChwcm9wZXJ0eV9zaWduYXR1cmUKKyAgICAgIG5hbWU6IChwcm9wZXJ0 eV9pZGVudGlmaWVyKSBAZm9udC1sb2NrLXByb3BlcnR5LWZhY2UpCisgICAgIChwdWJsaWNf ZmllbGRfZGVmaW5pdGlvbgorICAgICAgbmFtZTogKHByb3BlcnR5X2lkZW50aWZpZXIpIEBm b250LWxvY2stcHJvcGVydHktZmFjZSkKKyAgICAgKG1lbWJlcl9leHByZXNzaW9uCisgICAg ICBvYmplY3Q6IChpZGVudGlmaWVyKSBAZm9udC1sb2NrLXZhcmlhYmxlLW5hbWUtZmFjZQor ICAgICAgcHJvcGVydHk6IChfKSBAZm9udC1sb2NrLXByb3BlcnR5LWZhY2UpCisgICAgICht ZW1iZXJfZXhwcmVzc2lvbgorICAgICAgb2JqZWN0OiAodGhpcykgQGZvbnQtbG9jay1rZXl3 b3JkLWZhY2UKKyAgICAgIHByb3BlcnR5OiAoXykgQGZvbnQtbG9jay1wcm9wZXJ0eS1mYWNl KQorCisgICAgIChwYWlyIGtleTogKHByb3BlcnR5X2lkZW50aWZpZXIpIEBmb250LWxvY2st dmFyaWFibGUtbmFtZS1mYWNlKQorCisgICAgIChwYWlyIHZhbHVlOiAoaWRlbnRpZmllcikg QGZvbnQtbG9jay12YXJpYWJsZS1uYW1lLWZhY2UpCisKKyAgICAgKChzaG9ydGhhbmRfcHJv cGVydHlfaWRlbnRpZmllcikgQGZvbnQtbG9jay1wcm9wZXJ0eS1mYWNlKQorCisgICAgICgo c2hvcnRoYW5kX3Byb3BlcnR5X2lkZW50aWZpZXJfcGF0dGVybikKKyAgICAgIEBmb250LWxv Y2stcHJvcGVydHktZmFjZSkpCiAKICAgIDpsYW5ndWFnZSBsYW5ndWFnZQogICAgOm92ZXJy aWRlIHQKQEAgLTI4NiwyMiArMzExLDggQEAgdHlwZXNjcmlwdC10cy1tb2RlLS1mb250LWxv Y2stc2V0dGluZ3MKICAgIDpvdmVycmlkZSB0CiAgICAnKChlc2NhcGVfc2VxdWVuY2UpIEBm b250LWxvY2stZXNjYXBlLWZhY2UpCiAKLSAgIDpsYW5ndWFnZSBsYW5ndWFnZQotICAgOm92 ZXJyaWRlIHQKLSAgIDpmZWF0dXJlICdwcm9wZXJ0eQotICAgYCgocHJvcGVydHlfc2lnbmF0 dXJlCi0gICAgICBuYW1lOiAocHJvcGVydHlfaWRlbnRpZmllcikgQGZvbnQtbG9jay1wcm9w ZXJ0eS1mYWNlKQotICAgICAocHVibGljX2ZpZWxkX2RlZmluaXRpb24KLSAgICAgIG5hbWU6 IChwcm9wZXJ0eV9pZGVudGlmaWVyKSBAZm9udC1sb2NrLXByb3BlcnR5LWZhY2UpCiAKLSAg ICAgKHBhaXIga2V5OiAocHJvcGVydHlfaWRlbnRpZmllcikgQGZvbnQtbG9jay12YXJpYWJs ZS1uYW1lLWZhY2UpCi0KLSAgICAgKHBhaXIgdmFsdWU6IChpZGVudGlmaWVyKSBAZm9udC1s b2NrLXZhcmlhYmxlLW5hbWUtZmFjZSkKLQotICAgICAoKHNob3J0aGFuZF9wcm9wZXJ0eV9p ZGVudGlmaWVyKSBAZm9udC1sb2NrLXByb3BlcnR5LWZhY2UpCi0KLSAgICAgKChzaG9ydGhh bmRfcHJvcGVydHlfaWRlbnRpZmllcl9wYXR0ZXJuKQotICAgICAgQGZvbnQtbG9jay1wcm9w ZXJ0eS1mYWNlKSkpKQorICAgKSkKIAogOzs7IyMjYXV0b2xvYWQKIChhZGQtdG8tbGlzdCAn YXV0by1tb2RlLWFsaXN0ICcoIlxcLnRzXFwnIiAuIHR5cGVzY3JpcHQtdHMtbW9kZSkpCi0t IAoyLjM3LjIKCg== --------------qh9oCXXieqapk4mBkOp34ePl--