From mboxrd@z Thu Jan 1 00:00:00 1970 Path: main.gmane.org!not-for-mail From: kai.grossjohann@uni-duisburg.de (Kai =?iso-8859-1?q?Gro=DFjohann?=) Newsgroups: gmane.emacs.devel Subject: Re: Janitorial issues: Man-getpage-in-background Date: Fri, 07 Mar 2003 18:53:51 +0100 Organization: University of Duisburg, Germany Sender: emacs-devel-bounces+emacs-devel=quimby.gnus.org@gnu.org Message-ID: <8465qvoyfk.fsf@lucy.is.informatik.uni-duisburg.de> References: <84of4qdqxt.fsf@lucy.is.informatik.uni-duisburg.de> <3E67A82B.5090008@ihs.com> NNTP-Posting-Host: main.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Transfer-Encoding: 8bit X-Trace: main.gmane.org 1047059736 22413 80.91.224.249 (7 Mar 2003 17:55:36 GMT) X-Complaints-To: usenet@main.gmane.org NNTP-Posting-Date: Fri, 7 Mar 2003 17:55:36 +0000 (UTC) Original-X-From: emacs-devel-bounces+emacs-devel=quimby.gnus.org@gnu.org Fri Mar 07 18:55:34 2003 Return-path: Original-Received: from quimby.gnus.org ([80.91.224.244]) by main.gmane.org with esmtp (Exim 3.35 #1 (Debian)) id 18rM4D-0005p9-00 for ; Fri, 07 Mar 2003 18:55:33 +0100 Original-Received: from monty-python.gnu.org ([199.232.76.173]) by quimby.gnus.org with esmtp (Exim 3.12 #1 (Debian)) id 18rMP7-000273-00 for ; Fri, 07 Mar 2003 19:17:10 +0100 Original-Received: from localhost ([127.0.0.1] helo=monty-python.gnu.org) by monty-python.gnu.org with esmtp (Exim 4.10.13) id 18rM3Q-0001uw-06 for emacs-devel@quimby.gnus.org; Fri, 07 Mar 2003 12:54:44 -0500 Original-Received: from list by monty-python.gnu.org with tmda-scanned (Exim 4.10.13) id 18rM32-0001hP-00 for emacs-devel@gnu.org; Fri, 07 Mar 2003 12:54:20 -0500 Original-Received: from mail by monty-python.gnu.org with spam-scanned (Exim 4.10.13) id 18rM2w-0001Te-00 for emacs-devel@gnu.org; Fri, 07 Mar 2003 12:54:15 -0500 Original-Received: from main.gmane.org ([80.91.224.249]) by monty-python.gnu.org with esmtp (Exim 4.10.13) id 18rM2l-0001MZ-00 for emacs-devel@gnu.org; Fri, 07 Mar 2003 12:54:03 -0500 Original-Received: from list by main.gmane.org with local (Exim 3.35 #1 (Debian)) id 18rM2B-0005eU-00 for ; Fri, 07 Mar 2003 18:53:27 +0100 X-Injected-Via-Gmane: http://gmane.org/ Original-To: emacs-devel@gnu.org Original-Received: from news by main.gmane.org with local (Exim 3.35 #1 (Debian)) id 18rM2A-0005eG-00 for ; Fri, 07 Mar 2003 18:53:26 +0100 Original-Lines: 29 Original-X-Complaints-To: usenet@main.gmane.org User-Agent: Gnus/5.090016 (Oort Gnus v0.16) Emacs/21.3.50 (gnu/linux) Cancel-Lock: sha1:u6GjztzrqfkLhDRrfKmsJJnHYjU= X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1b5 Precedence: list List-Id: Emacs development discussions. List-Help: List-Post: List-Subscribe: , List-Archive: List-Unsubscribe: , Errors-To: emacs-devel-bounces+emacs-devel=quimby.gnus.org@gnu.org Xref: main.gmane.org gmane.emacs.devel:12141 X-Report-Spam: http://spam.gmane.org/gmane.emacs.devel:12141 Kevin Rodgers writes: > Kai Großjohann wrote: > >> The function Man-getpage-in-background uses two different ways to set >> environment variables: >> (a) (let ((process-environment (copy-sequence process-environment))) >> (setenv "FOO" "bar") >> ...) >> (b) (let ((process-environment (cons "FOO=bar" process-environment))) >> ...) >> It looks really strange to see them both in the same function... >> Okay to unify? (I'd choose (a) unless there are objections.) > > Objection! (I've always wanted to say that :-) > > On the basis of unnecessary cons'ing. It seems you do not object to the unification, just to my choice of (a)? It seems that setenv does quite a bit of work in addition to consing stuff onto process-environment. I'm not sure it is a good idea to skip using setenv. Wasn't there a discussion about having setenv do something additional to frobbing process-environment? It was some moons ago. I'm not talking about the multibyte issue that was recently mentioned. Hmmm... -- A preposition is not a good thing to end a sentence with.