From: Paul Eggert <eggert@cs.ucla.edu>
To: martin rudalics <rudalics@gmx.at>,
Stefan Monnier <monnier@IRO.UMontreal.CA>,
emacs-devel@gnu.org
Subject: Re: [Emacs-diffs] emacs-26 9bf66c6: Don't run FOR_EACH_FRAME when there's no frame left (Bug#29961)
Date: Sun, 17 Dec 2017 16:39:13 -0800 [thread overview]
Message-ID: <84451444-be0f-2cbe-1e08-90c042c2c14b@cs.ucla.edu> (raw)
In-Reply-To: <5A364B09.4020905@gmx.at>
martin rudalics wrote:
> eassume (CONSP (Vframe_list));
>
> now means that we can assume that `frame-list' is non-empty. Isn't that
> assumption incorrect in the scenario of the bug we're discussing here?
Yes and no. The assumption is incorrect for this particular bug. But it is
correct for the two instances of eassume (CONSP (Vframe_list)) that I resurrected.
> > commit 8720f601e715e5f1d41f7cf863a525a1cc1bc12c
> > removed these functions' assertions that frame-list is non-nil, so I
> > thought it wise to resurrect them.
>
> I don't think that these assertions did any good and would remove them
> at least on master.
Sounds good to me. Assertions that aren't useful for finding bugs are more
trouble than they're worth. I kept them only because I didn't know the context well.
next prev parent reply other threads:[~2017-12-18 0:39 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20171215073120.7671.79446@vcs0.savannah.gnu.org>
[not found] ` <20171215073122.52703204D3@vcs0.savannah.gnu.org>
2017-12-15 16:23 ` [Emacs-diffs] emacs-26 9bf66c6: Don't run FOR_EACH_FRAME when there's no frame left (Bug#29961) Stefan Monnier
2017-12-15 17:13 ` Paul Eggert
2017-12-15 18:17 ` martin rudalics
2017-12-15 19:09 ` Paul Eggert
2017-12-16 9:42 ` martin rudalics
2017-12-17 0:50 ` Paul Eggert
2017-12-17 10:46 ` martin rudalics
2017-12-18 0:39 ` Paul Eggert [this message]
2017-12-18 7:26 ` martin rudalics
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=84451444-be0f-2cbe-1e08-90c042c2c14b@cs.ucla.edu \
--to=eggert@cs.ucla.edu \
--cc=emacs-devel@gnu.org \
--cc=monnier@IRO.UMontreal.CA \
--cc=rudalics@gmx.at \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.