From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.ciao.gmane.io!not-for-mail From: Dmitry Gutov Newsgroups: gmane.emacs.bugs Subject: bug#38992: 27.0.60; when enabled, fido-mode seems to break vc-git-grep Date: Thu, 5 Mar 2020 11:59:53 +0200 Message-ID: <84206f04-6947-1440-9138-a950dfecb63a@yandex.ru> References: <288610218.111246.1578330546916@office.mailbox.org> <5dc9535d-9b2f-56f1-2e63-b75ff3aaaf55@yandex.ru> <9da3ee1b-7315-41d2-192b-9db470d50ba4@yandex.ru> <83blqik9wv.fsf@gnu.org> <838slhglog.fsf@gnu.org> <21dc455e-b56e-3971-86f2-4773a57be64b@yandex.ru> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 8bit Injection-Info: ciao.gmane.io; posting-host="ciao.gmane.io:159.69.161.202"; logging-data="18162"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.9.0 Cc: 38992@debbugs.gnu.org, Stefan Monnier , waah@yellowfrog.io To: =?UTF-8?Q?Jo=C3=A3o_?= =?UTF-8?Q?T=C3=A1vora?= Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Thu Mar 05 11:02:46 2020 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1j9nL2-0004aM-Kp for geb-bug-gnu-emacs@m.gmane-mx.org; Thu, 05 Mar 2020 11:02:44 +0100 Original-Received: from localhost ([::1]:46094 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1j9nL1-0003WS-LK for geb-bug-gnu-emacs@m.gmane-mx.org; Thu, 05 Mar 2020 05:02:43 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:38610) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1j9nJP-0002St-PT for bug-gnu-emacs@gnu.org; Thu, 05 Mar 2020 05:01:04 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1j9nJO-0002Op-Nr for bug-gnu-emacs@gnu.org; Thu, 05 Mar 2020 05:01:03 -0500 Original-Received: from debbugs.gnu.org ([209.51.188.43]:36211) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1j9nJO-0002Oa-Jp for bug-gnu-emacs@gnu.org; Thu, 05 Mar 2020 05:01:02 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1j9nJO-0004LE-IK for bug-gnu-emacs@gnu.org; Thu, 05 Mar 2020 05:01:02 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Dmitry Gutov Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Thu, 05 Mar 2020 10:01:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 38992 X-GNU-PR-Package: emacs Original-Received: via spool by 38992-submit@debbugs.gnu.org id=B38992.158340240416540 (code B ref 38992); Thu, 05 Mar 2020 10:01:02 +0000 Original-Received: (at 38992) by debbugs.gnu.org; 5 Mar 2020 10:00:04 +0000 Original-Received: from localhost ([127.0.0.1]:42184 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1j9nIS-0004Ii-BU for submit@debbugs.gnu.org; Thu, 05 Mar 2020 05:00:04 -0500 Original-Received: from mail-wr1-f54.google.com ([209.85.221.54]:40473) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1j9nIQ-0004Hi-42 for 38992@debbugs.gnu.org; Thu, 05 Mar 2020 05:00:03 -0500 Original-Received: by mail-wr1-f54.google.com with SMTP id r17so6196018wrj.7 for <38992@debbugs.gnu.org>; Thu, 05 Mar 2020 02:00:01 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=nn6hxJko5oBKau39XEk2ZgwvbbdN6u2feVvJSZ9LmJw=; b=CIMWL8Tlg1EitvcKg55v78tTYXY3VFZm7KHdH6uJUGvIKmtYagLBrIdFc14rBCCy5S dH4g16n1NSuOA4+lSYP8KF/KTvDiuoY2hOKzKLt2wikIbR77bZIZ165ERIoLwSof4AP5 xMfSIJJaxTeNxeQBsEJ4l8Ml3xrUyaXADVejErcoFsVcKub3TqOlgDAcygR/ND8ViOiN TYSoJ/LoVRKABxs4RrUK8fVUymh10X13tkuUxHVk3dj3j6GC8MvV3tZtem/V04hxtZBz Ng0CsjhX650kl9SGwmRxageCXXULZ0Id2nYEBLRucLAkDZ1X6iC+8Rp7bZy1Q9EptsDS MStQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:subject:to:cc:references:from:message-id :date:user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=nn6hxJko5oBKau39XEk2ZgwvbbdN6u2feVvJSZ9LmJw=; b=ISjNP+wGzXxg9O4ejdSdvnu3Z5NGy45zZsiQsinwninSalqNoF8hCnG0VkkLqihped XqchmiN4iQFErT2+Cp3QKs8hWD0vaXDSdP6hC5XiM2JucGFgjucInCXXxqhGbu4RaHky VsAnhFP5tCVsBl1cOzaXhurRm49V6svyuqzMYU1QDDy7XdmktGk5hxqjx/hgiAWJvwWm DPymgh5LwKUyeRODIhidvCTovFtDLsKpG3/5ru1nbbJNIHTvw32AMWbWqtGFg1w5iA1Q GwSDyWWElTpHkTjbcu3tK011F3sGL2swUASLBNdVf+FMlSnWqoELYhkeBgPy0X3HAZK2 O2Tg== X-Gm-Message-State: ANhLgQ2DTxHXt6kRCV9seNd6HHacc7z50CDbX76nHeXSJHoUT/kvNFWs sC4Fbe++RR9CSYPLwWgvcT0= X-Google-Smtp-Source: ADFU+vu9ebKnCk8Vi1ToiqPzbxtf8RZyhNJvWfG2Gg8p/+HWgboyFDhTg+TbkhnnaiGaiT6a/I/fxA== X-Received: by 2002:a5d:608e:: with SMTP id w14mr9845240wrt.201.1583402396189; Thu, 05 Mar 2020 01:59:56 -0800 (PST) Original-Received: from [192.168.0.2] ([66.205.73.129]) by smtp.googlemail.com with ESMTPSA id l3sm43516734wrq.62.2020.03.05.01.59.53 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Thu, 05 Mar 2020 01:59:54 -0800 (PST) In-Reply-To: Content-Language: en-US X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 209.51.188.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:176894 Archived-At: On 05.03.2020 10:46, João Távora wrote: > On Thu, Mar 5, 2020 at 8:36 AM Dmitry Gutov > wrote: > > > > On 05.03.2020 10:01, João Távora wrote: > > > > >  >  ido-mode users, however, like to use RET for arbitrary inputs > as well. > > > > > > Let's first _not_ change the current fido-mode UI ok? At least > > > for now.  Later (even before Emacs 27) could be fine. > > > > It only changed according to our previous discussion. E.g. RET can now > > accept '*.c' as pattern to search for in 'M-x grep'. > > Yes, that fine.  I meant, let's not change it _further_ (if that was indeed > what you were proposing). Nope, just this. > Also, I think, for safety, that we still should have in the > fido-mode-keymap > sth bound to the "atomic" give-me-whatever-is-in-minibuffer > command, maybe C-M-j or something like that.  Even if it > _does_ break the required-match semantics somewhere else, > it just seems like a good idea. But why? REQUIRE-MATCH is there for a reason. The caller does not expect non-matching inputs, and is unlikely to handle them well. If non-matching input can make sense, then the caller needs to be changed. > > Of course, if there were any matches in the completion table for that > > input, RET would choose the first match. > > > > Let me know if you see a problem there. > > Hmmm, isn't that how ido-mode behaves already, and how fido-mode > behaves, at least to a large extent? If so it seems fine. No, I meant a problem in overall behavior. But it seems fine to me as well.