all messages for Emacs-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
From: Marco Wahl <marcowahlsoft@gmail.com>
To: emacs-orgmode@gnu.org
Subject: Re: Bug in Recent Agenda Mod
Date: Tue, 21 Mar 2017 09:03:53 +0100	[thread overview]
Message-ID: <841strys2e.fsf@tm6592> (raw)
In-Reply-To: 87efxrv5s5.fsf@escafil

Ian Dunn <dunni@gnu.org> writes:

> Commit d262ae53c966c7a745c0fa779149f9eb7486333d "org-agenda: Fix agenda standard name when going unsticky" sets org-agenda-buffer-name to "*Org Agenda*" if not in sticky.
>
> However, org-agenda-redo sets org-agenda-sticky to nil before redoing the agenda command.
>
> Steps to Reproduce:
>
> 1. Turn on org-agenda-sticky
> 2. Execute any agenda command that only involves org-agenda-list
>    - Agenda is in buffer *Org Agenda(CMD)* (ex. *Org Agenda(d:)*)
> 3. Press 'g' (org-agenda-redo)
>    - Agenda is now in *Org Agenda*
>
> The included patch fixes this for sticky redo, and will have no effect for anything other than a sticky redo.
>
> --
> Ian Dunn
>
> diff --git a/lisp/org-agenda.el b/lisp/org-agenda.el
> index b618653d5..04e6685b5 100644
> --- a/lisp/org-agenda.el
> +++ b/lisp/org-agenda.el
> @@ -4076,6 +4076,7 @@ items if they have an hour specification like [h]h:mm."
>    (catch 'exit
>      (setq org-agenda-buffer-name
>  	  (or org-agenda-buffer-tmp-name
> +	      (and org-agenda-doing-sticky-redo org-agenda-buffer-name)
>  	      (if org-agenda-sticky
>  		  (cond ((and org-keys (stringp org-match))
>  			 (format "*Org Agenda(%s:%s)*" org-keys org-match))

Good catch, good fix AFAICT.  Thanks.

May I add this line with a commit message referencing you as the
originator?  (I have not found you in the contributors list.)


Best regards,

             Marco

  reply	other threads:[~2017-03-21  8:04 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-03-21  0:21 Bug in Recent Agenda Mod Ian Dunn
2017-03-21  8:03 ` Marco Wahl [this message]
2017-03-21 20:13   ` Marco Wahl
2017-03-21 14:05 ` Matt Lundin

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=841strys2e.fsf@tm6592 \
    --to=marcowahlsoft@gmail.com \
    --cc=emacs-orgmode@gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/emacs.git
	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.