From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.devel Subject: select-active-regions Date: Sat, 18 Jul 2009 14:20:09 +0300 Message-ID: <83zlb2p79y.fsf@gnu.org> Reply-To: Eli Zaretskii NNTP-Posting-Host: lo.gmane.org X-Trace: ger.gmane.org 1247916026 22868 80.91.229.12 (18 Jul 2009 11:20:26 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Sat, 18 Jul 2009 11:20:26 +0000 (UTC) Cc: emacs-devel@gnu.org To: David De La Harpe Golden Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Sat Jul 18 13:20:19 2009 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([199.232.76.165]) by lo.gmane.org with esmtp (Exim 4.50) id 1MS7xh-0007f5-Tz for ged-emacs-devel@m.gmane.org; Sat, 18 Jul 2009 13:20:18 +0200 Original-Received: from localhost ([127.0.0.1]:41757 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1MS7xh-0003EY-2O for ged-emacs-devel@m.gmane.org; Sat, 18 Jul 2009 07:20:17 -0400 Original-Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1MS7xc-0003D4-HM for emacs-devel@gnu.org; Sat, 18 Jul 2009 07:20:12 -0400 Original-Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1MS7xb-0003Cp-0M for emacs-devel@gnu.org; Sat, 18 Jul 2009 07:20:11 -0400 Original-Received: from [199.232.76.173] (port=45999 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1MS7xa-0003Cm-Rw for emacs-devel@gnu.org; Sat, 18 Jul 2009 07:20:10 -0400 Original-Received: from mtaout2.012.net.il ([84.95.2.4]:37013) by monty-python.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1MS7xa-00018u-Gn for emacs-devel@gnu.org; Sat, 18 Jul 2009 07:20:10 -0400 Original-Received: from conversion-daemon.i_mtaout2.012.net.il by i_mtaout2.012.net.il (HyperSendmail v2004.12) id <0KMZ0050060EBE00@i_mtaout2.012.net.il> for emacs-devel@gnu.org; Sat, 18 Jul 2009 14:20:09 +0300 (IDT) Original-Received: from HOME-C4E4A596F7 ([87.70.207.26]) by i_mtaout2.012.net.il (HyperSendmail v2004.12) with ESMTPA id <0KMZ0063D65KNQ00@i_mtaout2.012.net.il>; Sat, 18 Jul 2009 14:20:09 +0300 (IDT) X-012-Sender: halo1@inter.net.il X-detected-operating-system: by monty-python.gnu.org: Solaris 9.1 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:112672 Archived-At: When making changes like these: 2009-07-17 David De La Harpe Golden * w32-fns.el (x-selection-owner-p): New function. * mouse.el (mouse-drag-track): Call deactivate-mark earlier. (mouse-yank-at-click, mouse-yank-primary): If select-active-regions is non-nil, deactivate the mark before insertion. * simple.el (deactivate-mark, set-mark): Only save selection if we own it. please do not forget that the MS-DOS port of Emacs also supports the mouse and the clipboard. These changes broke it because x-selection-owner-p was not defined. By the way, I don't think x-selection-owner-p, as defined on w32-fns.el, is correct: If I set select-active-regions non-nil on Windows, the active region does not get put into the clipboard. Isn't that the intent of this feature?