From mboxrd@z Thu Jan  1 00:00:00 1970
Path: news.gmane.org!not-for-mail
From: Eli Zaretskii <eliz@gnu.org>
Newsgroups: gmane.emacs.devel
Subject: Problematic change in ebrowse.c
Date: Sat, 03 Jul 2010 11:04:13 +0300
Message-ID: <83zky98002.fsf@gnu.org>
Reply-To: Eli Zaretskii <eliz@gnu.org>
NNTP-Posting-Host: lo.gmane.org
X-Trace: dough.gmane.org 1278144392 31865 80.91.229.12 (3 Jul 2010 08:06:32 GMT)
X-Complaints-To: usenet@dough.gmane.org
NNTP-Posting-Date: Sat, 3 Jul 2010 08:06:32 +0000 (UTC)
Cc: emacs-devel@gnu.org
To: Juanma Barranquero <lekktu@gmail.com>
Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Sat Jul 03 10:06:31 2010
Return-path: <emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org>
Envelope-to: ged-emacs-devel@m.gmane.org
Original-Received: from lists.gnu.org ([199.232.76.165])
	by lo.gmane.org with esmtp (Exim 4.69)
	(envelope-from <emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org>)
	id 1OUxk6-00034P-Fg
	for ged-emacs-devel@m.gmane.org; Sat, 03 Jul 2010 10:06:30 +0200
Original-Received: from localhost ([127.0.0.1]:38139 helo=lists.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43)
	id 1OUxk5-0003VW-0G
	for ged-emacs-devel@m.gmane.org; Sat, 03 Jul 2010 04:06:29 -0400
Original-Received: from [140.186.70.92] (port=54459 helo=eggs.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1OUxjw-0003Ul-Hh
	for emacs-devel@gnu.org; Sat, 03 Jul 2010 04:06:23 -0400
Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.69)
	(envelope-from <eliz@gnu.org>) id 1OUxjv-00023q-A5
	for emacs-devel@gnu.org; Sat, 03 Jul 2010 04:06:20 -0400
Original-Received: from mtaout20.012.net.il ([80.179.55.166]:33836)
	by eggs.gnu.org with esmtp (Exim 4.69) (envelope-from <eliz@gnu.org>)
	id 1OUxjv-00021y-26
	for emacs-devel@gnu.org; Sat, 03 Jul 2010 04:06:19 -0400
Original-Received: from conversion-daemon.a-mtaout20.012.net.il by
	a-mtaout20.012.net.il (HyperSendmail v2007.08) id
	<0L4Z00I002GOQ000@a-mtaout20.012.net.il> for
	emacs-devel@gnu.org; Sat, 03 Jul 2010 11:06:17 +0300 (IDT)
Original-Received: from HOME-C4E4A596F7 ([84.229.12.240]) by a-mtaout20.012.net.il
	(HyperSendmail v2007.08) with ESMTPA id
	<0L4Z00HDR2IGAY40@a-mtaout20.012.net.il>;
	Sat, 03 Jul 2010 11:06:17 +0300 (IDT)
X-012-Sender: halo1@inter.net.il
X-detected-operating-system: by eggs.gnu.org: Solaris 10 (beta)
X-BeenThere: emacs-devel@gnu.org
X-Mailman-Version: 2.1.5
Precedence: list
List-Id: "Emacs development discussions." <emacs-devel.gnu.org>
List-Unsubscribe: <http://lists.gnu.org/mailman/listinfo/emacs-devel>,
	<mailto:emacs-devel-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/archive/html/emacs-devel>
List-Post: <mailto:emacs-devel@gnu.org>
List-Help: <mailto:emacs-devel-request@gnu.org?subject=help>
List-Subscribe: <http://lists.gnu.org/mailman/listinfo/emacs-devel>,
	<mailto:emacs-devel-request@gnu.org?subject=subscribe>
Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org
Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org
Xref: news.gmane.org gmane.emacs.devel:126722
Archived-At: <http://permalink.gmane.org/gmane.emacs.devel/126722>

This change (part of revno 100699):

    === modified file 'lib-src/ebrowse.c'
    --- lib-src/ebrowse.c   2010-07-03 00:50:23 +0000
    +++ lib-src/ebrowse.c   2010-07-03 07:44:17 +0000
    @@ -2385,7 +2385,7 @@ match_qualified_namespace_alias (void)
	     {
	     case IDENT:
	       tmp = (struct link *) xmalloc (sizeof *cur);
    -          tmp->sym = find_namespace (yytext, cur);
    +          tmp->sym = find_namespace (yytext, cur->sym);
	       tmp->next = NULL;
	       if (head)
		 {

might crash at run time, because we are dereferencing `cur' which
could be a NULL pointer.