From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.devel Subject: Re: Emacs-diffs Digest, Vol 94, Issue 89 Date: Fri, 24 Sep 2010 21:00:29 +0200 Message-ID: <83zkv7rmpe.fsf@gnu.org> References: Reply-To: Eli Zaretskii NNTP-Posting-Host: lo.gmane.org X-Trace: dough.gmane.org 1285354853 13938 80.91.229.12 (24 Sep 2010 19:00:53 GMT) X-Complaints-To: usenet@dough.gmane.org NNTP-Posting-Date: Fri, 24 Sep 2010 19:00:53 +0000 (UTC) Cc: emacs-devel@gnu.org To: Lars Magne Ingebrigtsen Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Fri Sep 24 21:00:51 2010 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([199.232.76.165]) by lo.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1OzDVo-0004Ro-6e for ged-emacs-devel@m.gmane.org; Fri, 24 Sep 2010 21:00:48 +0200 Original-Received: from localhost ([127.0.0.1]:53493 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1OzDVn-0000Pv-RO for ged-emacs-devel@m.gmane.org; Fri, 24 Sep 2010 15:00:47 -0400 Original-Received: from [140.186.70.92] (port=48979 helo=eggs.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1OzDVh-0000Nx-VW for emacs-devel@gnu.org; Fri, 24 Sep 2010 15:00:43 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.69) (envelope-from ) id 1OzDVg-0007EJ-Rd for emacs-devel@gnu.org; Fri, 24 Sep 2010 15:00:41 -0400 Original-Received: from mtaout20.012.net.il ([80.179.55.166]:41118) by eggs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1OzDVg-0007E4-KZ for emacs-devel@gnu.org; Fri, 24 Sep 2010 15:00:40 -0400 Original-Received: from conversion-daemon.a-mtaout20.012.net.il by a-mtaout20.012.net.il (HyperSendmail v2007.08) id <0L9900L00LFXY900@a-mtaout20.012.net.il> for emacs-devel@gnu.org; Fri, 24 Sep 2010 21:00:24 +0200 (IST) Original-Received: from HOME-C4E4A596F7 ([77.127.203.3]) by a-mtaout20.012.net.il (HyperSendmail v2007.08) with ESMTPA id <0L9900L4HM4NOT70@a-mtaout20.012.net.il>; Fri, 24 Sep 2010 21:00:24 +0200 (IST) In-reply-to: X-012-Sender: halo1@inter.net.il X-detected-operating-system: by eggs.gnu.org: Solaris 10 (beta) X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:130796 Archived-At: > === modified file 'src/scroll.c' > --- a/src/scroll.c 2010-07-12 17:47:17 +0000 > +++ b/src/scroll.c 2010-09-24 15:20:58 +0000 > @@ -94,7 +94,7 @@ > int free_at_end) > { > register int i, j; > - int frame_lines = FRAME_LINES (frame); > + EMACS_INT frame_lines = FRAME_LINES (frame); Is this really a good idea? There's no chance the number of lines in a frame will overflow a 32-bit int any time soon. SO I think an explicit cast to int is a better solution here. (There are other similar places in this revision.)