From: Eli Zaretskii <eliz@gnu.org>
To: Reuben Thomas <rrt@sc3d.org>
Cc: 8159@debbugs.gnu.org
Subject: bug#8159: file-name-sans-version fails for some git files
Date: Thu, 03 Mar 2011 05:58:06 +0200 [thread overview]
Message-ID: <83zkpcx3ch.fsf@gnu.org> (raw)
In-Reply-To: <AANLkTin4iEre5pawwYjL7YV3PCmaHSg3waZj3L2r5eyE@mail.gmail.com>
> Date: Wed, 2 Mar 2011 22:31:12 +0000
> From: Reuben Thomas <rrt@sc3d.org>
> Cc:
>
> filenames like foo.js.~HEAD~1~ aren't handled properly because of the
> internal tilde.
What would be the "proper" handling of such a file name? What is the
"version" here?
> This is easily fixable by adding tilde to the character class matched
> against (in emacs-23 it's in the source of file-name-sans-version; in
> the trunk it's in the more accessible file-name-version-regexp).
>
> It seems to me that git is commonly-enough used that this is probably
> worth fixing in the source rather than leaving to users who notice the
> problem (especially in emacs-23, where it means redefining
> file-name-sans-version).
file-name-sans-versions is used by Emacs to produce backup file
names. The file name you mention is not in the format of backup file
names that Emacs uses. Extending file-name-sans-versions in the way
you suggest is not enough; we need also extend the format of backup
file names to support this. Otherwise, removing the "version", then
adding another one will not produce a file name in this format.
next prev parent reply other threads:[~2011-03-03 3:58 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-03-02 22:31 bug#8159: file-name-sans-version fails for some git files Reuben Thomas
2011-03-03 3:58 ` Eli Zaretskii [this message]
2011-03-03 12:02 ` Reuben Thomas
2011-03-03 13:36 ` Eli Zaretskii
2011-03-03 13:39 ` Reuben Thomas
2011-03-03 13:57 ` Eli Zaretskii
2011-03-03 14:00 ` Reuben Thomas
2011-03-03 15:09 ` Andreas Schwab
2011-03-03 15:26 ` Reuben Thomas
2011-03-03 16:23 ` Andreas Schwab
2011-03-03 22:58 ` Reuben Thomas
2011-03-04 7:55 ` Eli Zaretskii
2011-03-05 16:42 ` Reuben Thomas
2011-03-05 17:00 ` Eli Zaretskii
2011-03-05 20:36 ` Chong Yidong
2011-03-03 14:33 ` Andreas Schwab
2011-03-03 14:35 ` Reuben Thomas
2011-03-03 14:45 ` Andreas Schwab
2011-03-03 14:53 ` Reuben Thomas
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=83zkpcx3ch.fsf@gnu.org \
--to=eliz@gnu.org \
--cc=8159@debbugs.gnu.org \
--cc=rrt@sc3d.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.