From: Eli Zaretskii <eliz@gnu.org>
To: Dmitry Antipov <dmantipov@yandex.ru>
Cc: emacs-devel@gnu.org
Subject: Re: Proposal: window-system-version function
Date: Mon, 21 May 2012 19:20:23 +0300 [thread overview]
Message-ID: <83zk91y08o.fsf@gnu.org> (raw)
In-Reply-To: <4FBA4CF6.1030007@yandex.ru>
> Date: Mon, 21 May 2012 18:11:02 +0400
> From: Dmitry Antipov <dmantipov@yandex.ru>
>
> This patch replaces global variable 'window-system-version' with the function
> which returns the window system version for the specified frame. An obvious
> reason for this is to have correct results when Emacs is running with both
> TTY and X frames.
Thanks. However, this change breaks backward compatibility. Perhaps
it would be better to leave the variable alone, and _add_ the
function; that would be backward-compatible.
> +It's value is a number:
> + - 0 for a termcap frame,
> + - Major X protocol version for the frame on X display,
> + - Major OS version for the frame on MS-Windows display,
> + - 24 for the frame on direct-write MS-DOS display,
> + - 10 for the frame on a GNUstep or Macintosh Cocoa display.
This is inaccurate at least for MS-DOS and MS-Windows. Do we really
want to document the precise meaning of the values here? Why is that
important?
> +#ifdef HAVE_X_WINDOWS
> + case output_x_window:
> + return make_number (ProtocolVersion (FRAME_X_DISPLAY (f)));
> +#endif
> +#ifdef WINDOWSNT
> + case output_w32:
> + return make_number (w32_major_version);
> +#endif
> +#ifdef MSDOS
> + case output_msdos_raw:
> + return make_number (24);
> +#endif
The MSDOS build supports HAVE_X_WINDOWS as well, so HAVE_X_WINDOWS and
MSDOS are not by themselves mutually exclusive.
> --- src/msdos.c 2012-04-09 13:05:48 +0000
> +++ src/msdos.c 2012-05-21 13:54:49 +0000
> @@ -1813,7 +1813,6 @@
> }
>
> Vinitial_window_system = Qpc;
> - Vwindow_system_version = make_number (23); /* RE Emacs version */
^^^^^^^^^^^^^^^^^^^^^^^^
Which means I goofed. Will fix in a moment.
next prev parent reply other threads:[~2012-05-21 16:20 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-05-21 14:11 Proposal: window-system-version function Dmitry Antipov
2012-05-21 16:03 ` Stefan Monnier
2012-05-21 16:20 ` Eli Zaretskii [this message]
2012-05-22 5:51 ` Dmitry Antipov
2012-05-22 12:41 ` Stefan Monnier
2012-05-22 16:13 ` Eli Zaretskii
2012-05-22 5:08 ` Ken Raeburn
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=83zk91y08o.fsf@gnu.org \
--to=eliz@gnu.org \
--cc=dmantipov@yandex.ru \
--cc=emacs-devel@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.