From: Eli Zaretskii <eliz@gnu.org>
To: jasonr@gnu.org, duyanning@gmail.com
Cc: 13065-done@debbugs.gnu.org
Subject: bug#13065: Bug in x-file-dialog with GetOpenFileName
Date: Tue, 22 Jan 2013 15:32:41 +0200 [thread overview]
Message-ID: <83zk01mjgm.fsf@gnu.org> (raw)
In-Reply-To: <83fw217ycy.fsf@gnu.org>
> Date: Wed, 16 Jan 2013 20:54:05 +0200
> From: Eli Zaretskii <eliz@gnu.org>
> Cc: 13065@debbugs.gnu.org, duyanning@gmail.com
>
> So, unless someone has a better idea, I will soon commit to the
> emacs-24 branch the patch shown below. It fixes the problem on
> Windows 7 and does not affect XP in any visible way. The initial
> amount of memory to reserve was found by trial and error.
>
> (After this patch, the original recipe still doesn't work: you need to
> type "abc" _after_ clicking "Desktop". But the same happens with
> Emacs 23, so I guess this is just a minor change in behavior of
> Windows 7.)
>
> === modified file 'src/w32heap.c'
> --- src/w32heap.c 2013-01-01 09:11:05 +0000
> +++ src/w32heap.c 2013-01-16 18:34:38 +0000
> @@ -98,7 +98,11 @@ allocate_heap (void)
> #ifdef _WIN64
> size_t size = 0x4000000000i64; /* start by asking for 32GB */
> #else
> - size_t size = 0x80000000; /* start by asking for 2GB */
> + /* We used to start with 2GB here, but on Windows 7 that would leave
> + too little room in the address space for threads started by
> + Windows on our behalf, e.g. when we pop up the file selection
> + dialog. */
> + size_t size = 0x68000000; /* start by asking for 1.7GB */
> #endif
> void *ptr = NULL;
No further comments, so I committed this to the emacs-24 branch
(revision 111192), and I'm closing this bug report.
prev parent reply other threads:[~2013-01-22 13:32 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-12-03 11:09 bug#13065: Bug in x-file-dialog with GetOpenFileName Du Yanning
2012-12-04 19:10 ` Eli Zaretskii
2013-01-08 13:10 ` Jason Rumney
2013-01-08 21:26 ` Eli Zaretskii
2013-01-13 12:52 ` Jason Rumney
2013-01-13 16:35 ` Eli Zaretskii
2013-01-15 18:03 ` Eli Zaretskii
2013-01-16 12:23 ` Jason Rumney
2013-01-16 18:54 ` Eli Zaretskii
2013-01-22 13:32 ` Eli Zaretskii [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=83zk01mjgm.fsf@gnu.org \
--to=eliz@gnu.org \
--cc=13065-done@debbugs.gnu.org \
--cc=duyanning@gmail.com \
--cc=jasonr@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.