all messages for Emacs-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
From: Eli Zaretskii <eliz@gnu.org>
To: martin rudalics <rudalics@gmx.at>
Cc: emacs-devel@gnu.org
Subject: Re: Generating byteswap.h on Windows
Date: Fri, 04 Oct 2013 17:09:31 +0300	[thread overview]
Message-ID: <83zjqpb010.fsf@gnu.org> (raw)
In-Reply-To: <524EB8EA.8040707@gmx.at>

> Date: Fri, 04 Oct 2013 14:47:38 +0200
> From: martin rudalics <rudalics@gmx.at>
> CC: emacs-devel@gnu.org
> 
>  > Why leave it to me?
> 
> Because as a rule I only install changes I understand and I don't
> understand makefiles.

If the build was broken, and your change fixes it, the fix is worth
installing, so that others could build successfully.  We can always
improve the fix later, if needed.

IOW, installing a fix can never make things worse than they are when
the build is broken.

> Moreover I now have byteswap.h in my lib directory and according to
> bzr status I would commit that too.  So I'd also have to learn how
> to avoid that.

You can "bzr commit" specific files.  But the general rule for this is
add the file to .bzrignore.

>  > Please install whatever changes you find that fix
>  > any breakage.
> 
> If you can't commit I can do it but at least give me some sort of
> approval first that Paul's patch is correct.

You will always have my approval for committing something that fixes a
broken build.  I just don't want that it will always depend on me,
because I'm sometimes busy or unavailable.

Thanks.



  reply	other threads:[~2013-10-04 14:09 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-10-04  9:59 Generating byteswap.h on Windows martin rudalics
2013-10-04 10:54 ` Eli Zaretskii
2013-10-04 12:47   ` martin rudalics
2013-10-04 14:09     ` Eli Zaretskii [this message]
2013-10-04 14:33       ` martin rudalics
2013-10-04 15:45         ` Paul Eggert
2013-10-04 17:55           ` Eli Zaretskii

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=83zjqpb010.fsf@gnu.org \
    --to=eliz@gnu.org \
    --cc=emacs-devel@gnu.org \
    --cc=rudalics@gmx.at \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/emacs.git
	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.