From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#15899: 24.3.50; regression: `region' overlay is lower priority than default Date: Fri, 15 Nov 2013 21:33:23 +0200 Message-ID: <83zjp5h33w.fsf@gnu.org> References: <78b8713a-e96f-4b4d-990a-3af59ebdf942@default> Reply-To: Eli Zaretskii NNTP-Posting-Host: plane.gmane.org X-Trace: ger.gmane.org 1384544052 21492 80.91.229.3 (15 Nov 2013 19:34:12 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Fri, 15 Nov 2013 19:34:12 +0000 (UTC) Cc: 15899@debbugs.gnu.org To: Drew Adams Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Fri Nov 15 20:34:16 2013 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1VhP9k-00038m-3Q for geb-bug-gnu-emacs@m.gmane.org; Fri, 15 Nov 2013 20:34:16 +0100 Original-Received: from localhost ([::1]:33542 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VhP9j-0005ST-Fl for geb-bug-gnu-emacs@m.gmane.org; Fri, 15 Nov 2013 14:34:15 -0500 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:42754) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VhP9b-0005SM-N8 for bug-gnu-emacs@gnu.org; Fri, 15 Nov 2013 14:34:12 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1VhP9W-0004XM-Oh for bug-gnu-emacs@gnu.org; Fri, 15 Nov 2013 14:34:07 -0500 Original-Received: from debbugs.gnu.org ([140.186.70.43]:42212) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VhP9W-0004XC-LZ for bug-gnu-emacs@gnu.org; Fri, 15 Nov 2013 14:34:02 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.80) (envelope-from ) id 1VhP9W-0004cb-6T for bug-gnu-emacs@gnu.org; Fri, 15 Nov 2013 14:34:02 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Fri, 15 Nov 2013 19:34:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 15899 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: Original-Received: via spool by 15899-submit@debbugs.gnu.org id=B15899.138454402817746 (code B ref 15899); Fri, 15 Nov 2013 19:34:02 +0000 Original-Received: (at 15899) by debbugs.gnu.org; 15 Nov 2013 19:33:48 +0000 Original-Received: from localhost ([127.0.0.1]:56231 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1VhP9I-0004cA-6V for submit@debbugs.gnu.org; Fri, 15 Nov 2013 14:33:48 -0500 Original-Received: from mtaout20.012.net.il ([80.179.55.166]:65429) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1VhP9E-0004br-Hw for 15899@debbugs.gnu.org; Fri, 15 Nov 2013 14:33:46 -0500 Original-Received: from conversion-daemon.a-mtaout20.012.net.il by a-mtaout20.012.net.il (HyperSendmail v2007.08) id <0MWB00A00KONJE00@a-mtaout20.012.net.il> for 15899@debbugs.gnu.org; Fri, 15 Nov 2013 21:33:37 +0200 (IST) Original-Received: from HOME-C4E4A596F7 ([87.69.4.28]) by a-mtaout20.012.net.il (HyperSendmail v2007.08) with ESMTPA id <0MWB00AUGL00BF90@a-mtaout20.012.net.il>; Fri, 15 Nov 2013 21:33:37 +0200 (IST) In-reply-to: <78b8713a-e96f-4b4d-990a-3af59ebdf942@default> X-012-Sender: halo1@inter.net.il X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 3.x X-Received-From: 140.186.70.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.bugs:80614 Archived-At: > Date: Fri, 15 Nov 2013 09:14:37 -0800 (PST) > From: Drew Adams > Cc: monnier@iro.umontreal.ca, 15899@debbugs.gnu.org > > > > This change should be reverted as soon as possible. > > > > It needs not be reverted, I think. We just need to make the > > priority of the region overlay higher than any other overlay. > > 1. I meant that the change to the behavior of the region not > appearing "on top of" other highlighting (except isearch) needs > to be reverted (undone). You cannot revert behavior, only the code. If the new implementation has unwanted side effects, those side effects need to be fixed by further changes. > 2. Region highlighting should *not* be higher priority than > all other overlays. It should not be higher than isearch > highlighting, for instance. There might be other exceptions > too; dunno. See my previous mail. I don't disagree. If there are other overlays that should show through the region, they should have higher priority. > 4. If it was in fact a bug, it's not clear why the fix for it > needed to involve changing region highlighting to use an > overlay. Not clear to me anyway. It doesn't have to be clear. The fact that region highlighting now uses an overlay is an implementation detail. Bug reports should generally remain on the level of behavior, i.e. requirements, they should not normally go to the implementation level. The implementors should have freedom to implement the required behavior as they see fit, as long as the results are reasonable. > My suggestion is to first revert the code change and then > discuss what the bug is that it was intended to fix. If > there is really a bug that needs fixing, then let's please > try to find some other, non-shotgun fix for it. Again, please stay on the level of required behavior, and leave the implementation out of this discussion. As long as there's no evidence that the new implementation cannot possibly accommodate the required behavior, the implementation can stay. > There should be no need to change the longstanding behavior > of the Emacs region just because someone's highlighting does > not show through. Agreed.