bug#19111: 25.0.50; 32 bits temacs.exe is linked with wrong image-base when built on 64 bit Windows host

[Eli Zaretskii <eliz@gnu.org>]

> From: Óscar Fuentes <ofv@wanadoo.es>
> Cc: 19111@debbugs.gnu.org
> Date: Fri, 21 Nov 2014 15:15:32 +0100
> 
> Eli Zaretskii <eliz@gnu.org> writes:
> 
> >> +      t=${t#Target: }
> >
> > Is this portable to Unix shells?  If not, perhaps use the 'eval' trick
> > here.
> 
> This code is never meant to be executed on other than MSYS(2)/Cygwin.
> Does the shell complain if an error is present inside an `if' that it
> doesn't enter? In other words, does the shell perform syntactic checks
> on code that it doesn't execute?

It does, sometimes.  I'll let experts to tell if this is one of those
cases.

> 
> >> +      if test "x$t" = "x"; then
> >> +	  AC_MSG_ERROR([Impossible to determine $cc compiler target.
> >> +Please explicitly provide --target])
> >
> > I would replace this with a warning and go with $canonical as it was
> > determined before.
> 
> `configure' outputs hundreds of messages on quick succession. Warnings
> are useless for the average users (warnings just go unnoticed.) Apart
> from that, if at the user's end the script fails to get the Target from
> the compiler, we would like to know about that new compiler on
> emacs-devel/bugs (gcc 4.x and clang should work; dunno about old gcc
> versions but I expect that 3.x is fine too.)

OTOH, we've lived without this test for quites some time, so suddenly
starting to reject any configurations that might cause this sounds too
drastic to me.