From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#19481: package.el: support .tar archives featuring a pax_global_header entry Date: Sat, 31 Jan 2015 10:41:56 +0200 Message-ID: <83zj8zjq97.fsf@gnu.org> References: <871tne5qsd.fsf@violet.siamics.net> <83bnmibbla.fsf@gnu.org> <87wq5649qu.fsf_-_@violet.siamics.net> <87386ulj7a.fsf@violet.siamics.net> Reply-To: Eli Zaretskii NNTP-Posting-Host: plane.gmane.org X-Trace: ger.gmane.org 1422693794 27435 80.91.229.3 (31 Jan 2015 08:43:14 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Sat, 31 Jan 2015 08:43:14 +0000 (UTC) Cc: 19481@debbugs.gnu.org To: Ivan Shmakov Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Sat Jan 31 09:43:10 2015 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1YHTe1-0001Y8-6c for geb-bug-gnu-emacs@m.gmane.org; Sat, 31 Jan 2015 09:43:09 +0100 Original-Received: from localhost ([::1]:40033 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YHTe0-0003LA-Dt for geb-bug-gnu-emacs@m.gmane.org; Sat, 31 Jan 2015 03:43:08 -0500 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:42006) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YHTdx-0003KD-HR for bug-gnu-emacs@gnu.org; Sat, 31 Jan 2015 03:43:06 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1YHTdu-0003oK-9i for bug-gnu-emacs@gnu.org; Sat, 31 Jan 2015 03:43:05 -0500 Original-Received: from debbugs.gnu.org ([140.186.70.43]:38947) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YHTdu-0003oG-6H for bug-gnu-emacs@gnu.org; Sat, 31 Jan 2015 03:43:02 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.80) (envelope-from ) id 1YHTdt-00071d-UG for bug-gnu-emacs@gnu.org; Sat, 31 Jan 2015 03:43:02 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sat, 31 Jan 2015 08:43:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 19481 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 19481-submit@debbugs.gnu.org id=B19481.142269372426930 (code B ref 19481); Sat, 31 Jan 2015 08:43:01 +0000 Original-Received: (at 19481) by debbugs.gnu.org; 31 Jan 2015 08:42:04 +0000 Original-Received: from localhost ([127.0.0.1]:58420 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1YHTcy-00070I-9F for submit@debbugs.gnu.org; Sat, 31 Jan 2015 03:42:04 -0500 Original-Received: from mtaout20.012.net.il ([80.179.55.166]:48355) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1YHTcw-0006zo-9F for 19481@debbugs.gnu.org; Sat, 31 Jan 2015 03:42:03 -0500 Original-Received: from conversion-daemon.a-mtaout20.012.net.il by a-mtaout20.012.net.il (HyperSendmail v2007.08) id <0NJ100J00986Z900@a-mtaout20.012.net.il> for 19481@debbugs.gnu.org; Sat, 31 Jan 2015 10:41:55 +0200 (IST) Original-Received: from HOME-C4E4A596F7 ([87.69.4.28]) by a-mtaout20.012.net.il (HyperSendmail v2007.08) with ESMTPA id <0NJ100J9C9HVJQA0@a-mtaout20.012.net.il>; Sat, 31 Jan 2015 10:41:55 +0200 (IST) In-reply-to: <87386ulj7a.fsf@violet.siamics.net> X-012-Sender: halo1@inter.net.il X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 3.x X-Received-From: 140.186.70.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.bugs:98922 Archived-At: > From: Ivan Shmakov > Date: Wed, 28 Jan 2015 20:54:33 +0000 > > Please consider the revised patch MIMEd. > > * lisp/tar-mode.el (tar-header-extractable-p): New function. > (tar-untar-buffer): Use it; or use the value of the new optional > argument instead. > > * lisp/emacs-lisp/package.el (package-untar-buffer): Use > tar-header-extractable-p. > (package-tar-file-info): Consider the second file name in the > archive if the first one has no directory component. Thanks. Can we have a test suite for this file, and in particular for these changes? Failing that, please describe how you tested these changes. Otherwise, I have no comments, and no objections to commit this, once we are sure it doesn't break anything.