all messages for Emacs-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
From: Eli Zaretskii <eliz@gnu.org>
To: martin rudalics <rudalics@gmx.at>
Cc: tobias.getzner@gmx.de, 20802@debbugs.gnu.org
Subject: bug#20802: Segfault when showing non-GTK+ tooltip
Date: Mon, 15 Jun 2015 18:01:58 +0300	[thread overview]
Message-ID: <83zj41nhg9.fsf@gnu.org> (raw)
In-Reply-To: <557E8B50.80905@gmx.at>

> Date: Mon, 15 Jun 2015 10:22:40 +0200
> From: martin rudalics <rudalics@gmx.at>
> CC: tobias.getzner@gmx.de, 20802@debbugs.gnu.org
> 
>  > Thanks.  Now I know why this cannot be reproduced on Windows: this is
>  > bug#17524 coming back to haunt us.  That bug was reported on Windows,
>  > I fixed it on Windows, then suggested a similar fix for X, but was
>  > told it didn't help there.
>  >
>  > So now please try making a fix on X similar to commit ebdc80316, and
>  > if that indeed doesn't help with this crash, perhaps some simple
>  > variation of that will.
> 
> Sorry.  I must be missing something very elementary here.  Your "shadow"
> refcounts
> 
> #ifdef GLYPH_DEBUG
> static int image_cache_refcount, dpyinfo_refcount;
> #endif
> 
> are defined iff you have GLYPH_DEBUG defined.  How are these supposed to
> work when GLYPH_DEBUG is not defined?

It cannot, obviously.  Bug#17524 was reported in the GLYPH_DEBUG code:
the assertion there segfaulted when it tried to access the image
cache.  So the code was fixed only for that situation.

Doing that for a non-GLYPH_DEBUG code will require the shadow variable
to come out of that condition as well.  Or use some other flag
variable to indicate that x_free_frame_resources is about to be called
when the refcount was not yet incremented.

IOW, that bug was mentioned as a source of ideas, not as something to
copy verbatim to xfns.c.  Sorry if I was unclear about that.





  reply	other threads:[~2015-06-15 15:01 UTC|newest]

Thread overview: 41+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-06-13  9:18 bug#20802: Segfault when showing non-GTK+ tooltip Tobias Getzner
2015-06-13  9:38 ` Eli Zaretskii
2015-06-13 10:25   ` martin rudalics
2015-06-13 10:54     ` Eli Zaretskii
2015-06-13 13:24       ` martin rudalics
2015-06-13 14:01         ` Eli Zaretskii
2015-06-13 14:28           ` martin rudalics
2015-06-13 14:42             ` Eli Zaretskii
2015-06-14 11:00               ` martin rudalics
2015-06-14 14:12                 ` Eli Zaretskii
2015-06-15  8:22                   ` martin rudalics
2015-06-15 15:01                     ` Eli Zaretskii [this message]
2015-06-15 16:00                       ` martin rudalics
2015-06-15 17:29                         ` Eli Zaretskii
2015-06-16 13:30                           ` martin rudalics
2015-06-16 14:54                             ` Eli Zaretskii
2015-06-17  9:36                   ` martin rudalics
2015-06-17 16:39                     ` Eli Zaretskii
2015-06-17 18:56                       ` Stefan Monnier
2015-06-18 13:37                       ` martin rudalics
2015-06-18 15:53                         ` Eli Zaretskii
2015-06-18 16:48                           ` martin rudalics
2015-06-18 17:17                             ` Eli Zaretskii
2015-06-18 17:36                               ` martin rudalics
2015-06-18 18:00                                 ` Eli Zaretskii
2015-06-19  6:43                                   ` martin rudalics
2022-04-29 11:45     ` Lars Ingebrigtsen
2022-05-28 10:58       ` Lars Ingebrigtsen
2015-06-16  7:21   ` Tobias Getzner
2015-06-16 13:30     ` martin rudalics
2015-06-16 15:34       ` Tobias Getzner
2015-06-16 15:58         ` Eli Zaretskii
2015-06-16 16:34           ` Tobias Getzner
2015-06-16 17:12             ` Eli Zaretskii
2015-06-16 17:31             ` martin rudalics
2015-06-17  7:34               ` Tobias Getzner
2015-06-17  8:04                 ` martin rudalics
2015-06-17 14:11                   ` Tobias Getzner
2015-06-18 13:37                     ` martin rudalics
2015-06-18 14:09                       ` Tobias Getzner
2015-06-17 16:30                 ` Eli Zaretskii

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=83zj41nhg9.fsf@gnu.org \
    --to=eliz@gnu.org \
    --cc=20802@debbugs.gnu.org \
    --cc=rudalics@gmx.at \
    --cc=tobias.getzner@gmx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/emacs.git
	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.