From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.devel Subject: Re: make-pointer-invisible on Windows Date: Wed, 24 Jun 2015 17:50:57 +0300 Message-ID: <83zj3pdusu.fsf@gnu.org> References: <558A75C6.7040003@gmx.at> Reply-To: Eli Zaretskii NNTP-Posting-Host: plane.gmane.org X-Trace: ger.gmane.org 1435157492 19291 80.91.229.3 (24 Jun 2015 14:51:32 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Wed, 24 Jun 2015 14:51:32 +0000 (UTC) Cc: emacs-devel@gnu.org To: martin rudalics Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Wed Jun 24 16:51:17 2015 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1Z7m1E-0003EU-MU for ged-emacs-devel@m.gmane.org; Wed, 24 Jun 2015 16:51:16 +0200 Original-Received: from localhost ([::1]:51114 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Z7m1E-0004A0-47 for ged-emacs-devel@m.gmane.org; Wed, 24 Jun 2015 10:51:16 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:40375) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Z7m19-00049f-Tz for emacs-devel@gnu.org; Wed, 24 Jun 2015 10:51:13 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Z7m16-0003q8-Ke for emacs-devel@gnu.org; Wed, 24 Jun 2015 10:51:11 -0400 Original-Received: from mtaout23.012.net.il ([80.179.55.175]:38407) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Z7m16-0003nt-Cp for emacs-devel@gnu.org; Wed, 24 Jun 2015 10:51:08 -0400 Original-Received: from conversion-daemon.a-mtaout23.012.net.il by a-mtaout23.012.net.il (HyperSendmail v2007.08) id <0NQG00400E5J7900@a-mtaout23.012.net.il> for emacs-devel@gnu.org; Wed, 24 Jun 2015 17:51:07 +0300 (IDT) Original-Received: from HOME-C4E4A596F7 ([87.69.4.28]) by a-mtaout23.012.net.il (HyperSendmail v2007.08) with ESMTPA id <0NQG0043LEL64R50@a-mtaout23.012.net.il>; Wed, 24 Jun 2015 17:51:07 +0300 (IDT) In-reply-to: <558A75C6.7040003@gmx.at> X-012-Sender: halo1@inter.net.il X-detected-operating-system: by eggs.gnu.org: Solaris 10 X-Received-From: 80.179.55.175 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:187471 Archived-At: > Date: Wed, 24 Jun 2015 11:17:58 +0200 > From: martin rudalics > > I intend to apply the attached patch in order to fix this problem for > the Windows build (see Bug#6105 and Bug#12922). Comments welcome. Thanks. > +static void > +w32_toggle_invisible_pointer (struct frame *f, bool invisible) > +{ > + block_input (); > + > + if (f->pointer_invisible != invisible) > + { > + f->pointer_invisible = invisible; > + SET_FRAME_GARBAGED (f); <<<<<<<<<<<<<<<<<<<<<<< > + } That sounds excessive: I think it means that every self-inserting character will trigger thorough redisplay of the frame. Why do you need this? Is there any problem without marking the frame garbaged? Also, what about the equivalent of the X code that makes the pointer visible on focus-in events -- don't we need that on MS-Windows?