all messages for Emacs-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
From: Eli Zaretskii <eliz@gnu.org>
To: martin rudalics <rudalics@gmx.at>
Cc: emacs-devel@gnu.org
Subject: Re: make-pointer-invisible on Windows
Date: Wed, 24 Jun 2015 17:50:57 +0300	[thread overview]
Message-ID: <83zj3pdusu.fsf@gnu.org> (raw)
In-Reply-To: <558A75C6.7040003@gmx.at>

> Date: Wed, 24 Jun 2015 11:17:58 +0200
> From: martin rudalics <rudalics@gmx.at>
> 
> I intend to apply the attached patch in order to fix this problem for
> the Windows build (see Bug#6105 and Bug#12922).  Comments welcome.

Thanks.

> +static void
> +w32_toggle_invisible_pointer (struct frame *f, bool invisible)
> +{
> +  block_input ();
> +
> +  if (f->pointer_invisible != invisible)
> +    {
> +      f->pointer_invisible = invisible;
> +      SET_FRAME_GARBAGED (f); <<<<<<<<<<<<<<<<<<<<<<<
> +    }

That sounds excessive: I think it means that every self-inserting
character will trigger thorough redisplay of the frame.  Why do you
need this?  Is there any problem without marking the frame garbaged?

Also, what about the equivalent of the X code that makes the pointer
visible on focus-in events -- don't we need that on MS-Windows?



  reply	other threads:[~2015-06-24 14:50 UTC|newest]

Thread overview: 22+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-06-24  9:17 make-pointer-invisible on Windows martin rudalics
2015-06-24 14:50 ` Eli Zaretskii [this message]
2015-06-24 17:40   ` martin rudalics
2015-06-24 19:21     ` Eli Zaretskii
2015-06-25  6:36       ` martin rudalics
2015-06-25 15:02         ` Eli Zaretskii
2015-06-26  6:55           ` martin rudalics
2015-06-26  8:43             ` Eli Zaretskii
2015-06-26  9:15               ` martin rudalics
2015-06-26  9:39                 ` Eli Zaretskii
2015-06-26 10:14                   ` martin rudalics
2015-06-26 10:24                     ` Eli Zaretskii
2015-06-28 14:52                       ` Eli Zaretskii
2015-06-29  9:46                         ` martin rudalics
2015-06-28 14:51                   ` Eli Zaretskii
2015-06-29  9:45                     ` martin rudalics
2015-06-29 14:43                       ` Eli Zaretskii
2015-06-29 17:16                         ` martin rudalics
2015-06-29 17:40                           ` Eli Zaretskii
2015-06-30  6:01                             ` martin rudalics
2015-06-30 15:09                               ` Eli Zaretskii
2015-07-02 13:21                                 ` martin rudalics

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=83zj3pdusu.fsf@gnu.org \
    --to=eliz@gnu.org \
    --cc=emacs-devel@gnu.org \
    --cc=rudalics@gmx.at \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/emacs.git
	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.