From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#21559: 25.0.50; auto-revert-mode breaks git rebase Date: Mon, 28 Sep 2015 17:35:58 +0300 Message-ID: <83zj06d31t.fsf@gnu.org> References: <87wpvebraz.fsf@smart-cactus.org> <83mvw9hbks.fsf@gnu.org> <87612uzla3.fsf@smart-cactus.org> Reply-To: Eli Zaretskii NNTP-Posting-Host: plane.gmane.org X-Trace: ger.gmane.org 1443473085 32335 80.91.229.3 (28 Sep 2015 20:44:45 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Mon, 28 Sep 2015 20:44:45 +0000 (UTC) Cc: 21559@debbugs.gnu.org To: Ben Gamari Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Mon Sep 28 22:44:34 2015 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1ZgfHm-0005pQ-0D for geb-bug-gnu-emacs@m.gmane.org; Mon, 28 Sep 2015 22:44:34 +0200 Original-Received: from localhost ([::1]:40790 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZgfHl-00087s-46 for geb-bug-gnu-emacs@m.gmane.org; Mon, 28 Sep 2015 16:44:33 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:42652) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZgZXC-0003Jt-4O for bug-gnu-emacs@gnu.org; Mon, 28 Sep 2015 10:36:07 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ZgZX7-0006gB-Vy for bug-gnu-emacs@gnu.org; Mon, 28 Sep 2015 10:36:06 -0400 Original-Received: from debbugs.gnu.org ([208.118.235.43]:57840) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZgZX7-0006g7-T6 for bug-gnu-emacs@gnu.org; Mon, 28 Sep 2015 10:36:01 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.80) (envelope-from ) id 1ZgZX7-0000QW-P4 for bug-gnu-emacs@gnu.org; Mon, 28 Sep 2015 10:36:01 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Mon, 28 Sep 2015 14:36:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 21559 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: Original-Received: via spool by 21559-submit@debbugs.gnu.org id=B21559.14434509531626 (code B ref 21559); Mon, 28 Sep 2015 14:36:01 +0000 Original-Received: (at 21559) by debbugs.gnu.org; 28 Sep 2015 14:35:53 +0000 Original-Received: from localhost ([127.0.0.1]:46811 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1ZgZWy-0000QA-DX for submit@debbugs.gnu.org; Mon, 28 Sep 2015 10:35:52 -0400 Original-Received: from mtaout22.012.net.il ([80.179.55.172]:63638) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1ZgZWv-0000Px-Bo for 21559@debbugs.gnu.org; Mon, 28 Sep 2015 10:35:50 -0400 Original-Received: from conversion-daemon.a-mtaout22.012.net.il by a-mtaout22.012.net.il (HyperSendmail v2007.08) id <0NVE002005R4AH00@a-mtaout22.012.net.il> for 21559@debbugs.gnu.org; Mon, 28 Sep 2015 17:35:47 +0300 (IDT) Original-Received: from HOME-C4E4A596F7 ([84.94.185.246]) by a-mtaout22.012.net.il (HyperSendmail v2007.08) with ESMTPA id <0NVE001FF5VMYI60@a-mtaout22.012.net.il>; Mon, 28 Sep 2015 17:35:47 +0300 (IDT) In-reply-to: <87612uzla3.fsf@smart-cactus.org> X-012-Sender: halo1@inter.net.il X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 3.x X-Received-From: 208.118.235.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.bugs:107012 Archived-At: > From: Ben Gamari > Cc: 21559@debbugs.gnu.org > Date: Mon, 28 Sep 2015 16:11:16 +0200 > > Eli Zaretskii writes: > > >> From: Ben Gamari > >> Date: Fri, 25 Sep 2015 14:45:56 +0200 > >> > >> One imperfect workaround would be to instead schedule a worker to call > >> `vc-fine-file-hook` at some point in the future when the repository is > >> more likely to be idle (for instance, when there have been no change > >> events for a second or so). > > > > But autorevert already does exactly that: it doesn't act on file > > changes immediately, only once every N seconds. N defaults to 5, > > perhaps you could try customizing auto-revert-interval to a larger > > value to see if that solves the problem. > > > This is not true is auto-revert-use-notify is enabled. You are right, I forgot: things were originally like I described, but were later changed to fix bug#18958. > I threw together a patch [1] implementing the suggestion I presented > above. I have yet to rigorously test it but I have yet to experience the > issue since starting to use it. Thanks. However, it looks like your suggested patch reverts back to what we had before we fixed bug 18958, doesn't it? If so, we will have to look for some other solution, because we don't want to reintroduce that bug. See http://debbugs.gnu.org/cgi/bugreport.cgi?bug=18958#5 for the details.