From: Eli Zaretskii <eliz@gnu.org>
To: Philipp Stephani <p.stephani2@gmail.com>
Cc: aurelien.aptel+emacs@gmail.com, tzz@lifelogs.com,
dancol@dancol.org, emacs-devel@gnu.org
Subject: Re: Reporting Lisp errors in dynamic modules
Date: Fri, 27 Nov 2015 19:39:45 +0200 [thread overview]
Message-ID: <83zixzqr32.fsf@gnu.org> (raw)
In-Reply-To: <CAArVCkR5EHtcF_emZRpxPgSESnEAa7qXt6tqJTSEjVOYrnSqwA@mail.gmail.com>
> From: Philipp Stephani <p.stephani2@gmail.com>
> Date: Fri, 27 Nov 2015 16:40:23 +0000
> Cc: aurelien.aptel+emacs@gmail.com, tzz@lifelogs.com, dancol@dancol.org
>
> I believe the line with "<subr module-call>" is suboptimal, in that it
> looks alien and includes all kinds of unneeded and weirdly formatted
> data. AFAIU, the reason is that we deliberately unintern module-call.
> Should we perhaps reconsider that decision, so that the backtrace is
> in more familiar form? What exactly are the dangers of having
> module-call exposed as any other primitive?
>
>
> - Somebody calls it with the wrong type. Right now it doesn't do any type
> checking, so that would crash/be UB.
We can add checks to countermand that.
> - An existing function outside of Emacs might already be called like that.
Not really a problem, IMO.
> Those are really minor issues, but since module-call is unusable from Lisp or
> module code anyway, I've decided to avoid them by uninterning it. If type
> checking is added and the name clash issue is consider minor, interning it is
> fine.
OK, I will see what I can do, thanks.
> A cleaner approach would be to define module functions as separate kind of
> function object. I think right now we have lists (Lisp closures and lambdas),
> subrs, and bytecode objects, module functions could be a fourth type. But that
> would require more thorough changes.
Yes, indeed.
next prev parent reply other threads:[~2015-11-27 17:39 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-11-27 11:07 Reporting Lisp errors in dynamic modules Eli Zaretskii
2015-11-27 11:20 ` Aurélien Aptel
2015-11-27 11:46 ` Eli Zaretskii
2015-11-27 12:49 ` Aurélien Aptel
2015-11-27 12:53 ` David Kastrup
2015-11-27 14:50 ` Eli Zaretskii
2015-11-27 16:40 ` Philipp Stephani
2015-11-27 17:39 ` Eli Zaretskii [this message]
2015-11-27 18:01 ` Philipp Stephani
2015-11-27 18:11 ` Eli Zaretskii
2015-11-27 18:40 ` Philipp Stephani
2015-11-28 12:04 ` Eli Zaretskii
2015-12-03 5:00 ` Stefan Monnier
2015-12-03 11:33 ` Aurélien Aptel
2015-12-03 13:42 ` Ted Zlatanov
2015-12-03 15:37 ` Stefan Monnier
2015-12-07 19:13 ` Philipp Stephani
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=83zixzqr32.fsf@gnu.org \
--to=eliz@gnu.org \
--cc=aurelien.aptel+emacs@gmail.com \
--cc=dancol@dancol.org \
--cc=emacs-devel@gnu.org \
--cc=p.stephani2@gmail.com \
--cc=tzz@lifelogs.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.