From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.devel Subject: Re: Dynamic modules: MODULE_HANDLE_SIGNALS etc. Date: Mon, 21 Dec 2015 05:33:04 +0200 Message-ID: <83zix4scgf.fsf@gnu.org> References: <83mvu1x6t3.fsf@gnu.org> <565779CD.80405@cs.ucla.edu> <83io4nuc68.fsf@gnu.org> <83r3iht93x.fsf@gnu.org> <838u4psznr.fsf@gnu.org> <56772054.8010401@cs.ucla.edu> Reply-To: Eli Zaretskii NNTP-Posting-Host: plane.gmane.org X-Trace: ger.gmane.org 1450668766 23067 80.91.229.3 (21 Dec 2015 03:32:46 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Mon, 21 Dec 2015 03:32:46 +0000 (UTC) Cc: aurelien.aptel+emacs@gmail.com, p.stephani2@gmail.com, dancol@dancol.org, tzz@lifelogs.com, emacs-devel@gnu.org To: Paul Eggert Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Mon Dec 21 04:32:45 2015 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1aArDJ-0000IH-0f for ged-emacs-devel@m.gmane.org; Mon, 21 Dec 2015 04:32:45 +0100 Original-Received: from localhost ([::1]:42924 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1aArDI-0001dG-AA for ged-emacs-devel@m.gmane.org; Sun, 20 Dec 2015 22:32:44 -0500 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:53660) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1aArDE-0001cv-Ig for emacs-devel@gnu.org; Sun, 20 Dec 2015 22:32:41 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1aArDA-0001QW-HS for emacs-devel@gnu.org; Sun, 20 Dec 2015 22:32:40 -0500 Original-Received: from fencepost.gnu.org ([2001:4830:134:3::e]:51321) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1aArDA-0001QQ-Dn; Sun, 20 Dec 2015 22:32:36 -0500 Original-Received: from 84.94.185.246.cable.012.net.il ([84.94.185.246]:4783 helo=HOME-C4E4A596F7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_128_CBC_SHA1:128) (Exim 4.82) (envelope-from ) id 1aArD8-0005PW-O2; Sun, 20 Dec 2015 22:32:35 -0500 In-reply-to: <56772054.8010401@cs.ucla.edu> (message from Paul Eggert on Sun, 20 Dec 2015 13:40:36 -0800) X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 2001:4830:134:3::e X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:196587 Archived-At: > Cc: aurelien.aptel+emacs@gmail.com, tzz@lifelogs.com, dancol@dancol.org, > emacs-devel@gnu.org > From: Paul Eggert > Date: Sun, 20 Dec 2015 13:40:36 -0800 > > Eli Zaretskii wrote: > >> From: Philipp Stephani > >> Date: Sun, 20 Dec 2015 18:34:03 +0000 > >> Cc: aurelien.aptel+emacs@gmail.com, tzz@lifelogs.com, eggert@cs.ucla.edu, > >> dancol@dancol.org, emacs-devel@gnu.org > >> > >> Thanks, but please mention in these comments that emacs-module.c > >> relies on these requirements. > >> > >> Done. Attached new patch. > > > > Thanks, pushed. > > These newly-added comments are incorrect. Any of these functions can exit > nonlocally due to stack overflow. I assume it's OK to revert them? Then we either cannot use them in emacs-module.c, or should place comments there to the effect that we disregard that possibility (and maybe augment the comments in lisp.h saying that stack overflow is the only allowed reason for non-local exits). Which one do we prefer?