From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.devel Subject: Re: Arbitrary function: find the number(s) of expected arguments Date: Sat, 26 Mar 2016 11:27:24 +0300 Message-ID: <83zitlzlsj.fsf@gnu.org> References: <56E8906C.5050405@lanl.gov> <83y49e731p.fsf@gnu.org> <83pouj0wx8.fsf@gnu.org> Reply-To: Eli Zaretskii NNTP-Posting-Host: plane.gmane.org X-Trace: ger.gmane.org 1458980887 26084 80.91.229.3 (26 Mar 2016 08:28:07 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Sat, 26 Mar 2016 08:28:07 +0000 (UTC) Cc: emacs-devel@gnu.org To: Paul Pogonyshev Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Sat Mar 26 09:28:02 2016 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1ajjZh-0003mu-NL for ged-emacs-devel@m.gmane.org; Sat, 26 Mar 2016 09:28:01 +0100 Original-Received: from localhost ([::1]:59330 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ajjZg-0002Dz-Cb for ged-emacs-devel@m.gmane.org; Sat, 26 Mar 2016 04:28:00 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:55767) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ajjZb-0002DF-SG for emacs-devel@gnu.org; Sat, 26 Mar 2016 04:27:56 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ajjZW-0006NE-Tn for emacs-devel@gnu.org; Sat, 26 Mar 2016 04:27:55 -0400 Original-Received: from fencepost.gnu.org ([2001:4830:134:3::e]:49567) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ajjZW-0006NA-QB; Sat, 26 Mar 2016 04:27:50 -0400 Original-Received: from 84.94.185.246.cable.012.net.il ([84.94.185.246]:1720 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_128_CBC_SHA1:128) (Exim 4.82) (envelope-from ) id 1ajjZV-0008GP-Ut; Sat, 26 Mar 2016 04:27:50 -0400 In-reply-to: (message from Paul Pogonyshev on Fri, 25 Mar 2016 17:16:42 +0100) X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 2001:4830:134:3::e X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:202252 Archived-At: > Date: Fri, 25 Mar 2016 17:16:42 +0100 > From: Paul Pogonyshev > Cc: emacs-devel@gnu.org > > If we are going to keep sub-arity, I'd prefer if this new function > called it, instead of copying its code inline. > > Done. > > Also, I believe you said you'd write the documentation? Could you > please add that? Then the patch will be ready to go in, I think. > > In the attached patch I modified `doc/lispref/functions.texi': text about > `subr-arity' is moved to a new section above about `func-arity' and > adapted as needed. `subr-arity' is still in the documentation, but I > replaced its description with an advice to use `func-arity' instead. Is > that enough? It's enough, but in the future please also provide a NEWS entry, like the one I added. > Do you still need changelog entries? Long time since I committed > anything to Emacs, maybe you finally got rid of them (I hope)? We no longer maintain ChangeLog files in the repository, but we do request commit log messages in the ChangeLog format, so please do provide them in the future. (I wrote them for you this time.) I pushed the changes to the master branch, thanks. There's one potential issue left: (func-arity 'with-temp-buffer) => error-> Invalid function: with-temp-buffer Is it possible to support macros as well? If not, how about producing a more meaningful error message?