From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.devel Subject: Re: make-xwidget api change patch Date: Sun, 27 Mar 2016 20:29:45 +0300 Message-ID: <83zitjygl2.fsf@gnu.org> References: Reply-To: Eli Zaretskii NNTP-Posting-Host: plane.gmane.org X-Trace: ger.gmane.org 1459099831 31424 80.91.229.3 (27 Mar 2016 17:30:31 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Sun, 27 Mar 2016 17:30:31 +0000 (UTC) Cc: emacs-devel@gnu.org To: joakim@verona.se Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Sun Mar 27 19:30:26 2016 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1akEWA-0006oe-6O for ged-emacs-devel@m.gmane.org; Sun, 27 Mar 2016 19:30:26 +0200 Original-Received: from localhost ([::1]:36808 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1akEW9-0005cR-AH for ged-emacs-devel@m.gmane.org; Sun, 27 Mar 2016 13:30:25 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:54694) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1akEVw-0005cL-Ga for emacs-devel@gnu.org; Sun, 27 Mar 2016 13:30:13 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1akEVr-0006xV-HG for emacs-devel@gnu.org; Sun, 27 Mar 2016 13:30:12 -0400 Original-Received: from fencepost.gnu.org ([2001:4830:134:3::e]:58584) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1akEVr-0006xQ-Eg; Sun, 27 Mar 2016 13:30:07 -0400 Original-Received: from 84.94.185.246.cable.012.net.il ([84.94.185.246]:3422 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_128_CBC_SHA1:128) (Exim 4.82) (envelope-from ) id 1akEVq-0003es-Pd; Sun, 27 Mar 2016 13:30:07 -0400 In-reply-to: (joakim@verona.se) X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 2001:4830:134:3::e X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:202299 Archived-At: > From: joakim@verona.se > Date: Sun, 27 Mar 2016 18:55:48 +0200 > > Eli noticed a problem in the make-xwidget function a while back. > The problem is that the function takes 2 arguments that are never used. > > The type for the webkit widget also has a redundant -osr suffix. > > The patch below attempts to fix these issues. > > The changes are uncontroversial, but since it is late in the cycle I ask > for a review. Looks good to me, thanks. John?