From: Eli Zaretskii <eliz@gnu.org>
To: joakim@verona.se
Cc: emacs-devel@gnu.org
Subject: Re: make-xwidget api change patch
Date: Sun, 27 Mar 2016 20:29:45 +0300 [thread overview]
Message-ID: <83zitjygl2.fsf@gnu.org> (raw)
In-Reply-To: <m3mvpjlv1n.fsf@exodia.verona.se> (joakim@verona.se)
> From: joakim@verona.se
> Date: Sun, 27 Mar 2016 18:55:48 +0200
>
> Eli noticed a problem in the make-xwidget function a while back.
> The problem is that the function takes 2 arguments that are never used.
>
> The type for the webkit widget also has a redundant -osr suffix.
>
> The patch below attempts to fix these issues.
>
> The changes are uncontroversial, but since it is late in the cycle I ask
> for a review.
Looks good to me, thanks.
John?
next prev parent reply other threads:[~2016-03-27 17:29 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-03-27 16:55 make-xwidget api change patch joakim
2016-03-27 17:29 ` Eli Zaretskii [this message]
2016-04-02 21:58 ` John Wiegley
2016-04-03 2:36 ` Paul Eggert
2016-03-27 20:37 ` Paul Eggert
2016-03-27 21:06 ` joakim
2016-03-30 15:37 ` joakim
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=83zitjygl2.fsf@gnu.org \
--to=eliz@gnu.org \
--cc=emacs-devel@gnu.org \
--cc=joakim@verona.se \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.