From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#23595: 25.1.50; file with chinese/japanse chars, vc-diff fails (HG, Git, RCS) Date: Wed, 25 May 2016 19:27:00 +0300 Message-ID: <83zire2je3.fsf@gnu.org> References: <87bn3z4l9i.fsf@mat.ucm.es> <1444321464004323@web25h.yandex.ru> <83h9do67pp.fsf@gnu.org> <21f6198c-a2fc-365f-caf7-79fad5027f1c@yandex.ru> <83twho41xd.fsf@gnu.org> <1f8cf525-c138-03f6-7f17-65015dc5cdfa@yandex.ru> <574543D9.6080901@cs.ucla.edu> Reply-To: Eli Zaretskii NNTP-Posting-Host: plane.gmane.org X-Trace: ger.gmane.org 1464193709 3729 80.91.229.3 (25 May 2016 16:28:29 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Wed, 25 May 2016 16:28:29 +0000 (UTC) Cc: oub@mat.ucm.es, dgutov@yandex.ru, 23595@debbugs.gnu.org To: Paul Eggert Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Wed May 25 18:28:18 2016 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1b5bfM-0006nQ-0h for geb-bug-gnu-emacs@m.gmane.org; Wed, 25 May 2016 18:28:16 +0200 Original-Received: from localhost ([::1]:33960 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1b5bfL-00050y-77 for geb-bug-gnu-emacs@m.gmane.org; Wed, 25 May 2016 12:28:15 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:56810) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1b5bfC-00050b-QD for bug-gnu-emacs@gnu.org; Wed, 25 May 2016 12:28:11 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1b5bf8-00016L-FA for bug-gnu-emacs@gnu.org; Wed, 25 May 2016 12:28:06 -0400 Original-Received: from debbugs.gnu.org ([208.118.235.43]:54379) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1b5bf8-00016E-BJ for bug-gnu-emacs@gnu.org; Wed, 25 May 2016 12:28:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1b5bf8-0002ZR-62 for bug-gnu-emacs@gnu.org; Wed, 25 May 2016 12:28:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Wed, 25 May 2016 16:28:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 23595 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: Original-Received: via spool by 23595-submit@debbugs.gnu.org id=B23595.14641936269811 (code B ref 23595); Wed, 25 May 2016 16:28:02 +0000 Original-Received: (at 23595) by debbugs.gnu.org; 25 May 2016 16:27:06 +0000 Original-Received: from localhost ([127.0.0.1]:38482 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1b5beE-0002YB-IB for submit@debbugs.gnu.org; Wed, 25 May 2016 12:27:06 -0400 Original-Received: from eggs.gnu.org ([208.118.235.92]:37244) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1b5beD-0002XZ-Jt for 23595@debbugs.gnu.org; Wed, 25 May 2016 12:27:05 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1b5be4-0000sn-Ew for 23595@debbugs.gnu.org; Wed, 25 May 2016 12:27:00 -0400 Original-Received: from fencepost.gnu.org ([2001:4830:134:3::e]:52306) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1b5be4-0000sj-BI; Wed, 25 May 2016 12:26:56 -0400 Original-Received: from 84.94.185.246.cable.012.net.il ([84.94.185.246]:1403 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_128_CBC_SHA1:128) (Exim 4.82) (envelope-from ) id 1b5be3-00033i-D6; Wed, 25 May 2016 12:26:55 -0400 In-reply-to: <574543D9.6080901@cs.ucla.edu> (message from Paul Eggert on Tue, 24 May 2016 23:19:05 -0700) X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 208.118.235.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:118663 Archived-At: > Cc: oub@mat.ucm.es, 23595@debbugs.gnu.org > From: Paul Eggert > Date: Tue, 24 May 2016 23:19:05 -0700 > > - Like Eli pointed out, (coding-system-get coding-system-for-read > :ascii-compatible-p) should work about as well. Why doesn't it? > > It doesn't work for EBCDIC. It's easy enough to exempt EBCDIC (and any other similar encodings). > - Shouldn't that change be in vc-coding-system-for-diff? > - It seems to try to fix a separate issue (whether all files use the same coding > system). > > Yes. For emacs-25 that's probably too much, as you suggest. So we can fix the problem in vc-coding-system-for-diff. Revised (more-conservative) patch attached. That patch relies on subtleties of comparing unibyte and multibyte strings, so I don't like it, even if we ignore the issue of computing something whose result is known in advance. I still think we can come up with a simple (and safe for emacs-25) method of identifying the problematic encodings, and leave the general issue of having a new attribute for master. Can we have a patch along those lines, please?