From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#24326: 25.1; Daemon doesn't exit on Windows if kill-emacs-hook asks a question Date: Mon, 12 Sep 2016 21:27:40 +0300 Message-ID: <83zind7z37.fsf@gnu.org> References: <83shtobthc.fsf@gnu.org> <83mvjvbpyk.fsf@gnu.org> Reply-To: Eli Zaretskii NNTP-Posting-Host: blaine.gmane.org X-Trace: blaine.gmane.org 1473704965 14525 195.159.176.226 (12 Sep 2016 18:29:25 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Mon, 12 Sep 2016 18:29:25 +0000 (UTC) To: 24326-done@debbugs.gnu.org Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Mon Sep 12 20:29:22 2016 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1bjVyp-00031k-Va for geb-bug-gnu-emacs@m.gmane.org; Mon, 12 Sep 2016 20:29:20 +0200 Original-Received: from localhost ([::1]:44551 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bjVyo-0003In-1a for geb-bug-gnu-emacs@m.gmane.org; Mon, 12 Sep 2016 14:29:18 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:43448) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bjVyd-0003Gu-RQ for bug-gnu-emacs@gnu.org; Mon, 12 Sep 2016 14:29:08 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1bjVyZ-0007PW-HG for bug-gnu-emacs@gnu.org; Mon, 12 Sep 2016 14:29:06 -0400 Original-Received: from debbugs.gnu.org ([208.118.235.43]:60201) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bjVyZ-0007PR-Eb for bug-gnu-emacs@gnu.org; Mon, 12 Sep 2016 14:29:03 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1bjVyZ-0002FT-2k for bug-gnu-emacs@gnu.org; Mon, 12 Sep 2016 14:29:03 -0400 Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-To: bug-gnu-emacs@gnu.org Resent-Date: Mon, 12 Sep 2016 18:29:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: cc-closed 24326 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: Mail-Followup-To: 24326@debbugs.gnu.org, eliz@gnu.org, eliz@gnu.org Original-Received: via spool by 24326-done@debbugs.gnu.org id=D24326.14737048848553 (code D ref 24326); Mon, 12 Sep 2016 18:29:02 +0000 Original-Received: (at 24326-done) by debbugs.gnu.org; 12 Sep 2016 18:28:04 +0000 Original-Received: from localhost ([127.0.0.1]:57911 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1bjVxb-0002Dt-Po for submit@debbugs.gnu.org; Mon, 12 Sep 2016 14:28:03 -0400 Original-Received: from eggs.gnu.org ([208.118.235.92]:51521) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1bjVxa-0002DN-8z for 24326-done@debbugs.gnu.org; Mon, 12 Sep 2016 14:28:02 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1bjVxR-0006xN-Sp for 24326-done@debbugs.gnu.org; Mon, 12 Sep 2016 14:27:57 -0400 Original-Received: from fencepost.gnu.org ([2001:4830:134:3::e]:41215) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bjVxR-0006wW-Qe for 24326-done@debbugs.gnu.org; Mon, 12 Sep 2016 14:27:53 -0400 Original-Received: from 84.94.185.246.cable.012.net.il ([84.94.185.246]:1977 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_128_CBC_SHA1:128) (Exim 4.82) (envelope-from ) id 1bjVxN-0003er-Sf for 24326-done@debbugs.gnu.org; Mon, 12 Sep 2016 14:27:52 -0400 In-reply-to: <83mvjvbpyk.fsf@gnu.org> (message from Eli Zaretskii on Mon, 29 Aug 2016 17:38:11 +0300) X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 208.118.235.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:123229 Archived-At: > Date: Mon, 29 Aug 2016 17:38:11 +0300 > From: Eli Zaretskii > > diff --git a/lisp/server.el b/lisp/server.el > index 5300984..d34546d 100644 > --- a/lisp/server.el > +++ b/lisp/server.el > @@ -648,7 +648,7 @@ server-start > (add-hook 'delete-frame-functions 'server-handle-delete-frame) > (add-hook 'kill-emacs-query-functions > 'server-kill-emacs-query-function) > - (add-hook 'kill-emacs-hook 'server-force-stop) ;Cleanup upon exit. > + (add-hook 'kill-emacs-hook 'server-force-stop t) ;Cleanup upon exit. > (setq server-process > (apply #'make-network-process > :name server-name > > I wonder if it ever makes sense for server.el to have its > kill-emacs-hook before any others. server-force-stop deletes all the > client frames, so if there are no other frames, our capabilities to > communicate with the user are thereafter seriously degraded. > > If the above is deemed too bold, we could do that only in the daemon, > using daemonp for the test. > > Comments? No further comments, so I went ahead and pushed this to the master branch, and I'm marking this bug done.