From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#24861: [PATCH] Fix annoying "Parsing...done" message in c++-mode Date: Fri, 18 Nov 2016 11:39:42 +0200 Message-ID: <83zikxcejl.fsf@gnu.org> References: <87r36tn2ka.fsf@topbug.net> <87oa1xmyok.fsf@topbug.net> <83d1idmy3c.fsf@gnu.org> <87pomdihhd.fsf@topbug.net> <831sysmnvc.fsf@gnu.org> <87a8dgo13q.fsf@topbug.net> <877f84mgu0.fsf@topbug.net> Reply-To: Eli Zaretskii NNTP-Posting-Host: blaine.gmane.org X-Trace: blaine.gmane.org 1479462014 11131 195.159.176.226 (18 Nov 2016 09:40:14 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Fri, 18 Nov 2016 09:40:14 +0000 (UTC) Cc: 24861@debbugs.gnu.org To: Hong Xu Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Fri Nov 18 10:40:09 2016 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1c7feT-0001kR-FC for geb-bug-gnu-emacs@m.gmane.org; Fri, 18 Nov 2016 10:40:09 +0100 Original-Received: from localhost ([::1]:35371 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1c7feW-0001ek-Pl for geb-bug-gnu-emacs@m.gmane.org; Fri, 18 Nov 2016 04:40:12 -0500 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:60412) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1c7feR-0001dN-Aq for bug-gnu-emacs@gnu.org; Fri, 18 Nov 2016 04:40:08 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1c7feM-0000BQ-ME for bug-gnu-emacs@gnu.org; Fri, 18 Nov 2016 04:40:07 -0500 Original-Received: from debbugs.gnu.org ([208.118.235.43]:45945) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1c7feM-0000BM-IW; Fri, 18 Nov 2016 04:40:02 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1c7feM-0002U0-D7; Fri, 18 Nov 2016 04:40:02 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org, bug-cc-mode@gnu.org Resent-Date: Fri, 18 Nov 2016 09:40:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 24861 X-GNU-PR-Package: emacs,cc-mode X-GNU-PR-Keywords: patch Original-Received: via spool by 24861-submit@debbugs.gnu.org id=B24861.14794619909520 (code B ref 24861); Fri, 18 Nov 2016 09:40:02 +0000 Original-Received: (at 24861) by debbugs.gnu.org; 18 Nov 2016 09:39:50 +0000 Original-Received: from localhost ([127.0.0.1]:33111 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1c7feA-0002TU-7L for submit@debbugs.gnu.org; Fri, 18 Nov 2016 04:39:50 -0500 Original-Received: from eggs.gnu.org ([208.118.235.92]:41136) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1c7fe8-0002TG-UC for 24861@debbugs.gnu.org; Fri, 18 Nov 2016 04:39:49 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1c7fdz-0008WS-0U for 24861@debbugs.gnu.org; Fri, 18 Nov 2016 04:39:43 -0500 Original-Received: from fencepost.gnu.org ([2001:4830:134:3::e]:33434) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1c7fdy-0008WJ-T8; Fri, 18 Nov 2016 04:39:38 -0500 Original-Received: from 84.94.185.246.cable.012.net.il ([84.94.185.246]:2339 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_128_CBC_SHA1:128) (Exim 4.82) (envelope-from ) id 1c7fdy-00012s-72; Fri, 18 Nov 2016 04:39:38 -0500 In-reply-to: <877f84mgu0.fsf@topbug.net> (message from Hong Xu on Tue, 15 Nov 2016 16:03:19 -0800) X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 208.118.235.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:125822 Archived-At: > From: Hong Xu > Cc: 24861@debbugs.gnu.org > Date: Tue, 15 Nov 2016 16:03:19 -0800 > > Can you still consider this patch? I'm okay with accepting this for the master branch, but the patch needs some more work to fix the following issues: . The first line of each doc string should be a complete sentence. . The doc string of cpp-progress-message should mention cpp-message-min-time-interval. . The defcustom you are adding should have a :version tag. . The calculation in cpp-progress-message should be fixed to calculate the time difference between the current time and the time of the previous progress message, and compare that with the value of cpp-message-min-time-interval. The old code just looked at the 2nd member of the list returned by current-time, but that is no longer TRT when you need to compare the time difference, because that member can go back to zero. You need to use time-subtract. . Last, but not least: please include ChangeLog-style commit log message for the changes. Thanks.