From: Eli Zaretskii <eliz@gnu.org>
To: Chris Gregory <czipperz@gmail.com>
Cc: 25339@debbugs.gnu.org
Subject: bug#25339: [PATCH] Remove local variables only used as front ends to others.
Date: Sat, 07 Jan 2017 10:22:02 +0200 [thread overview]
Message-ID: <83zij3b7px.fsf@gnu.org> (raw)
In-Reply-To: <87bmvpccla.fsf@gmail.com> (message from Chris Gregory on Mon, 02 Jan 2017 14:37:53 -0800)
tags 25339 notabug
close 25339
thanks
> From: Chris Gregory <czipperz@gmail.com>
> Date: Mon, 02 Jan 2017 14:37:53 -0800
>
> diff --git a/src/term.c b/src/term.c
> index c067a86d18..d70e2bc9d7 100644
> --- a/src/term.c
> +++ b/src/term.c
> @@ -4161,12 +4161,10 @@ use the Bourne shell command 'TERM=...; export TERM' (C-shell:\n\
> #ifdef WINDOWSNT
> {
> struct frame *f = XFRAME (selected_frame);
> - int height, width;
> -
> - initialize_w32_display (terminal, &width, &height);
> + int height;
>
> + initialize_w32_display (terminal, &FrameCols (tty), &height);
Thanks, but I consider these changes not to be for the better. E.g.,
FrameCols could be a macro (and it actually is in the non-WINDOWSNT
case). Also, the original code looks more natural to me.
So I don't think we should install these changes.
prev parent reply other threads:[~2017-01-07 8:22 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-01-02 22:37 bug#25339: [PATCH] Remove local variables only used as front ends to others Chris Gregory
2017-01-07 8:22 ` Eli Zaretskii [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=83zij3b7px.fsf@gnu.org \
--to=eliz@gnu.org \
--cc=25339@debbugs.gnu.org \
--cc=czipperz@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.