From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#25641: 25.1; insert-char function inconsistency Date: Wed, 08 Feb 2017 19:54:12 +0200 Message-ID: <83zihw4lh7.fsf@gnu.org> References: <83tw8656gf.fsf@gnu.org> <87a89y6ifh.fsf@rosalinde> <87inok7rjf.fsf@rosalinde> Reply-To: Eli Zaretskii NNTP-Posting-Host: blaine.gmane.org X-Trace: blaine.gmane.org 1486576515 8440 195.159.176.226 (8 Feb 2017 17:55:15 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Wed, 8 Feb 2017 17:55:15 +0000 (UTC) Cc: programingfrik@gmail.com, 25641@debbugs.gnu.org To: Stephen Berman Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Wed Feb 08 18:55:12 2017 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1cbWST-0001uu-Px for geb-bug-gnu-emacs@m.gmane.org; Wed, 08 Feb 2017 18:55:09 +0100 Original-Received: from localhost ([::1]:60758 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1cbWSZ-0000OP-7G for geb-bug-gnu-emacs@m.gmane.org; Wed, 08 Feb 2017 12:55:15 -0500 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:50483) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1cbWSP-0000N9-Ny for bug-gnu-emacs@gnu.org; Wed, 08 Feb 2017 12:55:06 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1cbWSM-0002xg-M9 for bug-gnu-emacs@gnu.org; Wed, 08 Feb 2017 12:55:05 -0500 Original-Received: from debbugs.gnu.org ([208.118.235.43]:34050) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1cbWSM-0002xc-JM for bug-gnu-emacs@gnu.org; Wed, 08 Feb 2017 12:55:02 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1cbWSM-0002UP-A4 for bug-gnu-emacs@gnu.org; Wed, 08 Feb 2017 12:55:02 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Wed, 08 Feb 2017 17:55:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 25641 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: Original-Received: via spool by 25641-submit@debbugs.gnu.org id=B25641.14865764619518 (code B ref 25641); Wed, 08 Feb 2017 17:55:02 +0000 Original-Received: (at 25641) by debbugs.gnu.org; 8 Feb 2017 17:54:21 +0000 Original-Received: from localhost ([127.0.0.1]:60482 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1cbWRh-0002TR-AH for submit@debbugs.gnu.org; Wed, 08 Feb 2017 12:54:21 -0500 Original-Received: from eggs.gnu.org ([208.118.235.92]:59287) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1cbWRf-0002TF-Rx for 25641@debbugs.gnu.org; Wed, 08 Feb 2017 12:54:20 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1cbWRY-0002dw-3e for 25641@debbugs.gnu.org; Wed, 08 Feb 2017 12:54:14 -0500 Original-Received: from fencepost.gnu.org ([2001:4830:134:3::e]:59518) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1cbWRY-0002ds-0L; Wed, 08 Feb 2017 12:54:12 -0500 Original-Received: from 84.94.185.246.cable.012.net.il ([84.94.185.246]:2987 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1cbWRW-0006uz-Ss; Wed, 08 Feb 2017 12:54:11 -0500 In-reply-to: <87inok7rjf.fsf@rosalinde> (message from Stephen Berman on Wed, 08 Feb 2017 14:15:00 +0100) X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 208.118.235.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:129125 Archived-At: > From: Stephen Berman > Date: Wed, 08 Feb 2017 14:15:00 +0100 > Cc: 25641@debbugs.gnu.org > > I agree. The following patch does that (the special-casing here has a > precedent in ucs-names in mule-cmds.el, from which the comment is > copied): > > diff --git a/lisp/descr-text.el b/lisp/descr-text.el > index 3971dbb..a1efb67 100644 > --- a/lisp/descr-text.el > +++ b/lisp/descr-text.el > @@ -617,7 +617,14 @@ describe-char > "input method") > (list > (let ((name > - (or (get-char-code-property char 'name) > + (or (when (= char 7) > + ;; Special case for "BELL" which is > + ;; apparently the only char which > + ;; doesn't have a new name and whose > + ;; old-name is shadowed by a newer char > + ;; with that name. > + (car (rassoc char ucs-names))) > + (get-char-code-property char 'name) > (get-char-code-property char 'old-name)))) > (if (and name (assoc-string name (ucs-names))) > (format > > Eli, what do you say? I don't mind, but ucs-names might be nil if the function by the same name was not yet called, so I think we should call it first. Also, I think it would be good to mention this bug report in the comment. Thanks.