From: Eli Zaretskii <eliz@gnu.org>
To: Stephen Berman <stephen.berman@gmx.net>
Cc: programingfrik@gmail.com, 25641@debbugs.gnu.org
Subject: bug#25641: 25.1; insert-char function inconsistency
Date: Wed, 08 Feb 2017 19:54:12 +0200 [thread overview]
Message-ID: <83zihw4lh7.fsf@gnu.org> (raw)
In-Reply-To: <87inok7rjf.fsf@rosalinde> (message from Stephen Berman on Wed, 08 Feb 2017 14:15:00 +0100)
> From: Stephen Berman <stephen.berman@gmx.net>
> Date: Wed, 08 Feb 2017 14:15:00 +0100
> Cc: 25641@debbugs.gnu.org
>
> I agree. The following patch does that (the special-casing here has a
> precedent in ucs-names in mule-cmds.el, from which the comment is
> copied):
>
> diff --git a/lisp/descr-text.el b/lisp/descr-text.el
> index 3971dbb..a1efb67 100644
> --- a/lisp/descr-text.el
> +++ b/lisp/descr-text.el
> @@ -617,7 +617,14 @@ describe-char
> "input method")
> (list
> (let ((name
> - (or (get-char-code-property char 'name)
> + (or (when (= char 7)
> + ;; Special case for "BELL" which is
> + ;; apparently the only char which
> + ;; doesn't have a new name and whose
> + ;; old-name is shadowed by a newer char
> + ;; with that name.
> + (car (rassoc char ucs-names)))
> + (get-char-code-property char 'name)
> (get-char-code-property char 'old-name))))
> (if (and name (assoc-string name (ucs-names)))
> (format
>
> Eli, what do you say?
I don't mind, but ucs-names might be nil if the function by the same
name was not yet called, so I think we should call it first.
Also, I think it would be good to mention this bug report in the
comment.
Thanks.
next prev parent reply other threads:[~2017-02-08 17:54 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-02-07 13:04 bug#25641: 25.1; insert-char function inconsistency Pablo Mercader Alcántara
2017-02-07 16:08 ` Eli Zaretskii
2017-02-07 17:04 ` Stephen Berman
2017-02-08 0:45 ` Pablo Mercader Alcántara
2017-02-08 13:15 ` Stephen Berman
2017-02-08 17:54 ` Eli Zaretskii [this message]
2017-02-08 21:43 ` Stephen Berman
2017-02-08 22:01 ` Pablo Mercader Alcántara
2017-02-09 14:15 ` Stephen Berman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=83zihw4lh7.fsf@gnu.org \
--to=eliz@gnu.org \
--cc=25641@debbugs.gnu.org \
--cc=programingfrik@gmail.com \
--cc=stephen.berman@gmx.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.